Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new commodity for new Investment accounts #47

Open
argaen opened this issue Jul 14, 2023 · 0 comments
Open

Create new commodity for new Investment accounts #47

argaen opened this issue Jul 14, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@argaen
Copy link
Contributor

argaen commented Jul 14, 2023

For new Investment accounts, we always need to create a new commodity (which currently we don't even have a form). To improve the user experience it would be great if the commodity would be created automatically for them.

The idea would be:

  • Read the type field to see if it's an investment.
  • If it is, disable the commodity field and display the name of the account as the new commodity
  • On save, create the commodity together with the account.

We have an edge case here though as for Funds we use the cusip which is different than the name of the account (Yahoo uses a different identifier which is not the ISIN of the fund). In order to workaround this, the idea would be to create a Commodity form /set of fields and display it as part of the the account form (this enables functionality of creating a new commodity inline with the account if needed).

@argaen argaen added the good first issue Good for newcomers label Jul 14, 2023
@argaen argaen mentioned this issue Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant