Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let parent accounts with children to be deleted #958

Open
argaen opened this issue Jun 14, 2024 · 0 comments
Open

Don't let parent accounts with children to be deleted #958

argaen opened this issue Jun 14, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@argaen
Copy link
Contributor

argaen commented Jun 14, 2024

Currently the delete button is being shown for parent accounts that have children. The action of deleting is failing with FOREIGN KEY constraint failed but this shouldn't even be shown.

The condition for showing the delete button is in https://github.com/maffin-io/maffin-app/blob/master/src/components/pages/account/Header.tsx#L28.

EDIT: Apparently this is also for non parent accounts. I see accounts with splits have the delete button enabled? Need to fix this

@argaen argaen added the good first issue Good for newcomers label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant