Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring into node core #17

Closed
calvinmetcalf opened this issue May 5, 2017 · 7 comments
Closed

bring into node core #17

calvinmetcalf opened this issue May 5, 2017 · 7 comments

Comments

@calvinmetcalf
Copy link

At the face to face in Berlin we brought up bringing this into core and exposing it as require('stream').pump. A couple questions:

  1. are you ok with this idea?
  2. do you want to open the pull or are you ok if I or @mcollina does so?
  3. How do you feel about waving copyright on this and end-of-stream? It's OK if you don't want to do so but if you do it will make it significantly less complicated to bring it into node core.
@mafintosh
Copy link
Owner

  1. Sure, as long as these modules stay backwards compat <4 without any babel stuff
  2. You should probably do it
  3. I'm okay waving copyright.

@calvinmetcalf
Copy link
Author

great thanks!

@mafintosh
Copy link
Owner

@calvinmetcalf also cool initiative, forgot to say that.

@phated
Copy link
Contributor

phated commented Jun 15, 2018

This is complete but #41 is needed to inline both APIs.

@rijnhard
Copy link

this was a pleasant surprise, pump transformed my usage of streams and became a defacto for me personally. Thank you to everyone

@mcollina
Copy link

BTW, this is now in core. We have require('stream').pipeline.

@mcollina
Copy link

(this can be closed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants