Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current project status #46

Closed
DanielRuf opened this issue Jan 31, 2019 · 6 comments
Closed

Current project status #46

DanielRuf opened this issue Jan 31, 2019 · 6 comments

Comments

@DanielRuf
Copy link

Hi, what is the current status of this project? Is it still actively maintained?

@mafintosh
Copy link
Owner

Yep!

@matthiasg
Copy link

Good to hear. Am I correct though that beginning with Node 10 and stream.pipeline pump is not longer required ? If so i think it would be appreciated if the README commented on to why or why not ?

@lukesims
Copy link

lukesims commented Jun 5, 2019

@matthiasg you are correct - the following quote from the Node docs confirms it:

pump is only necessary for Nodejs 8.x or earlier, as for Node 10.x or later version, pipeline is introduced to replace for pump. This is a module method to pipe between streams forwarding errors and properly cleaning up and provide a callback when the pipeline is complete.

@mafintosh
Copy link
Owner

Yup, in Node.js 10 pipeline was added (by me :)) to have pump in core. I still use pump personally whenever I want to support Node.js <10

@matthiasg
Copy link

@mafintosh @lukesims sorry had actually read it in the node docs, but had forgotten about it. It would be sensible to mention in this projects README as well though, to close the loop for people coming from other projects (like I did) trying to figure out whether its required. good work btw

@lukesims
Copy link

lukesims commented Jun 5, 2019

I agree with @matthiasg as it would save future users from making the same side-trip to the Node docs that we all did to reach this conclusion. This is the PR if anyone else is interested - good work @mafintosh :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants