Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Test coverage: SetShippingAddressOnCartTest #427

Closed
naydav opened this issue Mar 4, 2019 · 1 comment
Closed

Test coverage: SetShippingAddressOnCartTest #427

naydav opened this issue Mar 4, 2019 · 1 comment
Assignees
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage

Comments

@naydav
Copy link
Contributor

naydav commented Mar 4, 2019

  1. Need to split \Magento\GraphQl\Quote\SetShippingAddressOnCartTest
    into 2 scenarions
- \Magento\GraphQl\Quote\Customer\SetShippingAddressOnCartTest
- \Magento\GraphQl\Quote\Guest\SetShippingAddressOnCartTest
  1. Need to add negative cases (like try to get access to cart if a customer is not an owner)
  2. Case set shipping address if a cart contains only virtual products should be included in both of testcases
  3. Case address without required parameters should be included in both of testcases

Examples you could find in
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest

@naydav naydav added good first issue Good for newcomers test-coverage Contribution Day Tickets is good for start on Contribution Day labels Mar 4, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Mar 4, 2019
@VitaliyBoyko VitaliyBoyko self-assigned this Mar 6, 2019
@naydav
Copy link
Contributor Author

naydav commented Mar 13, 2019

#448

@naydav naydav closed this as completed Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Projects
None yet
Development

No branches or pull requests

2 participants