Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Customer] Deprecate group_id in Customer #910

Closed
paliarush opened this issue Sep 6, 2019 · 1 comment
Closed

[Customer] Deprecate group_id in Customer #910

paliarush opened this issue Sep 6, 2019 · 1 comment

Comments

@paliarush
Copy link
Contributor

Customer group should not be exposed in the storefront scenarios.

Acceptance criteria:

  • Deprecate group_id in Customer type
  • Return null instead of actual group ID for all queries.
@fooman
Copy link
Contributor

fooman commented Sep 16, 2019

Why remove it?

There is lots of reasons one might want to customise the front-end based on customer group. For example you might get to see a different banner, description, etc.

Removing group_id from graphql without a replacement makes building such functionality harder. Not everything is between logged in vs logged out either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants