Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API - No error when updating stock when auto increment is exceeded in inventory_source_item #32540

Closed
5 tasks
bjornmeat opened this issue Mar 18, 2021 · 4 comments · May be fixed by magento/inventory#3309
Closed
5 tasks

API - No error when updating stock when auto increment is exceeded in inventory_source_item #32540

bjornmeat opened this issue Mar 18, 2021 · 4 comments · May be fixed by magento/inventory#3309
Assignees
@vovsky
Labels
Component: Inventory Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@bjornmeat
Copy link

Preconditions (*)

  1. Magento 2.4.1
  2. Magento Rest API

Steps to reproduce (*)

  1. Table inventory_source_item table with source_item_id larger than 4294967295
  2. Post source item update to rest/V1/inventory/source-items
  3. Response will be 200 ok

Expected result (*)

  1. Response from API should be error updating, since data is not stored

Actual result (*)

  1. Response from API is 200 ok
  2. Data is not saved, since max value of primary key source_item_id is type INT with max value of 4294967295

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Mar 18, 2021

Hi @bjornmeat. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Oscar engcom-Oscar added Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Component: Inventory Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 30, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41645 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@gabrieldagama gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label Apr 13, 2021
@vovsky
Copy link
Contributor

vovsky commented Apr 30, 2021

@magento I am working on this

@vovsky vovsky mentioned this issue May 3, 2021
Open
4 tasks
@engcom-Delta
Copy link
Contributor

Hi @bjornmeat ,

Thank you for reporting and collaboration.
Verified the issue on Magento 2.4-develop and the issue is not reproducible. Kindly refer the screenshots.

Steps to reproduce -

  1. Table inventory_source_item table with source_item_id larger than 4294967295, Observe DB does not allow to provide source_item_id larger than 4294967295
    image
  2. Post source item update to rest/V1/inventory/source-items
    image
  3. Response will be 200 ok
    image
    Kindly recheck the issue on latest Magento 2.4-develop instance and Please let us know if you are still facing any issue.
    Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vovsky vovsky

Labels
Component: Inventory Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Low Priority Backlog
Status: Dev In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#32540 Throw error when updating stock when auto increment is exceed… vovsky/inventory
6 participants
@bjornmeat @vovsky @gabrieldagama @magento-engcom-team @engcom-Delta @engcom-Oscar