Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email address soft check #28

Open
vkublytskyi opened this issue Jun 6, 2018 · 3 comments
Open

Email address soft check #28

vkublytskyi opened this issue Jun 6, 2018 · 3 comments
Labels
core Should be implemented as contribution to Magento 2 core Epic postponed Tasks involve Magento core modification and should be done after MVP implementation

Comments

@vkublytskyi
Copy link

vkublytskyi commented Jun 6, 2018

In Japan email address not corresponding to ISO are widely used. As they are not valid from the standard point of view Magento does not accept them. Core should provide possibility to disable this check. The same issue with recently added top level domains (e.g. magento/magento2#11945 and magento/magento2#11689).

On of possible approach is to provide a configuration option to admin that will allow "soft email validation" which will validate that email has format <username with any characters except @>@<domain with any characters except @>. By default this option should be disabled so behaviour will remain the same.

@vkublytskyi vkublytskyi added core Should be implemented as contribution to Magento 2 core Epic labels Jun 6, 2018
@piotrekkaminski
Copy link

Agree with this task (a configuration option, off by default) (although i would prefer to have a working validator that can recognize also Japanese variations in email addresses). However we should still have some level of validation - eg a newline character cannot be used etc - to avoid abusing functionality as spam generator - we have many reports of create account being used this way with spam content being put in name field.

@vkublytskyi
Copy link
Author

@piotrekkaminski I understand security issues related to simplifying validation. But I'm not sure that we can make the decision what would be optimal for all users. That's why my proposal is to provide a basic implementation with a possibility to switch email validation strategy (so merchant will be able to take a decision what is more important allow all users to register or have no spam messages) and will also provide explicit extension point for system integrator programmatically implement solution required for particular merchant if basic implementation is not suitable.

@piotrekkaminski
Copy link

ok makes sense

@vkublytskyi vkublytskyi added the postponed Tasks involve Magento core modification and should be done after MVP implementation label Nov 15, 2018
@vkublytskyi vkublytskyi added this to the Magento Core Improvements milestone Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Should be implemented as contribution to Magento 2 core Epic postponed Tasks involve Magento core modification and should be done after MVP implementation
Projects
None yet
Development

No branches or pull requests

2 participants