From e1b50405c4a18f7e737a3b7938bafa7f144d15d2 Mon Sep 17 00:00:00 2001 From: Umar Date: Mon, 8 Jan 2018 18:15:45 +0500 Subject: [PATCH 1/2] MAGETWO-49985: product custom options export in reverse order fixed --- app/code/Magento/CatalogImportExport/Model/Export/Product.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/code/Magento/CatalogImportExport/Model/Export/Product.php b/app/code/Magento/CatalogImportExport/Model/Export/Product.php index 97a0e6aaebf4f..cf3044c3b5470 100644 --- a/app/code/Magento/CatalogImportExport/Model/Export/Product.php +++ b/app/code/Magento/CatalogImportExport/Model/Export/Product.php @@ -1315,8 +1315,7 @@ protected function getCustomOptionsData($productIds) } $options = $this->_optionColFactory->create(); /* @var \Magento\Catalog\Model\ResourceModel\Product\Option\Collection $options*/ - $options->addOrder('sort_order'); - $options->reset()->addOrder('sort_order')->addTitleToResult( + $options->reset()->addOrder('sort_order', 'ASC')->addTitleToResult( $storeId )->addPriceToResult( $storeId From 558f71410fec7ade13f84c9fb90e1d3f639a351b Mon Sep 17 00:00:00 2001 From: Umar Date: Wed, 10 Jan 2018 14:19:08 +0500 Subject: [PATCH 2/2] refactoring - removed method chaining --- .../CatalogImportExport/Model/Export/Product.php | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/app/code/Magento/CatalogImportExport/Model/Export/Product.php b/app/code/Magento/CatalogImportExport/Model/Export/Product.php index cf3044c3b5470..3ffc02a33254c 100644 --- a/app/code/Magento/CatalogImportExport/Model/Export/Product.php +++ b/app/code/Magento/CatalogImportExport/Model/Export/Product.php @@ -1315,15 +1315,12 @@ protected function getCustomOptionsData($productIds) } $options = $this->_optionColFactory->create(); /* @var \Magento\Catalog\Model\ResourceModel\Product\Option\Collection $options*/ - $options->reset()->addOrder('sort_order', 'ASC')->addTitleToResult( - $storeId - )->addPriceToResult( - $storeId - )->addProductToFilter( - $productIds - )->addValuesToResult( - $storeId - ); + $options->reset(); + $options->addOrder('sort_order', 'ASC'); + $options->addTitleToResult($storeId); + $options->addPriceToResult($storeId); + $options->addProductToFilter($productIds); + $options->addValuesToResult($storeId); foreach ($options as $option) { $row = [];