Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design suggestion for cross browser compitablity #11

Closed
jigneshthummar opened this issue Apr 12, 2012 · 6 comments
Closed

Design suggestion for cross browser compitablity #11

jigneshthummar opened this issue Apr 12, 2012 · 6 comments

Comments

@jigneshthummar
Copy link

I suggest to add browser name and version in body class

for example

right now Magento shows body class name as follow for home page
<body class=" cms-index-index cms-home">

Suggested class name for chrome

<body class="cms-index-index cms-home Chrome Chrome18">

For Firefox

<body class="cms-index-index cms-home Firefox Firefox11">

For IE

<body class="cms-index-index cms-home MSIE MSIE9">

by doing this Magento can remove IE specific conditional css as well

This will help when we want to add browser specific css and even browser version specific css, so when ever i want to make change for perticular browser i just need to write .MSIE .className { property:value; } this is applied to all IE if i want more specfic solution .MSIE9 .className { property:value; } this change only applied for IE9

Please share your thoughts on this
@kirmorozov
Copy link
Member

It's definitely bad idea.
All browsers have their specific css(ex: mos for firefox).
Please fix your css instead of making mess.

@jigneshthummar
Copy link
Author

@kirmorozov yeah u r right browser have their specific css properties,

but its idea for common properties some Wordpress sites use same trick.

@kirmorozov
Copy link
Member

What stops you from adding this class using JavaScript. It won't affect performance much and it wont affect server performance at all.
@jigneshthummar IMHO this is the way to fix some bug with own css.

P.S. Probably you didn't heard of http://code.google.com/p/ie7-js/

@Flyingmana
Copy link
Member

i have used https://github.com/rafaelp/css_browser_selector for this since some time now.
So either you dont care about this, and give a note in manual to this library or add this as standard library (what sure has its benefits)

And if we talk about this, http://modernizr.com/ belongs in the same area, than many things are depending on a feature, not on a browser.

In any case, its a theming question. Maybe its the best to have a more simple js-less main theme, and an additional "perfect" theme which makes havy use of js.

@magento-team
Copy link
Contributor

@jigneshthummar
Thank you for suggestion. We'll not implement it though -- as @kirmorozov and @Flyingmana pointed out, there are more effective solutions are possible without affecting server performance.

@jigneshthummar
Copy link
Author

Ok thanks @Flyingmana @kirmorozov for their valuable suggestions :)

@florinelchis florinelchis mentioned this issue Jun 4, 2012
Closed
@hackin88 hackin88 mentioned this issue Feb 13, 2013
Closed
@hidonet hidonet mentioned this issue Feb 20, 2013
Closed
@SunshineTech SunshineTech mentioned this issue Dec 5, 2013
Closed
@maksek maksek mentioned this issue Dec 27, 2013
Closed
@drexlma drexlma mentioned this issue Apr 1, 2014
Closed
@drexlma drexlma mentioned this issue Jun 12, 2014
Closed
@leeyisoft leeyisoft mentioned this issue Jun 14, 2014
Closed
@tarikQT tarikQT mentioned this issue Sep 20, 2014
Closed
@WouterSteen WouterSteen mentioned this issue Oct 3, 2014
Closed
@magicento magicento mentioned this issue Oct 13, 2014
Closed
@MihaiCraciun MihaiCraciun mentioned this issue Nov 12, 2014
Closed
This was referenced Nov 22, 2014
Closed
Closed
Closed
@Crustymd Crustymd mentioned this issue Dec 11, 2014
Closed
@aishwaryacedcoss aishwaryacedcoss mentioned this issue Dec 13, 2014
Closed
@askwhyweb askwhyweb mentioned this issue Dec 18, 2014
Closed
@sivajik34 sivajik34 mentioned this issue Jan 2, 2015
Closed
@shivkumarsingh7 shivkumarsingh7 mentioned this issue Jan 5, 2015
Closed
@mattisbusycom mattisbusycom mentioned this issue Jan 16, 2015
Closed
@rgauny rgauny mentioned this issue Jan 23, 2015
Closed
@Antonioele Antonioele mentioned this issue Jan 24, 2015
Closed
@niku0911 niku0911 mentioned this issue Jan 14, 2023
Closed
@git-seb git-seb mentioned this issue Jan 17, 2023
Closed
5 tasks
@Kiril0v Kiril0v mentioned this issue Feb 7, 2023
Closed
5 tasks
This was referenced Feb 17, 2023
Open
Closed
adamzero1 referenced this issue in adamzero1/magento2 Feb 26, 2023
@Vinai
Merge pull request #11 from lefte/feature/issue-5-github-action-seman…
d8f1ca2 
…tic-checker

Issue #5 GitHub Action Semantic Checker
@technicalrajni technicalrajni mentioned this issue Mar 18, 2023
Closed
5 tasks
@angelo983 angelo983 mentioned this issue Mar 27, 2023
Closed
5 tasks
@kisfelix kisfelix mentioned this issue Apr 4, 2023
Closed
5 tasks
@yohangwak yohangwak mentioned this issue May 5, 2023
Open
5 tasks
@makkoff makkoff mentioned this issue May 30, 2023
Closed
5 tasks
@xtremevision xtremevision mentioned this issue Jun 26, 2023
Closed
5 tasks
@lfluvisotto lfluvisotto mentioned this issue Jul 5, 2023
Closed
5 tasks
@Hexmage Hexmage mentioned this issue Jul 11, 2023
Closed
5 tasks
@dandrikop dandrikop mentioned this issue Jul 15, 2023
Closed
5 tasks
Open
5 tasks
@chammedinger chammedinger mentioned this issue Oct 16, 2023
Closed
5 tasks
Closed
5 tasks
@iranimij iranimij mentioned this issue Nov 21, 2023
Closed
5 tasks
@nabeelfocus nabeelfocus mentioned this issue Jan 3, 2024
Closed
5 tasks
@dronerdk dronerdk mentioned this issue Feb 22, 2024
Closed
5 tasks
@nomis11uk nomis11uk mentioned this issue Apr 9, 2024
Closed
5 tasks
@AndeeKnitsLTD AndeeKnitsLTD mentioned this issue May 1, 2024
Closed
5 tasks
@engcom-Dash engcom-Dash mentioned this issue May 8, 2024
Open
5 tasks
@ghost ghost mentioned this issue May 13, 2024
Closed
5 tasks
@malikabid malikabid mentioned this issue May 21, 2024
Closed
5 tasks
@dverkade dverkade mentioned this issue May 28, 2024
Open
5 tasks
@shakeblue shakeblue mentioned this issue May 31, 2024
Closed
5 tasks
@aurel5542 aurel5542 mentioned this issue Jun 29, 2024
Closed
5 tasks
@FabXav FabXav mentioned this issue Oct 11, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Flyingmana @jigneshthummar @kirmorozov @magento-team