Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Agent Rules table headers do match content of rows. #16703

Closed
JRhyne opened this issue Jul 10, 2018 · 8 comments
Closed

User Agent Rules table headers do match content of rows. #16703

JRhyne opened this issue Jul 10, 2018 · 8 comments
Labels
Component: Backend Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@JRhyne
Copy link

JRhyne commented Jul 10, 2018

Preconditions

  1. Magento 2.2.4
  2. PHP 7.1
  3. MariaDB 10.1.33

Steps to reproduce

  1. Get to the page where you can edit a design configuration (change the theme)
  2. Click on 'Add New User Agent Rule' under User Agent Rules

Expected result

  1. The headers of the user agent rules table should align with the content of the table's rows.

Actual result

  1. The headers of the user agent rules table are not in order.
    screen shot 2018-07-10 at 4 33 17 pm
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 10, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 10, 2018 •
edited by JRhyne
Loading

Hi @JRhyne. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@JRhyne do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@JRhyne
Copy link
Author

JRhyne commented Jul 10, 2018

@magento-engcom-team give me 2.2.4 instance

@magento-engcom-team
Copy link
Contributor

Hi @JRhyne. Thank you for your request. I'm working on Magento 2.2.4 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @JRhyne, here is your Magento instance.
Admin access: https://i-16703-2-2-4.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@JRhyne
Copy link
Author

JRhyne commented Jul 10, 2018

@magento-engcom-team I have confirmed this issue on the fresh instance.

@JRhyne JRhyne mentioned this issue Jul 10, 2018
Merged
4 tasks
@engcom-backlog-nickolas engcom-backlog-nickolas added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Admin Panel Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release help wanted labels Jul 11, 2018
@engcom-backlog-nickolas
Copy link

Hello @JRhyne, thank you for your report and pull request.
We've acknowledged the issue and added to our backlog.

@engcom-backlog-nickolas engcom-backlog-nickolas removed their assignment Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @JRhyne. Thank you for your report.
The issue has been fixed in #16704 by @JRhyne in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 13, 2018
This was referenced Jul 13, 2018
Closed
Closed
Merged
@magento-engcom-team
Copy link
Contributor

Hi @JRhyne. Thank you for your report.
The issue has been fixed in #16792 by @JRhyne in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Backend Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JRhyne @magento-engcom-team @engcom-backlog-nickolas