-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Order - Email is Now Required - Magento 2.2.6 #22251
Comments
Hi @trucatchtraps. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @trucatchtraps do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
@magento-engcom-team give me 2.2.3 instance |
Hi @engcom-backlog-nazar. Thank you for your request. I'm working on Magento 2.2.3 instance for you |
Hi @engcom-backlog-nazar, here is your Magento instance. |
HI @trucatchtraps thank you for you report, this is the "big issue" to have a not required email, and this was included in CHANGELOG.md, so there is a issue in older version where this field was not required. |
That field has never been required in all my time working with Magento. Why is there now an issue with the email not required? And this is for backend orders. I just don't understand why it needs to be required for backend orders. Do you have a commit for the changes? I would like to override them. |
@engcom-backlog-nazar Please can we reopen. The changelog appears to refer to frontend guest checkout and not backend MOTO orders which have never required email and instead generated a random example.com placeholder email. The configuration for the default email domain actually still exists so this is a bug. Default should be not required for MOTO (they are taking telephone calls to place orders - most users here do not have email addresses) |
The commit that rolled back this feature was here: b1eece2#diff-b79fbcef70631d52e90840aaf9a0d94d @joanhe do you know what the reason for removing this feature was? The commit has actually left the constant and the configuration itself dangling with no use. Would be great to see this restored for next version and if necessary made optional. |
✅ Confirmed by @engcom-backlog-nazar Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
I tried reverting that commit with a custom module but received the same results of the email being required on admin order. |
@trucatchtraps We reverted the commit mentioned above and it restored original functionality perfectly. No longer required, and when left blank, auto-generates using the Default Email Domain |
I must have missed something then...will try again |
@driskell - I have tried it a couple different ways but still not showing the override for Magento\Sales\Block\Adminhtml\Order\Create\Form\Account on the backend. Can you please take a look at the custom module I created? The attached files I try to override the whole file, I have also tried to extend the original file and only include the affected classes but neither seems to be working. Thanks! |
I am working on this at #dmcdindia19 |
Hi @solwininfotech. Thank you for working on this issue.
|
@magento-engcom-team give me 2.2.6 instance |
Hi @jayachandraoggy. Thank you for your request. I'm working on Magento 2.2.6 instance for you |
Hi @jayachandraoggy, here is your Magento instance. |
I am working on this #codilar |
Any update to this? I am still not able to revert the commit using a custom module. I moved to 2.3.1 but the issue is still present. I reattached my custom module, if someone wouldn't mind taking a look quick |
I finally was able to remove the required * for the email address, but now when I try to place an order without an email address, I receive the following errors. The value of attribute "Email" must be set |
Important information after discussion with Product Departmen
This issue has been discussed with Magento Product Manager(PO).
Please see for more details: #22648 (comment)
But after a couple of additional meetings with PO was found compromise and solution how it can be fixed/implemented to be approved. Details and requirements here: #22648 (comment)
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
Additional Information (*)
The email field has never been required prior to 2.2.6 even going back to Magento1. Now the email field is required when placing an order on the backend of Magento. There is absolutely no documentation about this change or at least I have not found any. I will revert it with a custom module myself if someone points me to the code that makes it a required field. This needs to be a Config option to have the email required or not required. This is causing us major issues because now we have to try and make up random email address for customers. Not all the people in this world have an email address and some just prefer not to give it out. This is a bug not a feature. Please do not tell me this is normal function of Magento when it hasn't been since the beginning of Magento.
Screenshots (*)
Magento 2.2.4
Magento 2.2.6
The text was updated successfully, but these errors were encountered: