Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap Enable submission to robots.txt has wrong URL #30901

Open
1 of 5 tasks
dverkade opened this issue Nov 12, 2020 · 31 comments
Open
1 of 5 tasks

Sitemap Enable submission to robots.txt has wrong URL #30901

dverkade opened this issue Nov 12, 2020 · 31 comments
Labels
Area: SEO Component: Sitemap Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@dverkade
Copy link
Member

dverkade commented Nov 12, 2020

Preconditions

  1. Magento 2.3.5
  2. Have nginx pointing to the /pub folder as root

Steps to reproduce

  1. Go to Marketing -> Sitemap and create a sitemap
  2. Enable "Submit sitemap to robots.txt" under Stores -> Configuration -> Sitemap XML

Expected result

  1. Sitemap does not have the "pub" folder in the URL
  2. Robots.txt does not reference the "pub" folder in the sitemap URL

Actual result

  1. Sitemap has the /pub/ folder in it, see screenshot: https://2667042cf8efa924a5b80b43b37079a1-2-4-develop.instances.magento-community.engineering/pub/sitemap.xml
  2. Robots.txt has reference to the sitemap with /pub/ in it: https://2667042cf8efa924a5b80b43b37079a1-2-4-develop.instances.magento-community.engineering/pub/sitemap.xml

image

image


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2020

Hi @dverkade. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@dverkade
Copy link
Member Author

@magento I am working on this

@dverkade
Copy link
Member Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @dverkade. Thank you for your request. I'm working on Magento instance for you.

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2020

Hi @ihor-sviziev. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Nov 12, 2020

Hi @dverkade,
In 2.4-develop branch non-pub folder installation was already removed at all in 640cad5#diff-2323d6157444b3cf24d4d76635f27185a4e6ad979b0ec2af53e6592d3ca465d5R13
but till Magento 2.4.2 you can add following thing to your env.php file and it should solve the issue:

'directories' => [
    'document_root_is_pub' => true
]

https://devdocs.magento.com/guides/v2.4/install-gde/tutorials/change-docroot-to-pub.html#3-update-the-envphp-file

Could you confirm that issue is fixing by adding this flag?

@ihor-sviziev ihor-sviziev added the Issue: needs update Additional information is require, waiting for response label Nov 12, 2020
@ihor-sviziev
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you.

@ihor-sviziev
Copy link
Contributor

Just re-checked 2.4-develop branch on test instance - this issue IS reproducing on 2.4-develop.

  1. ✔ Changed "Enable Submission to Robots.txt" to "Yes":
    image

  2. ✔Created & generated sitemap.xml
    ❌Generated URL contains /pub/
    image

  3. ❌ in robots.txt we have incorrect link to sitemap.xml file
    image

@ihor-sviziev ihor-sviziev added Component: Sitemap Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: needs update Additional information is require, waiting for response labels Nov 13, 2020
@magento-engcom-team
Copy link
Contributor

@ihor-sviziev Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 13, 2020
@m2-community-project m2-community-project bot removed the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Nov 13, 2020
@m2-community-project m2-community-project bot removed the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 13, 2020
@ihor-sviziev ihor-sviziev added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Nov 13, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ihor-sviziev
Thank you for verifying the issue. Based on the provided information internal tickets MC-39075 were created

Issue Available: @ihor-sviziev, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ihor-sviziev ihor-sviziev added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Nov 13, 2020
@dverkade
Copy link
Member Author

@ihor-sviziev, thanks for verifying. We've tested this on our development environment as well and can verify that it doesn't work currently.

@sdzhepa sdzhepa added Reported on 2.3.5 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels Nov 13, 2020
@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 19, 2020
@dani97
Copy link
Contributor

dani97 commented Dec 28, 2020

@ihor-sviziev verified it today on 2.4-develop and it is working fine

@dani97
Copy link
Contributor

dani97 commented Dec 28, 2020

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @dani97. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@dani97
Copy link
Contributor

dani97 commented Dec 28, 2020

I could reproduce this in magento instance but not in my local 2.4-develop branch, I have disabled 'document_root_is_pub' setting also

@Bartlomiejsz
Copy link
Contributor

@ihor-sviziev just one note, not sure if it's still the case but I remember that some time ago test instances created here on github had document root placed in ROOT, so one directory above pub (which was really weird since it was not according to Magento best practices).

It would be worth checking if that's still the case since it could be the only configuration in which pub is still added to the url

@ihor-sviziev
Copy link
Contributor

@sidolov @sivaschenko @gabrieldagama,
It seems like an issue with test instances or related to a specific configuration used there. People are saying that it's not reproducing on local env while reproducing on test instances.
Could you look at it?
Thank you!

@dverkade
Copy link
Member Author

dverkade commented Feb 9, 2021

@ihor-sviziev as mentioned in the initial ticket description this issue is reproducible local and on production environments. Test instance from Magento Github reflect this as well, so this is an active issue that needs to be worked on.

@Alexander-Khohklov
Copy link
Contributor

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2022

Hi @Alexander-Khohklov! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@Alexander-Khohklov
Copy link
Contributor

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2022

Hi @Alexander-Khohklov! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@Alexander-Khohklov
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @Alexander-Khohklov. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@Balex70
Copy link

Balex70 commented May 9, 2023

More than two years and this issue is still open :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SEO Component: Sitemap Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Development
Development

No branches or pull requests

10 participants