Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency in Magento/JwtFrameworkAdapter #32578

Closed
1 of 5 tasks
fooman opened this issue Mar 23, 2021 · 9 comments · Fixed by #32612
Closed
1 of 5 tasks

Missing dependency in Magento/JwtFrameworkAdapter #32578

fooman opened this issue Mar 23, 2021 · 9 comments · Fixed by #32612
Assignees
Labels
Component: Jwt Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@fooman
Copy link
Contributor

fooman commented Mar 23, 2021

Preconditions (*)

  1. 2.4-develop

Steps to reproduce (*)

  1. check https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/JwtFrameworkAdapter/Model/JweManager.php#L11
  2. notice use Jose\Component\Encryption\JWEBuilder;
  3. check https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/JwtFrameworkAdapter/composer.json

Expected result (*)

  1. web-token/jwt-framework to be declared as dependency in the module that uses it magento/module-jwt-framework-adapter

Actual result (*)

  1. defined on the global level https://github.com/magento/magento2/blob/2.4-develop/composer.json#L87

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Mar 23, 2021

Hi @fooman. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@fooman fooman changed the title Missing dependency Missing dependency in Magento/JwtFrameworkAdapter Mar 23, 2021
@ihor-sviziev
Copy link
Contributor

Hi @fooman,
Could you create a PR for fixing this issue?

@bgorski bgorski added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Mar 27, 2021
@magento-engcom-team
Copy link
Contributor

@bgorski Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 27, 2021
@m2-community-project m2-community-project bot added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 27, 2021
@magento-engcom-team
Copy link
Contributor

@m2-community-project[bot] Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 27, 2021
@bgorski
Copy link
Contributor

bgorski commented Mar 27, 2021

ok, now I know that this wasn't marked as confirmed in the first place. I'll go ahead and create a PR for this tomorrow if still needed.

@ihor-sviziev ihor-sviziev added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Mar 27, 2021
@m2-community-project m2-community-project bot removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Mar 27, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ihor-sviziev
Thank you for verifying the issue. Based on the provided information internal tickets MC-41613 were created

Issue Available: @ihor-sviziev, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ihor-sviziev ihor-sviziev added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Component: Jwt labels Mar 27, 2021
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Mar 27, 2021

@sivaschenko @sidolov @gabrieldagama from my perspective missing dependency should be treated as P2 priority as it might cause not obvious issues from developer perspective

@ihor-sviziev ihor-sviziev added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 27, 2021
@sivaschenko sivaschenko added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 31, 2021
@sivaschenko
Copy link
Member

@sidolov @gabrieldagama @ihor-sviziev priority is set to P2 as this issue not only affect the dev experience but also can lead to potential errors during codebase analysis, design and automation.

@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 11, 2021
@gabrieldagama
Copy link
Contributor

Hi @fooman. Thank you for your report.
The issue has been fixed in #32612 by @bgorski in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Jwt Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Archived in project
7 participants