Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Code is rendered as text for the billing address's street #36503

Closed
1 of 5 tasks
cdcrothers opened this issue Nov 21, 2022 · 4 comments
Closed
1 of 5 tasks

JS Code is rendered as text for the billing address's street #36503

cdcrothers opened this issue Nov 21, 2022 · 4 comments
Assignees
Labels
Component: GoogleAnalytics Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@cdcrothers
Copy link

Preconditions and environment

  • Magento version 2.4.2-p2 Enterprise and Community
  • Enable google/analytics/active

#25684 (comment)
#26276 (comment)
^ relevant issues that reported and caused the bug.

Steps to reproduce

Reach billing step.
See billing address's street render JS code on the frontend.

image

Expected result

Billing address renders normally.

Actual result

Billing address renders JS code on frontent

Additional information

Short term patch/solution is the apply the patch seen in the other issue's comment linked in the description.

Root cause boils down to some namespacing issues and very poor practices within Array prototype modifications made by prototype.js. The prototype lib has been unsupported for 7+ years. The long term solution would be to remove frontend/luma dependencies on prototype.js.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2022

Hi @cdcrothers. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Nov 22, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 22, 2022
@engcom-November
Copy link
Contributor

Hi @cdcrothers ,
Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop with enterprise edition modules enabled but the issue is not reproducible with below steps performed:
Steps performed:

  1. Configured Google Analytics Account by creating account with property
  2. Copy Measurement ID - Login to Magento admin - Stores - Configuration - Sales - Google API - Enabled and selected Account Type - Google Analytics4, add measurement id and save
  3. Cache clean
  4. Front end - Place Order - No issue: No errors observed in console and order placed successfully.
  5. Created Google tag Manager account and noted container id
  6. Import container (Admin - Container - import container)
  7. Login to Magento admin - Stores - Configuration - Sales - Google API - Select Account Type Google GTag , enter container add and save
  8. Navigate to Content - Design - Configuration - HTML Head section - added the GTM script setup
  9. In the footer section also added the GTM code and save configuration
  10. Clear cache
  11. Front end - Place Order - No issue. Order placed successfully with no errors.
    Kindly recheck the issue on Magento 2.4-develop with enterprise edition and provide missing steps if any if the issue is still reproducible.
    Thank you.
    image
    image

@engcom-November engcom-November added Component: GoogleAnalytics Issue: needs update Additional information is require, waiting for response labels Nov 24, 2022
@engcom-November engcom-November added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Nov 24, 2022
@engcom-November
Copy link
Contributor

Hi @cdcrothers ,
We are closing this issue as there has been no latest update on the same. Kindly reopen / create new issue if you are still facing any issues.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GoogleAnalytics Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

3 participants