Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful attribute option POST returns 'true', not the option hash or value #6300

Closed
dnadle opened this issue Aug 24, 2016 · 16 comments
Closed
Labels
bug report Event: distributed-cd Distributed Contribution Day Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@dnadle
Copy link

dnadle commented Aug 24, 2016

Preconditions

  1. Magento 2.1.0.

Steps to reproduce

  1. POST an new option value using /V1/products/attributes/{attributeCode}/options. Request body looks like {"option": {"label": "FOOBAR"} }
  2. Examine response content.

Expected result

  1. Returned body should contain full record of option inserted including the option "value."

Actual result

  1. Response body contains only 'true'. To learn the value of the newly inserted option you most GET the entire list again.
@mbrinton01
Copy link

@dnadle please provide full POST call used. Thanks!

@dnadle
Copy link
Author

dnadle commented Aug 24, 2016

The full post body is

{ "option":
    {
        "label": "FOOBAR",
        "is_default": false
    }
}

@mbrinton01
Copy link

Thank you @dnadle, I have confirmed this behavior. Tracking internally as a bug under https://jira.corp.magento.com/browse/MAGETWO-57585.

@mbrinton01 mbrinton01 added bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Progress: needs update labels Aug 24, 2016
@dnadle
Copy link
Author

dnadle commented Aug 24, 2016

I'd appreciate it if you could look at #6127 and #6120 as well. These bugs make it very difficult to manage products through the API.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 6, 2017
@magento-engcom-team
Copy link
Contributor

@dnadle, thank you for your report.
We've created internal ticket(s) MAGETWO-57585 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@magento-engcom-team magento-engcom-team added the Event: distributed-cd Distributed Contribution Day label Mar 19, 2018
@k-raputa
Copy link

#distributed-cd

@magento-engcom-team
Copy link
Contributor

@kraputa-sintra thank you for joining. Please accept team invitation here and self-assign the issue.

@magento-engcom-team
Copy link
Contributor

@k-raputa thank you for joining. Please accept team invitation here and self-assign the issue.

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 2, 2019

Hi @milindsingh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@milindsingh
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh, here is your Magento instance.
Admin access: https://i-6300-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@milindsingh
Copy link
Member

milindsingh commented Jan 3, 2019

@dnadle @mbrinton01 I rechecked and found that

  • 2.3-develop : the API response was "id_FOOBAR"
  • 2.2-develop: the API response was "true"

What do you suggest,

  1. We shall use the same object as in return i.e.
{ 
   "option":
       {
           "label": "FOOBAR",
           "is_default": false
       }
}
  1. Or just backport the of 2.3-develop as the return, i.e
"id_FOOBAR"

@mbrinton01
Copy link

@milindsingh Option 2 (backport 2.3-develop approach)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost added Fixed in 2.3.x The issue has been fixed in 2.3 release line and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Apr 4, 2019
@ghost
Copy link

ghost commented Apr 4, 2019

Hi @dnadle thank you for you report, this issue has already fixed in 2.3-develop branch. #19108

@ghost ghost closed this as completed Apr 4, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Event: distributed-cd Distributed Contribution Day Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

5 participants