From 3fa78fd851e9c14d173e334995272fc3232ba929 Mon Sep 17 00:00:00 2001 From: Mayank Date: Thu, 28 Sep 2017 18:03:30 +0530 Subject: [PATCH] Clean up code but getting read of 'Blank line found at start of control structure' coding standard violations --- .../Test/Unit/Gateway/Http/Client/TransactionSaleTest.php | 3 +-- app/code/Magento/Braintree/view/adminhtml/web/js/braintree.js | 1 - app/code/Magento/Braintree/view/base/web/js/validator.js | 1 - .../frontend/web/js/view/payment/method-renderer/cc-form.js | 1 - .../web/js/view/payment/method-renderer/hosted-fields.js | 1 - .../frontend/web/js/view/payment/method-renderer/paypal.js | 1 - 6 files changed, 1 insertion(+), 7 deletions(-) diff --git a/app/code/Magento/Braintree/Test/Unit/Gateway/Http/Client/TransactionSaleTest.php b/app/code/Magento/Braintree/Test/Unit/Gateway/Http/Client/TransactionSaleTest.php index 5cbcfef8b6b9e..0837ecaea7a13 100644 --- a/app/code/Magento/Braintree/Test/Unit/Gateway/Http/Client/TransactionSaleTest.php +++ b/app/code/Magento/Braintree/Test/Unit/Gateway/Http/Client/TransactionSaleTest.php @@ -90,8 +90,7 @@ public function testPlaceRequestSuccess() $this->adapter->expects($this->once()) ->method('sale') ->with($this->getTransferData()) - ->willReturn($response) - ; + ->willReturn($response); $this->loggerMock->expects($this->once()) ->method('debug') diff --git a/app/code/Magento/Braintree/view/adminhtml/web/js/braintree.js b/app/code/Magento/Braintree/view/adminhtml/web/js/braintree.js index 8324cfe463bdb..c8aaa65cebb71 100644 --- a/app/code/Magento/Braintree/view/adminhtml/web/js/braintree.js +++ b/app/code/Magento/Braintree/view/adminhtml/web/js/braintree.js @@ -211,7 +211,6 @@ define([ } if (event.type !== 'fieldStateChange') { - return false; } diff --git a/app/code/Magento/Braintree/view/base/web/js/validator.js b/app/code/Magento/Braintree/view/base/web/js/validator.js index 3ed678cfb7eac..d4ba1ec86bbb5 100644 --- a/app/code/Magento/Braintree/view/base/web/js/validator.js +++ b/app/code/Magento/Braintree/view/base/web/js/validator.js @@ -83,7 +83,6 @@ define([ */ getCountrySpecificCardTypes: function (countryId) { if (typeof this.config.countrySpecificCardTypes[countryId] !== 'undefined') { - return this.config.countrySpecificCardTypes[countryId]; } diff --git a/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js b/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js index 73a7b10d5d30f..2834c0a683979 100644 --- a/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js +++ b/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js @@ -271,7 +271,6 @@ define( billingCountryId = billingAddress.countryId; if (billingCountryId && validator.getCountrySpecificCardTypes(billingCountryId)) { - return validator.collectTypes( availableTypes, validator.getCountrySpecificCardTypes(billingCountryId) ); diff --git a/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/hosted-fields.js b/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/hosted-fields.js index 4e8f0cc4651e4..d2faac6ed792f 100644 --- a/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/hosted-fields.js +++ b/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/hosted-fields.js @@ -104,7 +104,6 @@ define([ } if (event.type !== 'fieldStateChange') { - return false; } diff --git a/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/paypal.js b/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/paypal.js index 9804ee8489625..ca9d3686958b4 100644 --- a/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/paypal.js +++ b/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/paypal.js @@ -299,7 +299,6 @@ define([ var address = quote.shippingAddress(); if (_.isNull(address.postcode) || _.isUndefined(address.postcode)) { - return {}; }