From 5cd7a90ec909e68e1cdfcf90aa1263fa5a3ba6e3 Mon Sep 17 00:00:00 2001
From: Max Chadwick <mpchadwick@gmail.com>
Date: Sat, 28 Mar 2015 15:11:59 -0400
Subject: [PATCH 1/2] Refactor bindRemoveButtons for improved performance

---
 .../catalog/product/attribute/options.phtml      | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml
index 0d0cbb27f2ec5..5f481d0c1bb5c 100644
--- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml
+++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml
@@ -58,7 +58,7 @@
             <td id="delete_button_container_<%- data.id %>" class="col-delete">
                 <input type="hidden" class="delete-flag" name="option[delete][<%- data.id %>]" value="" />
                 <?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()):?>
-                    <button title="<?php echo __('Delete') ?>" type="button"
+                    <button id="delete_button_<%- data.id %>" title="<?php echo __('Delete') ?>" type="button"
                         class="action- scalable delete delete-option"
                         >
                         <span><?php echo __('Delete') ?></span>
@@ -100,7 +100,7 @@ require([
             if (isNewOption && !this.isReadOnly) {
                 this.enableNewOptionDeleteButton(data.id);
             }
-            this.bindRemoveButtons();
+            this.bindRemoveButton(data.id);
             this.itemCount++;
             this.totalItems++;
             this.updateItemsCountField();
@@ -139,19 +139,11 @@ require([
                 button.removeClassName('disabled');
             });
         },
-        bindRemoveButtons: function() {
-            var buttons = $$('.delete-option');
-            for (var i = 0; i < buttons.length; i++) {
-                if (!$(buttons[i]).binded) {
-                    $(buttons[i]).binded = true;
-                    Event.observe(buttons[i], 'click', this.remove.bind(this));
-                }
-            }
+        bindRemoveButton: function(id) {
+            $('delete_button_' + id).observe('click', this.remove.bind(this));
         }
     };
 
-    attributeOption.bindRemoveButtons();
-
     if ($('add_new_option_button')) {
         Event.observe('add_new_option_button', 'click', attributeOption.add.bind(attributeOption));
     }

From 8d259f35e7abc75223b7b3c057a893de97388a03 Mon Sep 17 00:00:00 2001
From: Max Chadwick <mpchadwick@gmail.com>
Date: Sat, 28 Mar 2015 17:55:09 -0400
Subject: [PATCH 2/2] Use event delegation for option delete buttons on manage
 attribute screen

---
 .../templates/catalog/product/attribute/options.phtml    | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml
index 5f481d0c1bb5c..cb96e8ffa5ea4 100644
--- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml
+++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml
@@ -100,7 +100,6 @@ require([
             if (isNewOption && !this.isReadOnly) {
                 this.enableNewOptionDeleteButton(data.id);
             }
-            this.bindRemoveButton(data.id);
             this.itemCount++;
             this.totalItems++;
             this.updateItemsCountField();
@@ -139,14 +138,16 @@ require([
                 button.removeClassName('disabled');
             });
         },
-        bindRemoveButton: function(id) {
-            $('delete_button_' + id).observe('click', this.remove.bind(this));
-        }
     };
 
     if ($('add_new_option_button')) {
         Event.observe('add_new_option_button', 'click', attributeOption.add.bind(attributeOption));
     }
+    
+    $('manage-options-panel').on('click', '.delete-option', function(event, element) {
+        attributeOption.remove(event);
+    });
+
     <?php foreach ($block->getOptionValues() as $_value): ?>
     attributeOption.add(<?php echo $_value->toJson() ?>);
     <?php endforeach; ?>