diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CanonicalUrlRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CanonicalUrlRewriteGeneratorTest.php index f3b2bc674b898..00da64c063fdd 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CanonicalUrlRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CanonicalUrlRewriteGeneratorTest.php @@ -1,4 +1,4 @@ -urlRewriteFactory = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewriteFactory::class) + $this->urlRewriteFactory = $this->getMockBuilder(UrlRewriteFactory::class) ->setMethods(['create']) ->disableOriginalConstructor()->getMock(); - $this->urlRewrite = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + $this->urlRewrite = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); - $this->category = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + $this->category = $this->getMockBuilder(Category::class) ->disableOriginalConstructor()->getMock(); $this->categoryUrlPathGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator::class + CategoryUrlPathGenerator::class )->disableOriginalConstructor()->getMock(); $this->canonicalUrlRewriteGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\Category\CanonicalUrlRewriteGenerator::class, + CanonicalUrlRewriteGenerator::class, [ 'categoryUrlPathGenerator' => $this->categoryUrlPathGenerator, 'urlRewriteFactory' => $this->urlRewriteFactory diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenCategoriesProviderTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenCategoriesProviderTest.php index 88a54af26a21f..e5cba6a9b73ea 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenCategoriesProviderTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenCategoriesProviderTest.php @@ -1,4 +1,4 @@ -category = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + $this->category = $this->getMockBuilder(Category::class) ->disableOriginalConstructor() ->setMethods(['getPath', 'getResourceCollection', 'getResource', 'getLevel', '__wakeup', 'isObjectNew']) ->getMock(); $categoryCollection = $this->getMockBuilder( - \Magento\Catalog\Model\ResourceModel\Collection\AbstractCollection::class + AbstractCollection::class )->disableOriginalConstructor()->setMethods(['addAttributeToSelect', 'addIdFilter'])->getMock(); $this->category->expects($this->any())->method('getPath')->willReturn('category-path'); $this->category->expects($this->any())->method('getResourceCollection')->willReturn($categoryCollection); $categoryCollection->expects($this->any())->method('addAttributeToSelect')->willReturnSelf(); $categoryCollection->expects($this->any())->method('addIdFilter')->with(['id'])->willReturnSelf(); - $this->select = $this->getMockBuilder(\Magento\Framework\DB\Select::class) + $this->select = $this->getMockBuilder(Select::class) ->disableOriginalConstructor()->setMethods(['from', 'where', 'deleteFromSelect'])->getMock(); - $this->connection = $this->createMock(\Magento\Framework\DB\Adapter\AdapterInterface::class); + $this->connection = $this->createMock(AdapterInterface::class); $categoryResource = $this->getMockBuilder(\Magento\Catalog\Model\ResourceModel\Category::class) ->disableOriginalConstructor()->getMock(); $this->category->expects($this->any())->method('getResource')->willReturn($categoryResource); @@ -47,7 +54,7 @@ protected function setUp() $this->select->expects($this->any())->method('from')->willReturnSelf(); $this->childrenCategoriesProvider = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\Category\ChildrenCategoriesProvider::class + ChildrenCategoriesProvider::class ); } diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenUrlRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenUrlRewriteGeneratorTest.php index f8422c7c05fa6..bf9ab3dc58af0 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenUrlRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/ChildrenUrlRewriteGeneratorTest.php @@ -1,67 +1,81 @@ -serializerMock = $this->getMockBuilder(Json::class) ->disableOriginalConstructor() ->getMock(); $this->childrenCategoriesProvider = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Category\ChildrenCategoriesProvider::class + ChildrenCategoriesProvider::class )->disableOriginalConstructor()->getMock(); - $this->category = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + $this->category = $this->getMockBuilder(Category::class) ->disableOriginalConstructor()->getMock(); $this->categoryUrlRewriteGeneratorFactory = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGeneratorFactory::class + CategoryUrlRewriteGeneratorFactory::class )->disableOriginalConstructor()->setMethods(['create'])->getMock(); $this->categoryUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator::class + CategoryUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->categoryRepository = $this->getMockBuilder( - \Magento\Catalog\Model\CategoryRepository::class + CategoryRepository::class )->disableOriginalConstructor()->getMock(); $mergeDataProviderFactory = $this->createPartialMock( - \Magento\UrlRewrite\Model\MergeDataProviderFactory::class, + MergeDataProviderFactory::class, ['create'] ); - $this->mergeDataProvider = new \Magento\UrlRewrite\Model\MergeDataProvider(); + $this->mergeDataProvider = new MergeDataProvider(); $mergeDataProviderFactory->expects($this->once())->method('create')->willReturn($this->mergeDataProvider); $this->childrenUrlRewriteGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\Category\ChildrenUrlRewriteGenerator::class, + ChildrenUrlRewriteGenerator::class, [ 'childrenCategoriesProvider' => $this->childrenCategoriesProvider, 'categoryUrlRewriteGeneratorFactory' => $this->categoryUrlRewriteGeneratorFactory, @@ -85,7 +99,7 @@ public function testGenerate() $saveRewritesHistory = 'flag'; $childId = 2; - $childCategory = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + $childCategory = $this->getMockBuilder(Category::class) ->disableOriginalConstructor()->getMock(); $childCategory->expects($this->once())->method('setData') ->with('save_rewrites_history', $saveRewritesHistory); @@ -97,13 +111,13 @@ public function testGenerate() ->will($this->returnValue($saveRewritesHistory)); $this->categoryUrlRewriteGeneratorFactory->expects($this->once())->method('create') ->will($this->returnValue($this->categoryUrlRewriteGenerator)); - $url1 = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializerMock); + $url1 = new UrlRewrite([], $this->serializerMock); $url1->setRequestPath('category-1') ->setStoreId(1); - $url2 = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializerMock); + $url2 = new UrlRewrite([], $this->serializerMock); $url2->setRequestPath('category-2') ->setStoreId(2); - $url3 = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializerMock); + $url3 = new UrlRewrite([], $this->serializerMock); $url3->setRequestPath('category-1') ->setStoreId(1); $this->categoryUrlRewriteGenerator->expects($this->once())->method('generate') diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CurrentUrlRewritesRegeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CurrentUrlRewritesRegeneratorTest.php index 294cf8562906d..50785703dcdb7 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CurrentUrlRewritesRegeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CurrentUrlRewritesRegeneratorTest.php @@ -1,4 +1,4 @@ -urlRewriteFactory = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewriteFactory::class) + $this->urlRewriteFactory = $this->getMockBuilder(UrlRewriteFactory::class) ->setMethods(['create']) ->disableOriginalConstructor()->getMock(); - $this->urlRewrite = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + $this->urlRewrite = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); - $this->category = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + $this->category = $this->getMockBuilder(Category::class) ->disableOriginalConstructor()->getMock(); $this->categoryUrlPathGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator::class + CategoryUrlPathGenerator::class )->disableOriginalConstructor()->getMock(); - $this->urlRewriteFinder = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Model\Map\UrlRewriteFinder::class) + $this->urlRewriteFinder = $this->getMockBuilder(UrlRewriteFinder::class) ->disableOriginalConstructor()->getMock(); $this->urlRewriteFactory->expects($this->once())->method('create') ->willReturn($this->urlRewrite); $mergeDataProviderFactory = $this->createPartialMock( - \Magento\UrlRewrite\Model\MergeDataProviderFactory::class, + MergeDataProviderFactory::class, ['create'] ); - $this->mergeDataProvider = new \Magento\UrlRewrite\Model\MergeDataProvider; + $this->mergeDataProvider = new MergeDataProvider(); $mergeDataProviderFactory->expects($this->once())->method('create')->willReturn($this->mergeDataProvider); $this->currentUrlRewritesRegenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\Category\CurrentUrlRewritesRegenerator::class, + CurrentUrlRewritesRegenerator::class, [ 'categoryUrlPathGenerator' => $this->categoryUrlPathGenerator, 'urlRewriteFactory' => $this->urlRewriteFactory, @@ -247,8 +259,8 @@ protected function getCurrentRewritesMocks($currentRewrites) { $rewrites = []; foreach ($currentRewrites as $urlRewrite) { - /** @var \PHPUnit_Framework_MockObject_MockObject */ - $url = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + /** @var MockObject */ + $url = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); foreach ($urlRewrite as $key => $value) { $url->expects($this->any()) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/MoveTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/MoveTest.php index 85e8837027151..e36da7e938852 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/MoveTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/MoveTest.php @@ -1,19 +1,21 @@ -objectManager = new ObjectManager($this); $this->categoryUrlPathGeneratorMock = $this->getMockBuilder(CategoryUrlPathGenerator::class) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/RemoveTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/RemoveTest.php index 9189f77453d59..4555bd31488bc 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/RemoveTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/RemoveTest.php @@ -1,18 +1,21 @@ -objectManager = new ObjectManager($this); $this->urlPersistMock = $this->getMockBuilder(UrlPersistInterface::class) @@ -55,7 +58,7 @@ protected function setUp() $this->objectMock = $this->getMockBuilder(Category::class) ->disableOriginalConstructor() ->getMock(); - $this->serializerMock = $this->createMock(\Magento\Framework\Serialize\Serializer\Json::class); + $this->serializerMock = $this->createMock(Json::class); } public function testAroundDelete() diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/UpdateUrlPathTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/UpdateUrlPathTest.php index 1d1f9c7fad91b..fb08c59bd7a2a 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/UpdateUrlPathTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/UpdateUrlPathTest.php @@ -8,18 +8,21 @@ namespace Magento\CatalogUrlRewrite\Test\Unit\Model\Category\Plugin\Category; use Magento\Catalog\Model\Category; +use Magento\Catalog\Model\ResourceModel\Category as CategoryResource; +use Magento\CatalogUrlRewrite\Model\Category\Plugin\Category\UpdateUrlPath; use Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator; use Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator; use Magento\CatalogUrlRewrite\Service\V1\StoreViewService; use Magento\Framework\TestFramework\Unit\Helper\ObjectManager; use Magento\UrlRewrite\Model\UrlPersistInterface; -use PHPUnit_Framework_MockObject_MockObject as MockObject; -use Magento\Catalog\Model\ResourceModel\Category as CategoryResource; +use Magento\UrlRewrite\Service\V1\Data\UrlRewrite; +use PHPUnit\Framework\MockObject\MockObject as MockObject; +use PHPUnit\Framework\TestCase; /** * Unit test for Magento\CatalogUrlRewrite\Model\Category\Plugin\Category\UpdateUrlPath class. */ -class UpdateUrlPathTest extends \PHPUnit\Framework\TestCase +class UpdateUrlPathTest extends TestCase { /** * @var ObjectManager @@ -57,14 +60,14 @@ class UpdateUrlPathTest extends \PHPUnit\Framework\TestCase private $category; /** - * @var \Magento\CatalogUrlRewrite\Model\Category\Plugin\Category\UpdateUrlPath + * @var UpdateUrlPath */ private $updateUrlPathPlugin; /** * @inheritdoc */ - protected function setUp() + protected function setUp(): void { $this->objectManager = new ObjectManager($this); $this->categoryUrlPathGenerator = $this->getMockBuilder(CategoryUrlPathGenerator::class) @@ -104,7 +107,7 @@ protected function setUp() ->getMockForAbstractClass(); $this->updateUrlPathPlugin = $this->objectManager->getObject( - \Magento\CatalogUrlRewrite\Model\Category\Plugin\Category\UpdateUrlPath::class, + UpdateUrlPath::class, [ 'categoryUrlPathGenerator' => $this->categoryUrlPathGenerator, 'categoryUrlRewriteGenerator' => $this->categoryUrlRewriteGenerator, @@ -157,7 +160,7 @@ public function testAroundSaveWithRootCategory() ->method('saveAttribute') ->with($this->category, 'url_path') ->willReturnSelf(); - $generatedUrlRewrite = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + $generatedUrlRewrite = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor() ->getMock(); $this->categoryUrlRewriteGenerator->expects($this->once())->method('generate')->with($this->category) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/StorageTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/StorageTest.php index e4216841bce25..855747b30e7f9 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/StorageTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/StorageTest.php @@ -1,22 +1,24 @@ -storage = $this->getMockBuilder(StorageInterface::class) ->getMockForAbstractClass(); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/GroupTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/GroupTest.php index c843ef44c97de..c29aea69b54b5 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/GroupTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/GroupTest.php @@ -1,26 +1,28 @@ -objectManager = new ObjectManager($this); $this->abstractModelMock = $this->getMockBuilder(AbstractModel::class) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/ViewTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/ViewTest.php index d68fcfddde227..7b71f5c13e227 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/ViewTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/ViewTest.php @@ -1,27 +1,29 @@ -objectManager = new ObjectManager($this); $this->abstractModelMock = $this->getMockBuilder(AbstractModel::class) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryBasedProductRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryBasedProductRewriteGeneratorTest.php index 201e4f9d71e53..aeba4c210f017 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryBasedProductRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryBasedProductRewriteGeneratorTest.php @@ -1,4 +1,4 @@ -productScopeRewriteGeneratorMock = $this->getMockBuilder(ProductScopeRewriteGenerator::class) ->disableOriginalConstructor() diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryProductUrlPathGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryProductUrlPathGeneratorTest.php index 8ba5e68041249..11bfc5e2509e6 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryProductUrlPathGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryProductUrlPathGeneratorTest.php @@ -1,23 +1,21 @@ -productScopeRewriteGeneratorMock = $this->getMockBuilder(ProductScopeRewriteGenerator::class) ->disableOriginalConstructor() diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlPathGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlPathGeneratorTest.php index 7297d150a8e6f..07d3b9ca74528 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlPathGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlPathGeneratorTest.php @@ -1,33 +1,39 @@ -category = $this->createPartialMock(\Magento\Catalog\Model\Category::class, $categoryMethods); - $this->storeManager = $this->createMock(\Magento\Store\Model\StoreManagerInterface::class); - $this->scopeConfig = $this->createMock(\Magento\Framework\App\Config\ScopeConfigInterface::class); - $this->categoryRepository = $this->createMock(\Magento\Catalog\Api\CategoryRepositoryInterface::class); + $this->category = $this->createPartialMock(Category::class, $categoryMethods); + $this->storeManager = $this->createMock(StoreManagerInterface::class); + $this->scopeConfig = $this->createMock(ScopeConfigInterface::class); + $this->categoryRepository = $this->createMock(CategoryRepositoryInterface::class); $this->categoryUrlPathGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator::class, + CategoryUrlPathGenerator::class, [ 'storeManager' => $this->storeManager, 'scopeConfig' => $this->scopeConfig, @@ -143,7 +149,7 @@ public function testGetUrlPathWithParent( $this->category->expects($this->any())->method('isObjectNew')->will($this->returnValue($isCategoryNew)); $methods = ['__wakeup', 'getUrlPath', 'getParentId', 'getLevel', 'dataHasChangedFor', 'load']; - $parentCategory = $this->createPartialMock(\Magento\Catalog\Model\Category::class, $methods); + $parentCategory = $this->createPartialMock(Category::class, $methods); $parentCategory->expects($this->any())->method('getParentId') ->will($this->returnValue($parentCategoryParentId)); $parentCategory->expects($this->any())->method('getLevel')->will($this->returnValue($parentLevel)); @@ -209,7 +215,7 @@ public function testGetUrlPathWithSuffixWithoutStore() $this->category->expects($this->exactly(2))->method('dataHasChangedFor') ->will($this->returnValueMap([['url_key', false], ['path_ids', false]])); - $store = $this->createMock(\Magento\Store\Model\Store::class); + $store = $this->createMock(Store::class); $store->expects($this->once())->method('getId')->will($this->returnValue($currentStoreId)); $this->storeManager->expects($this->once())->method('getStore')->will($this->returnValue($store)); $this->scopeConfig->expects($this->once())->method('getValue') diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlRewriteGeneratorTest.php index 1353dbff17b0b..595d4e13ee2ac 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/CategoryUrlRewriteGeneratorTest.php @@ -1,4 +1,4 @@ -serializer = $this->createMock(\Magento\Framework\Serialize\Serializer\Json::class); + $this->serializer = $this->createMock(Json::class); $this->serializer->expects($this->any()) ->method('serialize') ->willReturnCallback( @@ -62,29 +73,29 @@ function ($value) { return json_decode($value, true); } ); - + $this->currentUrlRewritesRegenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Category\CurrentUrlRewritesRegenerator::class + CurrentUrlRewritesRegenerator::class )->disableOriginalConstructor()->getMock(); $this->canonicalUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Category\CanonicalUrlRewriteGenerator::class + CanonicalUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->childrenUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Category\ChildrenUrlRewriteGenerator::class + ChildrenUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); - $this->storeViewService = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Service\V1\StoreViewService::class) + $this->storeViewService = $this->getMockBuilder(StoreViewService::class) ->disableOriginalConstructor()->getMock(); - $this->category = $this->createMock(\Magento\Catalog\Model\Category::class); - $this->categoryRepository = $this->createMock(\Magento\Catalog\Api\CategoryRepositoryInterface::class); + $this->category = $this->createMock(Category::class); + $this->categoryRepository = $this->createMock(CategoryRepositoryInterface::class); $mergeDataProviderFactory = $this->createPartialMock( - \Magento\UrlRewrite\Model\MergeDataProviderFactory::class, + MergeDataProviderFactory::class, ['create'] ); - $this->mergeDataProvider = new \Magento\UrlRewrite\Model\MergeDataProvider; + $this->mergeDataProvider = new MergeDataProvider(); $mergeDataProviderFactory->expects($this->once())->method('create')->willReturn($this->mergeDataProvider); $this->categoryUrlRewriteGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator::class, + CategoryUrlRewriteGenerator::class, [ 'canonicalUrlRewriteGenerator' => $this->canonicalUrlRewriteGenerator, 'childrenUrlRewriteGenerator' => $this->childrenUrlRewriteGenerator, @@ -106,28 +117,28 @@ public function testGenerationForGlobalScope() $this->category->expects($this->any())->method('getStoreIds')->will($this->returnValue([1])); $this->storeViewService->expects($this->once())->method('doesEntityHaveOverriddenUrlKeyForStore') ->will($this->returnValue(false)); - $canonical = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $canonical = new UrlRewrite([], $this->serializer); $canonical->setRequestPath('category-1') ->setStoreId(1); $this->canonicalUrlRewriteGenerator->expects($this->any())->method('generate') ->will($this->returnValue(['category-1' => $canonical])); - $children1 = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $children1 = new UrlRewrite([], $this->serializer); $children1->setRequestPath('category-2') ->setStoreId(2); - $children2 = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $children2 = new UrlRewrite([], $this->serializer); $children2->setRequestPath('category-22') ->setStoreId(2); $this->childrenUrlRewriteGenerator->expects($this->any())->method('generate') ->with(1, $this->category, $categoryId) ->will($this->returnValue(['category-2' => $children1, 'category-1' => $children2])); - $current = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $current = new UrlRewrite([], $this->serializer); $current->setRequestPath('category-3') ->setStoreId(3); $this->currentUrlRewritesRegenerator->expects($this->any())->method('generate') ->with(1, $this->category, $categoryId) ->will($this->returnValue(['category-3' => $current])); $categoryForSpecificStore = $this->createPartialMock( - \Magento\Catalog\Model\Category::class, + Category::class, ['getUrlKey', 'getUrlPath'] ); $this->categoryRepository->expects($this->once())->method('get')->willReturn($categoryForSpecificStore); @@ -150,7 +161,7 @@ public function testGenerationForSpecificStore() { $this->category->expects($this->any())->method('getStoreId')->will($this->returnValue(1)); $this->category->expects($this->never())->method('getStoreIds'); - $canonical = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $canonical = new UrlRewrite([], $this->serializer); $canonical->setRequestPath('category-1') ->setStoreId(1); $this->canonicalUrlRewriteGenerator->expects($this->any())->method('generate') diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryHashMapTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryHashMapTest.php index dd78c04d2eed8..4426e5d3e998f 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryHashMapTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryHashMapTest.php @@ -1,37 +1,36 @@ -categoryRepository = $this->createMock(CategoryRepository::class); $this->categoryResourceFactory = $this->createPartialMock(CategoryFactory::class, ['create']); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUrlRewriteDatabaseMapTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUrlRewriteDatabaseMapTest.php index 23406c567accc..535ccd799484f 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUrlRewriteDatabaseMapTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUrlRewriteDatabaseMapTest.php @@ -1,45 +1,44 @@ -hashMapPoolMock = $this->createMock(HashMapPool::class); $this->dataCategoryMapMock = $this->createMock(DataProductHashMap::class); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUsedInProductsHashMapTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUsedInProductsHashMapTest.php index 21fa6942975c0..b7ab26020e830 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUsedInProductsHashMapTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataCategoryUsedInProductsHashMapTest.php @@ -1,40 +1,39 @@ -hashMapPoolMock = $this->createMock(HashMapPool::class); $this->dataCategoryMapMock = $this->createMock(DataCategoryHashMap::class); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductHashMapTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductHashMapTest.php index e8ddec97afb65..f2f2f8b649eb9 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductHashMapTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductHashMapTest.php @@ -1,4 +1,4 @@ -hashMapPoolMock = $this->createMock(HashMapPool::class); $this->dataCategoryMapMock = $this->createMock(DataCategoryHashMap::class); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductUrlRewriteDatabaseMapTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductUrlRewriteDatabaseMapTest.php index c55204893f69f..0e6fe49222c99 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductUrlRewriteDatabaseMapTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/DataProductUrlRewriteDatabaseMapTest.php @@ -1,40 +1,39 @@ -hashMapPoolMock = $this->createMock(HashMapPool::class); $this->dataProductMapMock = $this->createMock(DataProductHashMap::class); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/HashMapPoolTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/HashMapPoolTest.php index 823f3a37205d3..a0d92a72293ed 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/HashMapPoolTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/HashMapPoolTest.php @@ -1,4 +1,4 @@ -objectManagerMock = $this->createMock(ObjectManagerInterface::class); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/UrlRewriteFinderTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/UrlRewriteFinderTest.php index 388f9a7950c20..7c245565eec9a 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/UrlRewriteFinderTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Map/UrlRewriteFinderTest.php @@ -1,46 +1,46 @@ -serializerMock = $this->createMock(Json::class); $this->databaseMapPoolMock = $this->createMock(DatabaseMapPool::class); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ObjectRegistryTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ObjectRegistryTest.php index ea24a05830e8e..5f748bc39a799 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ObjectRegistryTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ObjectRegistryTest.php @@ -1,26 +1,29 @@ -object = new \Magento\Framework\DataObject(['id' => 1]); + $this->object = new DataObject(['id' => 1]); $this->objectRegistry = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\ObjectRegistry::class, + ObjectRegistry::class, ['entities' => [$this->object]] ); } @@ -43,7 +46,7 @@ public function testGetList() public function testGetEmptyList() { $objectRegistry = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\ObjectRegistry::class, + ObjectRegistry::class, ['entities' => []] ); $this->assertEquals([], $objectRegistry->getList()); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/AnchorUrlRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/AnchorUrlRewriteGeneratorTest.php index d8fec2de0e46e..17ccaaff5ebff 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/AnchorUrlRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/AnchorUrlRewriteGeneratorTest.php @@ -8,6 +8,7 @@ namespace Magento\CatalogUrlRewrite\Test\Unit\Model\Product; use Magento\Catalog\Api\CategoryRepositoryInterface; +use Magento\Catalog\Model\Category; use Magento\Catalog\Model\Product; use Magento\CatalogUrlRewrite\Model\ObjectRegistry; use Magento\CatalogUrlRewrite\Model\Product\AnchorUrlRewriteGenerator; @@ -16,8 +17,8 @@ use Magento\Framework\TestFramework\Unit\Helper\ObjectManager; use Magento\UrlRewrite\Service\V1\Data\UrlRewrite; use Magento\UrlRewrite\Service\V1\Data\UrlRewriteFactory; +use PHPUnit\Framework\MockObject\MockObject as MockObject; use PHPUnit\Framework\TestCase; -use PHPUnit_Framework_MockObject_MockObject as MockObject; class AnchorUrlRewriteGeneratorTest extends TestCase { @@ -45,7 +46,7 @@ class AnchorUrlRewriteGeneratorTest extends TestCase /** * @inheritDoc */ - protected function setUp() + protected function setUp(): void { $this->urlRewriteFactory = $this->getMockBuilder(UrlRewriteFactory::class) ->setMethods(['create']) @@ -109,7 +110,7 @@ public function testGenerateCategories(): void ->will($this->returnValue($urlPathWithCategory)); $this->productUrlPathGenerator->expects($this->any())->method('getCanonicalUrlPath') ->will($this->returnValue($canonicalUrlPathWithCategory)); - $category = $this->createMock(\Magento\Catalog\Model\Category::class); + $category = $this->createMock(Category::class); $category->expects($this->any())->method('getId')->will($this->returnValue($categoryIds)); $category->expects($this->any())->method('getAnchorsAbove')->will($this->returnValue($categoryIds)); $category->expects($this->any())->method('getParentId')->will( diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CanonicalUrlRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CanonicalUrlRewriteGeneratorTest.php index 2a8af3fb43eaa..cbc88223fa14a 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CanonicalUrlRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CanonicalUrlRewriteGeneratorTest.php @@ -1,49 +1,57 @@ -urlRewriteFactory = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewriteFactory::class) + $this->urlRewriteFactory = $this->getMockBuilder(UrlRewriteFactory::class) ->setMethods(['create']) ->disableOriginalConstructor()->getMock(); - $this->urlRewrite = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + $this->urlRewrite = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); - $this->product = $this->getMockBuilder(\Magento\Catalog\Model\Product::class) + $this->product = $this->getMockBuilder(Product::class) ->disableOriginalConstructor()->getMock(); - $this->categoryRegistry = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Model\ObjectRegistry::class) + $this->categoryRegistry = $this->getMockBuilder(ObjectRegistry::class) ->disableOriginalConstructor()->getMock(); $this->productUrlPathGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator::class + ProductUrlPathGenerator::class )->disableOriginalConstructor()->getMock(); $this->canonicalUrlRewriteGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\Product\CanonicalUrlRewriteGenerator::class, + CanonicalUrlRewriteGenerator::class, [ 'productUrlPathGenerator' => $this->productUrlPathGenerator, 'urlRewriteFactory' => $this->urlRewriteFactory diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CategoriesUrlRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CategoriesUrlRewriteGeneratorTest.php index 0d3e896f09875..66428896ba9fb 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CategoriesUrlRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CategoriesUrlRewriteGeneratorTest.php @@ -1,4 +1,4 @@ -urlRewriteFactory = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewriteFactory::class) + $this->urlRewriteFactory = $this->getMockBuilder(UrlRewriteFactory::class) ->setMethods(['create']) ->disableOriginalConstructor()->getMock(); - $this->urlRewrite = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + $this->urlRewrite = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); - $this->product = $this->getMockBuilder(\Magento\Catalog\Model\Product::class) + $this->product = $this->getMockBuilder(Product::class) ->disableOriginalConstructor()->getMock(); - $this->categoryRegistry = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Model\ObjectRegistry::class) + $this->categoryRegistry = $this->getMockBuilder(ObjectRegistry::class) ->disableOriginalConstructor()->getMock(); $this->productUrlPathGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator::class + ProductUrlPathGenerator::class )->disableOriginalConstructor()->getMock(); $this->categoriesUrlRewriteGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\Product\CategoriesUrlRewriteGenerator::class, + CategoriesUrlRewriteGenerator::class, [ 'productUrlPathGenerator' => $this->productUrlPathGenerator, 'urlRewriteFactory' => $this->urlRewriteFactory @@ -75,7 +83,7 @@ public function testGenerateCategories() ->will($this->returnValue($urlPathWithCategory)); $this->productUrlPathGenerator->expects($this->any())->method('getCanonicalUrlPath') ->will($this->returnValue($canonicalUrlPathWithCategory)); - $category = $this->createMock(\Magento\Catalog\Model\Category::class); + $category = $this->createMock(Category::class); $category->expects($this->any())->method('getId')->will($this->returnValue($categoryId)); $this->categoryRegistry->expects($this->any())->method('getList') ->will($this->returnValue([$category])); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CurrentUrlRewritesRegeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CurrentUrlRewritesRegeneratorTest.php index c431743fc0b51..f29d517528c72 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CurrentUrlRewritesRegeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CurrentUrlRewritesRegeneratorTest.php @@ -1,75 +1,86 @@ -urlRewriteFactory = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewriteFactory::class) + $this->urlRewriteFactory = $this->getMockBuilder(UrlRewriteFactory::class) ->setMethods(['create']) ->disableOriginalConstructor()->getMock(); - $this->urlRewrite = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + $this->urlRewrite = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); - $this->product = $this->getMockBuilder(\Magento\Catalog\Model\Product::class) + $this->product = $this->getMockBuilder(Product::class) ->disableOriginalConstructor()->getMock(); - $this->category = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + $this->category = $this->getMockBuilder(Category::class) ->disableOriginalConstructor()->getMock(); - $this->objectRegistry = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Model\ObjectRegistry::class) + $this->objectRegistry = $this->getMockBuilder(ObjectRegistry::class) ->disableOriginalConstructor()->getMock(); - $this->urlRewriteFinder = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Model\Map\UrlRewriteFinder::class) + $this->urlRewriteFinder = $this->getMockBuilder(UrlRewriteFinder::class) ->disableOriginalConstructor()->getMock(); $this->urlRewriteFactory->expects($this->once())->method('create') ->willReturn($this->urlRewrite); $this->productUrlPathGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator::class + ProductUrlPathGenerator::class )->disableOriginalConstructor()->getMock(); $mergeDataProviderFactory = $this->createPartialMock( - \Magento\UrlRewrite\Model\MergeDataProviderFactory::class, + MergeDataProviderFactory::class, ['create'] ); - $this->mergeDataProvider = new \Magento\UrlRewrite\Model\MergeDataProvider(); + $this->mergeDataProvider = new MergeDataProvider(); $mergeDataProviderFactory->expects($this->once())->method('create')->willReturn($this->mergeDataProvider); $this->currentUrlRewritesRegenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\Product\CurrentUrlRewritesRegenerator::class, + CurrentUrlRewritesRegenerator::class, [ 'productUrlPathGenerator' => $this->productUrlPathGenerator, 'urlRewriteFactory' => $this->urlRewriteFactory, @@ -289,8 +300,8 @@ protected function getCurrentRewritesMocks($currentRewrites) { $rewrites = []; foreach ($currentRewrites as $urlRewrite) { - /** @var \PHPUnit_Framework_MockObject_MockObject */ - $url = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + /** @var MockObject */ + $url = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); foreach ($urlRewrite as $key => $value) { $url->expects($this->any()) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php index d4e0978dda66e..2af962c61d0ce 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php @@ -1,4 +1,4 @@ -serializer = $this->createMock(\Magento\Framework\Serialize\Serializer\Json::class); + $this->serializer = $this->createMock(Json::class); $this->serializer->expects($this->any()) ->method('serialize') ->willReturnCallback( @@ -72,37 +86,37 @@ function ($value) { ); $this->currentUrlRewritesRegenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\CurrentUrlRewritesRegenerator::class + CurrentUrlRewritesRegenerator::class )->disableOriginalConstructor()->getMock(); $this->canonicalUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\CanonicalUrlRewriteGenerator::class + CanonicalUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->categoriesUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\CategoriesUrlRewriteGenerator::class + CategoriesUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->anchorUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\AnchorUrlRewriteGenerator::class + AnchorUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->objectRegistryFactory = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\ObjectRegistryFactory::class + ObjectRegistryFactory::class )->disableOriginalConstructor()->setMethods(['create'])->getMock(); - $this->storeViewService = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Service\V1\StoreViewService::class) + $this->storeViewService = $this->getMockBuilder(StoreViewService::class) ->disableOriginalConstructor()->getMock(); $this->storeManager = $this->createMock(StoreManagerInterface::class); $storeRootCategoryId = 2; - $store = $this->getMockBuilder(\Magento\Store\Model\Store::class)->disableOriginalConstructor()->getMock(); + $store = $this->getMockBuilder(Store::class)->disableOriginalConstructor()->getMock(); $store->expects($this->any())->method('getRootCategoryId')->will($this->returnValue($storeRootCategoryId)); $this->storeManager->expects($this->any())->method('getStore')->will($this->returnValue($store)); $mergeDataProviderFactory = $this->createPartialMock( - \Magento\UrlRewrite\Model\MergeDataProviderFactory::class, + MergeDataProviderFactory::class, ['create'] ); - $this->mergeDataProvider = new \Magento\UrlRewrite\Model\MergeDataProvider(); + $this->mergeDataProvider = new MergeDataProvider(); $mergeDataProviderFactory->expects($this->once())->method('create')->willReturn($this->mergeDataProvider); - $this->configMock = $this->getMockBuilder(\Magento\Framework\App\Config\ScopeConfigInterface::class)->getMock(); + $this->configMock = $this->getMockBuilder(ScopeConfigInterface::class)->getMock(); $this->productScopeGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\ProductScopeRewriteGenerator::class, + ProductScopeRewriteGenerator::class, [ 'canonicalUrlRewriteGenerator' => $this->canonicalUrlRewriteGenerator, 'categoriesUrlRewriteGenerator' => $this->categoriesUrlRewriteGenerator, @@ -123,30 +137,30 @@ public function testGenerationForGlobalScope() $this->configMock->expects($this->any())->method('getValue') ->with('catalog/seo/generate_category_product_rewrites') ->willReturn('1'); - $product = $this->createMock(\Magento\Catalog\Model\Product::class); + $product = $this->createMock(Product::class); $product->expects($this->any())->method('getStoreId')->will($this->returnValue(null)); $product->expects($this->any())->method('getStoreIds')->will($this->returnValue([1])); $this->storeViewService->expects($this->once())->method('doesEntityHaveOverriddenUrlKeyForStore') ->will($this->returnValue(false)); $this->initObjectRegistryFactory([]); - $canonical = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $canonical = new UrlRewrite([], $this->serializer); $canonical->setRequestPath('category-1') ->setStoreId(1); $this->canonicalUrlRewriteGenerator->expects($this->any())->method('generate') ->will($this->returnValue([$canonical])); - $categories = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $categories = new UrlRewrite([], $this->serializer); $categories->setRequestPath('category-2') ->setStoreId(2); $this->categoriesUrlRewriteGenerator->expects($this->any())->method('generate') ->will($this->returnValue([$categories])); - $current = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $current = new UrlRewrite([], $this->serializer); $current->setRequestPath('category-3') ->setStoreId(3); $this->currentUrlRewritesRegenerator->expects($this->any())->method('generate') ->will($this->returnValue([$current])); $this->currentUrlRewritesRegenerator->expects($this->any())->method('generateAnchor') ->will($this->returnValue([$current])); - $anchorCategories = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $anchorCategories = new UrlRewrite([], $this->serializer); $anchorCategories->setRequestPath('category-4') ->setStoreId(4); $this->anchorUrlRewriteGenerator->expects($this->any())->method('generate') @@ -167,14 +181,14 @@ public function testGenerationForSpecificStore() { $storeRootCategoryId = 2; $category_id = 4; - $product = $this->createMock(\Magento\Catalog\Model\Product::class); + $product = $this->createMock(Product::class); $product->expects($this->any())->method('getStoreId')->will($this->returnValue(1)); $product->expects($this->never())->method('getStoreIds'); $this->categoryMock->expects($this->any())->method('getParentIds') ->will($this->returnValue(['root-id', $storeRootCategoryId])); $this->categoryMock->expects($this->any())->method('getId')->will($this->returnValue($category_id)); $this->initObjectRegistryFactory([$this->categoryMock]); - $canonical = new \Magento\UrlRewrite\Service\V1\Data\UrlRewrite([], $this->serializer); + $canonical = new UrlRewrite([], $this->serializer); $canonical->setRequestPath('category-1') ->setStoreId(1); $this->canonicalUrlRewriteGenerator->expects($this->any())->method('generate') @@ -199,7 +213,7 @@ public function testGenerationForSpecificStore() */ public function testSkipGenerationForGlobalScope() { - $product = $this->createMock(\Magento\Catalog\Model\Product::class); + $product = $this->createMock(Product::class); $product->expects($this->any())->method('getStoreIds')->will($this->returnValue([1, 2])); $this->storeViewService->expects($this->exactly(2))->method('doesEntityHaveOverriddenUrlKeyForStore') ->will($this->returnValue(true)); @@ -212,7 +226,7 @@ public function testSkipGenerationForGlobalScope() */ protected function initObjectRegistryFactory($entities) { - $objectRegistry = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Model\ObjectRegistry::class) + $objectRegistry = $this->getMockBuilder(ObjectRegistry::class) ->disableOriginalConstructor()->getMock(); $this->objectRegistryFactory->expects($this->any())->method('create') ->with(['entities' => $entities]) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlPathGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlPathGeneratorTest.php index 95ef16c5ace4c..d06f883f5b023 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlPathGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlPathGeneratorTest.php @@ -15,9 +15,10 @@ use Magento\Framework\App\Config\ScopeConfigInterface; use Magento\Framework\TestFramework\Unit\Helper\ObjectManager; use Magento\Store\Model\ScopeInterface; +use Magento\Store\Model\Store; use Magento\Store\Model\StoreManagerInterface; +use PHPUnit\Framework\MockObject\MockObject as MockObject; use PHPUnit\Framework\TestCase; -use PHPUnit_Framework_MockObject_MockObject as MockObject; /** * Verify ProductUrlPathGenerator class @@ -208,7 +209,7 @@ public function testGetUrlPathWithSuffix(): void $storeId = 1; $this->product->expects($this->once())->method('getData')->with('url_path') ->will($this->returnValue('product-path')); - $store = $this->createMock(\Magento\Store\Model\Store::class); + $store = $this->createMock(Store::class); $store->expects($this->once())->method('getId')->will($this->returnValue($storeId)); $this->storeManager->expects($this->once())->method('getStore')->will($this->returnValue($store)); $this->scopeConfig->expects($this->once())->method('getValue') diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlRewriteGeneratorTest.php index 2580322ceddab..c95f3b3043d62 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlRewriteGeneratorTest.php @@ -1,4 +1,4 @@ -product = $this->createMock(\Magento\Catalog\Model\Product::class); + $this->product = $this->createMock(Product::class); $this->categoriesCollection = $this->getMockBuilder( - \Magento\Catalog\Model\ResourceModel\Category\Collection::class + Collection::class ) ->disableOriginalConstructor()->getMock(); $this->product->expects($this->any())->method('getCategoryCollection') ->will($this->returnValue($this->categoriesCollection)); - $this->storeManager = $this->getMockBuilder(\Magento\Store\Model\StoreManagerInterface::class) + $this->storeManager = $this->getMockBuilder(StoreManagerInterface::class) ->disableOriginalConstructor()->getMock(); $this->currentUrlRewritesRegenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\CurrentUrlRewritesRegenerator::class + CurrentUrlRewritesRegenerator::class )->disableOriginalConstructor()->getMock(); $this->canonicalUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\CanonicalUrlRewriteGenerator::class + CanonicalUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->categoriesUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\CategoriesUrlRewriteGenerator::class + CategoriesUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->anchorUrlRewriteGenerator = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\Product\AnchorUrlRewriteGenerator::class + AnchorUrlRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->objectRegistryFactory = $this->getMockBuilder( - \Magento\CatalogUrlRewrite\Model\ObjectRegistryFactory::class + ObjectRegistryFactory::class )->disableOriginalConstructor()->setMethods(['create'])->getMock(); - $this->storeViewService = $this->getMockBuilder(\Magento\CatalogUrlRewrite\Service\V1\StoreViewService::class) + $this->storeViewService = $this->getMockBuilder(StoreViewService::class) ->disableOriginalConstructor()->getMock(); $this->productScopeRewriteGenerator = $this->getMockBuilder( ProductScopeRewriteGenerator::class )->disableOriginalConstructor()->getMock(); $this->productUrlRewriteGenerator = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator::class, + ProductUrlRewriteGenerator::class, [ 'canonicalUrlRewriteGenerator' => $this->canonicalUrlRewriteGenerator, 'categoriesUrlRewriteGenerator' => $this->categoriesUrlRewriteGenerator, @@ -115,7 +125,7 @@ public function testGenerate() $productMock->expects($this->once()) ->method('getStoreId') ->willReturn($storeId); - $productCategoriesMock = $this->getMockBuilder(\Magento\Catalog\Model\ResourceModel\Category\Collection::class) + $productCategoriesMock = $this->getMockBuilder(Collection::class) ->disableOriginalConstructor() ->getMock(); $productCategoriesMock->expects($this->exactly(2)) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/UrlRewriteBunchReplacerTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/UrlRewriteBunchReplacerTest.php index 99b28b2c1b691..4dd562ca0f00b 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/UrlRewriteBunchReplacerTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/UrlRewriteBunchReplacerTest.php @@ -1,4 +1,4 @@ -urlPersistMock = $this->createMock(UrlPersistInterface::class); $this->urlRewriteBunchReplacer = new UrlRewriteBunchReplacer( diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/AfterImportDataObserverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/AfterImportDataObserverTest.php index 94fe6ae8c54dc..1c094690cf0c8 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/AfterImportDataObserverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/AfterImportDataObserverTest.php @@ -1,4 +1,4 @@ -importProduct = $this->createPartialMock( \Magento\CatalogImportExport\Model\Import\Product::class, @@ -164,14 +182,14 @@ protected function setUp() ] ); $this->catalogProductFactory = $this->createPartialMock( - \Magento\Catalog\Model\ProductFactory::class, + ProductFactory::class, [ 'create', ] ); $this->storeManager = $this ->getMockBuilder( - \Magento\Store\Model\StoreManagerInterface::class + StoreManagerInterface::class ) ->disableOriginalConstructor() ->setMethods( @@ -180,36 +198,36 @@ protected function setUp() ] ) ->getMockForAbstractClass(); - $this->event = $this->createPartialMock(\Magento\Framework\Event::class, ['getAdapter', 'getBunch']); + $this->event = $this->createPartialMock(Event::class, ['getAdapter', 'getBunch']); $this->event->expects($this->any())->method('getAdapter')->willReturn($this->importProduct); $this->event->expects($this->any())->method('getBunch')->willReturn($this->products); - $this->observer = $this->createPartialMock(\Magento\Framework\Event\Observer::class, ['getEvent']); + $this->observer = $this->createPartialMock(Observer::class, ['getEvent']); $this->observer->expects($this->any())->method('getEvent')->willReturn($this->event); - $this->urlPersist = $this->getMockBuilder(\Magento\UrlRewrite\Model\UrlPersistInterface::class) + $this->urlPersist = $this->getMockBuilder(UrlPersistInterface::class) ->disableOriginalConstructor() ->getMock(); $this->productUrlRewriteGenerator = - $this->getMockBuilder(\Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator::class) + $this->getMockBuilder(ProductUrlRewriteGenerator::class) ->disableOriginalConstructor() ->setMethods(['generate']) ->getMock(); - $this->productRepository = $this->getMockBuilder(\Magento\Catalog\Api\ProductRepositoryInterface::class) + $this->productRepository = $this->getMockBuilder(ProductRepositoryInterface::class) ->disableOriginalConstructor() ->getMock(); - $this->objectRegistryFactory = $this->createMock(\Magento\CatalogUrlRewrite\Model\ObjectRegistryFactory::class); + $this->objectRegistryFactory = $this->createMock(ObjectRegistryFactory::class); $this->productUrlPathGenerator = $this->createMock( - \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator::class + ProductUrlPathGenerator::class ); - $this->storeViewService = $this->createMock(\Magento\CatalogUrlRewrite\Service\V1\StoreViewService::class); + $this->storeViewService = $this->createMock(StoreViewService::class); $this->urlRewriteFactory = $this->createPartialMock( - \Magento\UrlRewrite\Service\V1\Data\UrlRewriteFactory::class, + UrlRewriteFactory::class, [ 'create', ] ); $this->urlFinder = $this - ->getMockBuilder(\Magento\UrlRewrite\Model\UrlFinderInterface::class) + ->getMockBuilder(UrlFinderInterface::class) ->setMethods( [ 'findAllByData', @@ -219,7 +237,7 @@ protected function setUp() ->getMockForAbstractClass(); $this->urlRewrite = $this - ->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + ->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor() ->getMock(); @@ -229,15 +247,15 @@ protected function setUp() ->getMock(); $this->objectRegistry = $this - ->getMockBuilder(\Magento\CatalogUrlRewrite\Model\ObjectRegistry::class) + ->getMockBuilder(ObjectRegistry::class) ->disableOriginalConstructor() ->getMock(); $mergeDataProviderFactory = $this->createPartialMock( - \Magento\UrlRewrite\Model\MergeDataProviderFactory::class, + MergeDataProviderFactory::class, ['create'] ); - $this->mergeDataProvider = new \Magento\UrlRewrite\Model\MergeDataProvider(); + $this->mergeDataProvider = new MergeDataProvider(); $mergeDataProviderFactory->expects($this->once())->method('create')->willReturn($this->mergeDataProvider); $this->categoryCollectionFactory = $this->getMockBuilder(CategoryCollectionFactory::class) @@ -247,7 +265,7 @@ protected function setUp() $this->objectManager = new ObjectManager($this); $this->import = $this->objectManager->getObject( - \Magento\CatalogUrlRewrite\Observer\AfterImportDataObserver::class, + AfterImportDataObserver::class, [ 'catalogProductFactory' => $this->catalogProductFactory, 'objectRegistryFactory' => $this->objectRegistryFactory, @@ -280,7 +298,7 @@ public function testAfterImportData() $websiteId = 'websiteId value'; $productsCount = count($this->products); $websiteMock = $this->createPartialMock( - \Magento\Store\Model\Website::class, + Website::class, [ 'getStoreIds', ] @@ -555,7 +573,7 @@ public function testCategoriesUrlRewriteGenerate() ->expects($this->any()) ->method('getCanonicalUrlPath') ->will($this->returnValue($canonicalUrlPathWithCategory)); - $category = $this->createMock(\Magento\Catalog\Model\Category::class); + $category = $this->createMock(Category::class); $category ->expects($this->any()) ->method('getId') @@ -635,7 +653,7 @@ public function testCategoriesUrlRewriteGenerate() } /** - * @param \Magento\CatalogUrlRewrite\Observer\AfterImportDataObserver $object + * @param AfterImportDataObserver $object * @param string $property * @param mixed $value * @return void @@ -649,7 +667,7 @@ protected function setPropertyValue($object, $property, $value) } /** - * @param \Magento\CatalogUrlRewrite\Observer\AfterImportDataObserver $object + * @param AfterImportDataObserver $object * @param string $methodName * @param array $parameters * @return mixed @@ -711,9 +729,9 @@ protected function currentUrlRewritesRegeneratorGetCurrentRewritesMocks($current $rewrites = []; foreach ($currentRewrites as $urlRewrite) { /** - * @var \PHPUnit_Framework_MockObject_MockObject + * @var MockObject */ - $url = $this->getMockBuilder(\Magento\UrlRewrite\Service\V1\Data\UrlRewrite::class) + $url = $this->getMockBuilder(UrlRewrite::class) ->disableOriginalConstructor()->getMock(); foreach ($urlRewrite as $key => $value) { $url->expects($this->any()) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteMovingObserverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteMovingObserverTest.php index 57162b44f9826..cbbafed0412a5 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteMovingObserverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteMovingObserverTest.php @@ -20,13 +20,13 @@ use Magento\Framework\Event; use Magento\Framework\Event\Observer; use Magento\UrlRewrite\Model\UrlPersistInterface; +use PHPUnit\Framework\MockObject\MockObject; +use PHPUnit\Framework\TestCase; /** - * Class CategoryProcessUrlRewriteMovingObserverTest - * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -class CategoryProcessUrlRewriteMovingObserverTest extends \PHPUnit\Framework\TestCase +class CategoryProcessUrlRewriteMovingObserverTest extends TestCase { /** * @var CategoryProcessUrlRewriteMovingObserver @@ -34,40 +34,40 @@ class CategoryProcessUrlRewriteMovingObserverTest extends \PHPUnit\Framework\Tes private $observer; /** - * @var CategoryUrlRewriteGenerator|\PHPUnit_Framework_MockObject_MockObject + * @var CategoryUrlRewriteGenerator|MockObject */ private $categoryUrlRewriteGeneratorMock; /** - * @var UrlPersistInterface|\PHPUnit_Framework_MockObject_MockObject + * @var UrlPersistInterface|MockObject */ private $urlPersistMock; /** - * @var ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject + * @var ScopeConfigInterface|MockObject */ private $scopeConfigMock; /** - * @var UrlRewriteHandler|\PHPUnit_Framework_MockObject_MockObject + * @var UrlRewriteHandler|MockObject */ private $urlRewriteHandlerMock; /** - * @var DatabaseMapPool|\PHPUnit_Framework_MockObject_MockObject + * @var DatabaseMapPool|MockObject */ private $databaseMapPoolMock; /** * Set Up */ - protected function setUp() + protected function setUp(): void { $this->categoryUrlRewriteGeneratorMock = $this->createMock(CategoryUrlRewriteGenerator::class); $this->urlPersistMock = $this->createMock(UrlPersistInterface::class); $this->scopeConfigMock = $this->createMock(ScopeConfigInterface::class); $this->urlRewriteHandlerMock = $this->createMock(UrlRewriteHandler::class); - /** @var UrlRewriteBunchReplacer|\PHPUnit_Framework_MockObject_MockObject $urlRewriteMock */ + /** @var UrlRewriteBunchReplacer|MockObject $urlRewriteMock */ $urlRewriteMock = $this->createMock(UrlRewriteBunchReplacer::class); $this->databaseMapPoolMock = $this->createMock(DatabaseMapPool::class); @@ -92,7 +92,7 @@ protected function setUp() */ public function testCategoryProcessUrlRewriteAfterMovingWithChangedParentId() { - /** @var Observer|\PHPUnit_Framework_MockObject_MockObject $observerMock */ + /** @var Observer|MockObject $observerMock */ $observerMock = $this->createMock(Observer::class); $eventMock = $this->getMockBuilder(Event::class) ->disableOriginalConstructor() @@ -131,7 +131,7 @@ public function testCategoryProcessUrlRewriteAfterMovingWithChangedParentId() */ public function testCategoryProcessUrlRewriteAfterMovingWithinNotChangedParent() { - /** @var Observer|\PHPUnit_Framework_MockObject_MockObject $observerMock */ + /** @var Observer|MockObject $observerMock */ $observerMock = $this->createMock(Observer::class); $eventMock = $this->getMockBuilder(Event::class) ->disableOriginalConstructor() diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteSavingObserverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteSavingObserverTest.php index cdea134758101..a5108c80142f9 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteSavingObserverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryProcessUrlRewriteSavingObserverTest.php @@ -7,28 +7,31 @@ namespace Magento\CatalogUrlRewrite\Test\Unit\Observer; +use Magento\Catalog\Model\Category; use Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator; -use Magento\CatalogUrlRewrite\Observer\CategoryProcessUrlRewriteSavingObserver; +use Magento\CatalogUrlRewrite\Model\Map\DatabaseMapPool; use Magento\CatalogUrlRewrite\Model\UrlRewriteBunchReplacer; +use Magento\CatalogUrlRewrite\Observer\CategoryProcessUrlRewriteSavingObserver; use Magento\CatalogUrlRewrite\Observer\UrlRewriteHandler; -use Magento\CatalogUrlRewrite\Model\Map\DatabaseMapPool; use Magento\Framework\App\Config\ScopeConfigInterface as ScopeConfigInterfaceAlias; -use Magento\Store\Model\ResourceModel\Group\CollectionFactory; +use Magento\Framework\Event\Observer; use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper; -use Magento\Catalog\Model\Category; +use Magento\Store\Model\ResourceModel\Group\CollectionFactory; +use PHPUnit\Framework\MockObject\MockObject; +use PHPUnit\Framework\TestCase; /** * Unit tests for \Magento\CatalogUrlRewrite\Observer\CategoryProcessUrlRewriteSavingObserver class. */ -class CategoryProcessUrlRewriteSavingObserverTest extends \PHPUnit\Framework\TestCase +class CategoryProcessUrlRewriteSavingObserverTest extends TestCase { /** - * @var \Magento\Framework\Event\Observer|\PHPUnit_Framework_MockObject_MockObject + * @var Observer|MockObject */ private $observer; /** - * @var \Magento\Catalog\Model\Category|\PHPUnit_Framework_MockObject_MockObject + * @var Category|MockObject */ private $category; @@ -38,42 +41,42 @@ class CategoryProcessUrlRewriteSavingObserverTest extends \PHPUnit\Framework\Tes private $categoryProcessUrlRewriteSavingObserver; /** - * @var CategoryUrlRewriteGenerator|\PHPUnit_Framework_MockObject_MockObject + * @var CategoryUrlRewriteGenerator|MockObject */ private $categoryUrlRewriteGeneratorMock; /** - * @var UrlRewriteBunchReplacer|\PHPUnit_Framework_MockObject_MockObject + * @var UrlRewriteBunchReplacer|MockObject */ private $urlRewriteBunchReplacerMock; /** - * @var UrlRewriteHandler|\PHPUnit_Framework_MockObject_MockObject + * @var UrlRewriteHandler|MockObject */ private $urlRewriteHandlerMock; /** - * @var DatabaseMapPool|\PHPUnit_Framework_MockObject_MockObject + * @var DatabaseMapPool|MockObject */ private $databaseMapPoolMock; /** - * @var CollectionFactory|\PHPUnit_Framework_MockObject_MockObject + * @var CollectionFactory|MockObject */ private $storeGroupFactory; /** - * @var \PHPUnit\Framework\MockObject\MockObject + * @var MockObject */ private $scopeConfigMock; /** * {@inheritDoc} */ - protected function setUp() + protected function setUp(): void { $this->observer = $this->createPartialMock( - \Magento\Framework\Event\Observer::class, + Observer::class, ['getEvent', 'getData'] ); $this->category = $this->createPartialMock( diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryUrlPathAutogeneratorObserverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryUrlPathAutogeneratorObserverTest.php index 9e2090e36f08e..6a80ae154561d 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryUrlPathAutogeneratorObserverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/CategoryUrlPathAutogeneratorObserverTest.php @@ -1,4 +1,4 @@ -observer = $this->createPartialMock( - \Magento\Framework\Event\Observer::class, + Observer::class, ['getEvent', 'getCategory'] ); - $this->categoryResource = $this->createMock(\Magento\Catalog\Model\ResourceModel\Category::class); + $this->categoryResource = $this->createMock(Category::class); $this->category = $this->createPartialMock( \Magento\Catalog\Model\Category::class, [ @@ -68,16 +78,16 @@ protected function setUp() $this->observer->expects($this->any())->method('getEvent')->willReturnSelf(); $this->observer->expects($this->any())->method('getCategory')->willReturn($this->category); $this->categoryUrlPathGenerator = $this->createMock( - \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator::class + CategoryUrlPathGenerator::class ); $this->childrenCategoriesProvider = $this->createMock( - \Magento\CatalogUrlRewrite\Model\Category\ChildrenCategoriesProvider::class + ChildrenCategoriesProvider::class ); - $this->storeViewService = $this->createMock(\Magento\CatalogUrlRewrite\Service\V1\StoreViewService::class); + $this->storeViewService = $this->createMock(StoreViewService::class); $this->categoryUrlPathAutogeneratorObserver = (new ObjectManagerHelper($this))->getObject( - \Magento\CatalogUrlRewrite\Observer\CategoryUrlPathAutogeneratorObserver::class, + CategoryUrlPathAutogeneratorObserver::class, [ 'categoryUrlPathGenerator' => $this->categoryUrlPathGenerator, 'childrenCategoriesProvider' => $this->childrenCategoriesProvider, @@ -88,7 +98,7 @@ protected function setUp() /** * @param $isObjectNew - * @throws \Magento\Framework\Exception\LocalizedException + * @throws LocalizedException * @dataProvider shouldFormatUrlKeyAndGenerateUrlPathIfUrlKeyIsNotUsingDefaultValueDataProvider */ public function testShouldFormatUrlKeyAndGenerateUrlPathIfUrlKeyIsNotUsingDefaultValue($isObjectNew) @@ -121,7 +131,7 @@ public function shouldFormatUrlKeyAndGenerateUrlPathIfUrlKeyIsNotUsingDefaultVal /** * @param $isObjectNew - * @throws \Magento\Framework\Exception\LocalizedException + * @throws LocalizedException * @dataProvider shouldResetUrlPathAndUrlKeyIfUrlKeyIsUsingDefaultValueDataProvider */ public function testShouldResetUrlPathAndUrlKeyIfUrlKeyIsUsingDefaultValue($isObjectNew) @@ -151,7 +161,7 @@ public function shouldResetUrlPathAndUrlKeyIfUrlKeyIsUsingDefaultValueDataProvid /** * @param $useDefaultUrlKey * @param $isObjectNew - * @throws \Magento\Framework\Exception\LocalizedException + * @throws LocalizedException * @dataProvider shouldThrowExceptionIfUrlKeyIsEmptyDataProvider */ public function testShouldThrowExceptionIfUrlKeyIsEmpty($useDefaultUrlKey, $isObjectNew) @@ -161,7 +171,7 @@ public function testShouldThrowExceptionIfUrlKeyIsEmpty($useDefaultUrlKey, $isOb $this->category->setData($categoryData); $this->category ->method('getStoreId') - ->willReturn(\Magento\Store\Model\Store::DEFAULT_STORE_ID); + ->willReturn(Store::DEFAULT_STORE_ID); $this->category->isObjectNew($isObjectNew); $this->assertEquals($isObjectNew, $this->category->isObjectNew()); $this->assertEquals($categoryData['url_key'], $this->category->getUrlKey()); @@ -226,7 +236,7 @@ public function testChildrenUrlPathAttributeUpdatingForSpecificStore() // only for specific store $this->category->expects($this->atLeastOnce())->method('getStoreId')->willReturn(1); - $childCategoryResource = $this->getMockBuilder(\Magento\Catalog\Model\ResourceModel\Category::class) + $childCategoryResource = $this->getMockBuilder(Category::class) ->disableOriginalConstructor()->getMock(); $childCategory = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) ->setMethods( diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ClearProductUrlsObserverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ClearProductUrlsObserverTest.php index 755a20a24025b..d46dcc2935de4 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ClearProductUrlsObserverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ClearProductUrlsObserverTest.php @@ -1,4 +1,4 @@ -importProduct = $this->getMockBuilder(Product::class) ->disableOriginalConstructor() diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteSavingObserverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteSavingObserverTest.php index 39317b42af989..7a5c46e6e9540 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteSavingObserverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteSavingObserverTest.php @@ -1,4 +1,4 @@ -urlPersist = $this->createMock(\Magento\UrlRewrite\Model\UrlPersistInterface::class); - $this->product = $this->createPartialMock(\Magento\Catalog\Model\Product::class, [ + $this->urlPersist = $this->createMock(UrlPersistInterface::class); + $this->product = $this->createPartialMock(Product::class, [ 'getId', 'dataHasChangedFor', 'isVisibleInSiteVisibility', @@ -68,12 +72,12 @@ protected function setUp() 'getStoreId' ]); $this->product->expects($this->any())->method('getId')->will($this->returnValue(3)); - $this->event = $this->createPartialMock(\Magento\Framework\Event::class, ['getProduct']); + $this->event = $this->createPartialMock(Event::class, ['getProduct']); $this->event->expects($this->any())->method('getProduct')->willReturn($this->product); - $this->observer = $this->createPartialMock(\Magento\Framework\Event\Observer::class, ['getEvent']); + $this->observer = $this->createPartialMock(Observer::class, ['getEvent']); $this->observer->expects($this->any())->method('getEvent')->willReturn($this->event); $this->productUrlRewriteGenerator = $this->createPartialMock( - \Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator::class, + ProductUrlRewriteGenerator::class, ['generate'] ); $this->productUrlRewriteGenerator->expects($this->any()) @@ -81,7 +85,7 @@ protected function setUp() ->will($this->returnValue([3 => 'rewrite'])); $this->objectManager = new ObjectManager($this); $this->model = $this->objectManager->getObject( - \Magento\CatalogUrlRewrite\Observer\ProductProcessUrlRewriteSavingObserver::class, + ProductProcessUrlRewriteSavingObserver::class, [ 'productUrlRewriteGenerator' => $this->productUrlRewriteGenerator, 'urlPersist' => $this->urlPersist diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductUrlKeyAutogeneratorObserverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductUrlKeyAutogeneratorObserverTest.php index b9628caff8400..51b6a3dd96682 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductUrlKeyAutogeneratorObserverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductUrlKeyAutogeneratorObserverTest.php @@ -7,20 +7,26 @@ namespace Magento\CatalogUrlRewrite\Test\Unit\Observer; +use Magento\Catalog\Model\Product; +use Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator; +use Magento\CatalogUrlRewrite\Observer\ProductUrlKeyAutogeneratorObserver; +use Magento\Framework\Event; +use Magento\Framework\Event\Observer; use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper; -use \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator; +use PHPUnit\Framework\MockObject\MockObject; +use PHPUnit\Framework\TestCase; /** * Unit tests for \Magento\CatalogUrlRewrite\Observer\ProductUrlKeyAutogeneratorObserver class */ -class ProductUrlKeyAutogeneratorObserverTest extends \PHPUnit\Framework\TestCase +class ProductUrlKeyAutogeneratorObserverTest extends TestCase { /** - * @var \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator|\PHPUnit_Framework_MockObject_MockObject + * @var ProductUrlPathGenerator|MockObject */ private $productUrlPathGenerator; - /** @var \Magento\CatalogUrlRewrite\Observer\ProductUrlKeyAutogeneratorObserver */ + /** @var ProductUrlKeyAutogeneratorObserver */ private $productUrlKeyAutogeneratorObserver; /** @@ -34,7 +40,7 @@ protected function setUp(): void ->getMock(); $this->productUrlKeyAutogeneratorObserver = (new ObjectManagerHelper($this))->getObject( - \Magento\CatalogUrlRewrite\Observer\ProductUrlKeyAutogeneratorObserver::class, + ProductUrlKeyAutogeneratorObserver::class, [ 'productUrlPathGenerator' => $this->productUrlPathGenerator ] @@ -48,18 +54,18 @@ public function testExecuteWithUrlKey(): void { $urlKey = 'product_url_key'; - $product = $this->getMockBuilder(\Magento\Catalog\Model\Product::class) + $product = $this->getMockBuilder(Product::class) ->disableOriginalConstructor() ->setMethods(['setUrlKey']) ->getMock(); $product->expects($this->atLeastOnce())->method('setUrlKey')->with($urlKey); - $event = $this->getMockBuilder(\Magento\Framework\Event::class) + $event = $this->getMockBuilder(Event::class) ->disableOriginalConstructor() ->setMethods(['getProduct']) ->getMock(); $event->expects($this->atLeastOnce())->method('getProduct')->willReturn($product); - /** @var \Magento\Framework\Event\Observer|\PHPUnit_Framework_MockObject_MockObject $observer */ - $observer = $this->getMockBuilder(\Magento\Framework\Event\Observer::class) + /** @var Observer|MockObject $observer */ + $observer = $this->getMockBuilder(Observer::class) ->disableOriginalConstructor() ->setMethods(['getEvent']) ->getMock(); @@ -75,18 +81,18 @@ public function testExecuteWithUrlKey(): void */ public function testExecuteWithEmptyUrlKey(): void { - $product = $this->getMockBuilder(\Magento\Catalog\Model\Product::class) + $product = $this->getMockBuilder(Product::class) ->disableOriginalConstructor() ->setMethods(['setUrlKey']) ->getMock(); $product->expects($this->never())->method('setUrlKey'); - $event = $this->getMockBuilder(\Magento\Framework\Event::class) + $event = $this->getMockBuilder(Event::class) ->disableOriginalConstructor() ->setMethods(['getProduct']) ->getMock(); $event->expects($this->atLeastOnce())->method('getProduct')->willReturn($product); - /** @var \Magento\Framework\Event\Observer|\PHPUnit_Framework_MockObject_MockObject $observer */ - $observer = $this->getMockBuilder(\Magento\Framework\Event\Observer::class) + /** @var Observer|MockObject $observer */ + $observer = $this->getMockBuilder(Observer::class) ->disableOriginalConstructor() ->setMethods(['getEvent']) ->getMock(); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/UrlRewriteHandlerTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/UrlRewriteHandlerTest.php index 06a89a9dd5ec0..f7f31fe26fed6 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/UrlRewriteHandlerTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/UrlRewriteHandlerTest.php @@ -1,27 +1,29 @@ -childrenCategoriesProviderMock = $this->getMockBuilder(ChildrenCategoriesProvider::class) ->getMock(); @@ -125,8 +127,8 @@ protected function setUp() */ public function testGenerateProductUrlRewrites() { - /* @var \Magento\Catalog\Model\Category|\PHPUnit_Framework_MockObject_MockObject $category */ - $category = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + /* @var \Magento\Catalog\Model\Category|MockObject $category */ + $category = $this->getMockBuilder(Category::class) ->setMethods(['getEntityId', 'getStoreId', 'getData', 'getChangedProductIds']) ->disableOriginalConstructor() ->getMock(); @@ -147,8 +149,8 @@ public function testGenerateProductUrlRewrites() null ); - /* @var \Magento\Catalog\Model\Category|\PHPUnit_Framework_MockObject_MockObject $childCategory1 */ - $childCategory1 = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + /* @var \Magento\Catalog\Model\Category|MockObject $childCategory1 */ + $childCategory1 = $this->getMockBuilder(Category::class) ->setMethods(['getEntityId']) ->disableOriginalConstructor() ->getMock(); @@ -156,8 +158,8 @@ public function testGenerateProductUrlRewrites() ->method('getEntityId') ->willReturn(100); - /* @var \Magento\Catalog\Model\Category|\PHPUnit_Framework_MockObject_MockObject $childCategory1 */ - $childCategory2 = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + /* @var \Magento\Catalog\Model\Category|MockObject $childCategory1 */ + $childCategory2 = $this->getMockBuilder(Category::class) ->setMethods(['getEntityId']) ->disableOriginalConstructor() ->getMock(); @@ -170,8 +172,8 @@ public function testGenerateProductUrlRewrites() ->with($category, true) ->willReturn([$childCategory1, $childCategory2]); - /** @var Collection|\PHPUnit_Framework_MockObject_MockObject $productCollection */ - $productCollection = $this->getMockBuilder(\Magento\Catalog\Model\ResourceModel\Product\Collection::class) + /** @var Collection|MockObject $productCollection */ + $productCollection = $this->getMockBuilder(Collection::class) ->disableOriginalConstructor() ->getMock(); $productCollection->expects($this->any()) @@ -195,7 +197,7 @@ public function testGenerateProductUrlRewrites() public function testDeleteCategoryRewritesForChildren() { - $category = $this->getMockBuilder(\Magento\Catalog\Model\Category::class) + $category = $this->getMockBuilder(Category::class) ->disableOriginalConstructor() ->getMock(); $category->expects($this->once()) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Plugin/Webapi/Controller/Rest/InputParamsResolverTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Plugin/Webapi/Controller/Rest/InputParamsResolverTest.php index 8e705b2c09f6b..5edc463ac49f3 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Plugin/Webapi/Controller/Rest/InputParamsResolverTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Plugin/Webapi/Controller/Rest/InputParamsResolverTest.php @@ -8,18 +8,20 @@ namespace Magento\CatalogUrlRewrite\Test\Unit\Plugin\Webapi\Controller\Rest; -use Magento\Framework\TestFramework\Unit\Helper\ObjectManager; -use Magento\Webapi\Controller\Rest\InputParamsResolver; +use Magento\Catalog\Api\ProductRepositoryInterface; +use Magento\Catalog\Model\Product; use Magento\CatalogUrlRewrite\Plugin\Webapi\Controller\Rest\InputParamsResolver as InputParamsResolverPlugin; +use Magento\Framework\TestFramework\Unit\Helper\ObjectManager; use Magento\Framework\Webapi\Rest\Request as RestRequest; -use Magento\Catalog\Model\Product; +use Magento\Webapi\Controller\Rest\InputParamsResolver; use Magento\Webapi\Controller\Rest\Router\Route; -use Magento\Catalog\Api\ProductRepositoryInterface; +use PHPUnit\Framework\MockObject\MockObject; +use PHPUnit\Framework\TestCase; /** * Unit test for InputParamsResolver plugin */ -class InputParamsResolverTest extends \PHPUnit\Framework\TestCase +class InputParamsResolverTest extends TestCase { /** * @var string @@ -42,22 +44,22 @@ class InputParamsResolverTest extends \PHPUnit\Framework\TestCase private $objectManager; /** - * @var InputParamsResolver|\PHPUnit_Framework_MockObject_MockObject + * @var InputParamsResolver|MockObject */ private $subject; /** - * @var RestRequest|\PHPUnit_Framework_MockObject_MockObject + * @var RestRequest|MockObject */ private $request; /** - * @var Product|\PHPUnit_Framework_MockObject_MockObject + * @var Product|MockObject */ private $product; /** - * @var Route|\PHPUnit_Framework_MockObject_MockObject + * @var Route|MockObject */ private $route; @@ -69,7 +71,7 @@ class InputParamsResolverTest extends \PHPUnit\Framework\TestCase /** * @inheritdoc */ - protected function setUp() + protected function setUp(): void { $this->saveRewritesHistory = 'save_rewrites_history'; $this->requestBodyParams = [ diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Service/V1/StoreViewServiceTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Service/V1/StoreViewServiceTest.php index 7b80cc49ad527..63d2cddcd6efe 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Service/V1/StoreViewServiceTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Service/V1/StoreViewServiceTest.php @@ -1,44 +1,53 @@ -config = $this->createMock(\Magento\Eav\Model\Config::class); - $this->select = $this->getMockBuilder(\Magento\Framework\DB\Select::class) + $this->config = $this->createMock(Config::class); + $this->select = $this->getMockBuilder(DbSelect::class) ->setMethods(['select', 'from', 'where', 'join']) ->disableOriginalConstructor() ->getMock(); - $this->connection = $this->getMockBuilder(\Magento\Framework\DB\Adapter\AdapterInterface::class) + $this->connection = $this->getMockBuilder(AdapterInterface::class) ->disableOriginalConstructor() ->getMockForAbstractClass(); - $this->resource = $this->createMock(\Magento\Framework\App\ResourceConnection::class); + $this->resource = $this->createMock(ResourceConnection::class); $this->resource->expects($this->any())->method('getConnection')->willReturn($this->connection); $this->storeViewService = (new ObjectManager($this))->getObject( - \Magento\CatalogUrlRewrite\Service\V1\StoreViewService::class, + StoreViewService::class, [ 'eavConfig' => $this->config, 'resource' => $this->resource, @@ -80,13 +89,13 @@ public function testDoesEntityHaveOverriddenUrlKeyForStore($storeId, $fetchedSto { $entityType = 'entity_type'; $productId = 'product_id'; - $attribute = $this->getMockBuilder(\Magento\Eav\Model\Entity\Attribute\AbstractAttribute::class) + $attribute = $this->getMockBuilder(AbstractAttribute::class) ->disableOriginalConstructor() ->setMethods(['__wakeup', 'getBackendTable', 'getId', 'getEntity']) ->getMockForAbstractClass(); $this->config->expects($this->once())->method('getAttribute')->with($entityType, 'url_key') ->will($this->returnValue($attribute)); - $entity = $this->getMockBuilder(\Magento\Eav\Model\Entity\AbstractEntity::class) + $entity = $this->getMockBuilder(AbstractEntity::class) ->disableOriginalConstructor() ->getMock(); $attribute->expects($this->exactly(2))->method('getEntity')->willReturn($entity); @@ -111,12 +120,10 @@ public function testDoesEntityHaveOverriddenUrlKeyForStore($storeId, $fetchedSto ); } - /** - * @expectedException \InvalidArgumentException - * @expectedExceptionMessage Cannot retrieve attribute for entity type "invalid_type" - */ public function testInvalidAttributeRetrieve() { + $this->expectException('InvalidArgumentException'); + $this->expectExceptionMessage('Cannot retrieve attribute for entity type "invalid_type"'); $invalidEntityType = 'invalid_type'; $this->config->expects($this->once())->method('getAttribute')->will($this->returnValue(false)); diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Ui/DataProvider/Product/Form/Modifier/ProductUrlRewriteTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Ui/DataProvider/Product/Form/Modifier/ProductUrlRewriteTest.php index 40f7642f35383..19ca507c1cb42 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Ui/DataProvider/Product/Form/Modifier/ProductUrlRewriteTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Ui/DataProvider/Product/Form/Modifier/ProductUrlRewriteTest.php @@ -1,4 +1,4 @@ -scopeConfigMock = $this->getMockBuilder(ScopeConfigInterface::class) @@ -28,7 +27,7 @@ protected function setUp() } /** - * @return \Magento\Ui\DataProvider\Modifier\ModifierInterface|object + * @return ModifierInterface|object */ protected function createModel() {