Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple JAVA errors after bundling #84

Open
JackWormUK opened this issue Feb 8, 2021 · 4 comments
Open

Multiple JAVA errors after bundling #84

JackWormUK opened this issue Feb 8, 2021 · 4 comments

Comments

@JackWormUK
Copy link

JackWormUK commented Feb 8, 2021

Just tried to apply the bundling to a Magento 2.3.1 store. The store in question does have alot of modules and customisations.

However it is throwing up several different Java errors

On CMS/Product/Category;

bundle-product.min.js:1 Uncaught Fotorama requires jQuery 1.8 or later and will not run without it.

mixins.min.js:11 Uncaught TypeError: Cannot read property map of null at processNames (mixins.min.js:11) at Array.defContext.defQueue.shift (mixins.min.js:11) at intakeDefines (require.min.js:77) at localRequire (require.min.js:97) at Object.load (mixins.min.js:8) at Module.<anonymous> (require.min.js:71 at require.min.js:11 at on (require.min.js:40) at Module.callPlugin (require.min.js:61) at Module.fetch (require.min.js:55)

On the View Cart page it also throws out a different error, along with the Mixins error;

Uncaught Error: Mismatched anonymous define() module: function B(){function t(e,n){n&&(!function(){if(!n.tagName)throw new TypeError("Object is not a valid DOM element");if("IFRAME"!==n.tagName.toUpperCase())throw new TypeError("Expected <IFRAME> tag, found <"+n.tagName+">")}(),d(n,e),o.push(n))}var o;return function(){var e,n=["moz","webkit","o","ms"];for(e=0;e<n.length&&!r;e+=1)r=window[n[e]+"RequestAnimationFrame"];r||k("setup","RequestAnimationFrame not supported")}(),L(),function(e,n){var i;switch(o=[],(i=e)&&i.enablePublicMethods&&O("enablePublicMethods option has been removed, public methods are now always available in the iFrame"),typeof n){case"undefined":case"string":Array.prototype.forEach.call(document.querySelectorAll(n||"iframe"),t.bind(f,e));break;case"object":t(e,n);break;default:throw new TypeError("Unexpected data type ("+typeof n+")")}return o}} http://requirejs.org/docs/errors.html#mismatch at makeError (require.min.js:16) at intakeDefines (require.min.js:77) at localRequire (require.min.js:97) at Object.defContext.require (mixins.min.js:11) at requirejs (require.min.js:117) at Object.loadFromFile (bundle-common.min.js:1) at Object.loadTemplate (bundle-common.min.js:1) at bundle-common.min.js:1 at Object.execCb (require.min.js:112) at Module.check (require.min.js:56)

Both of the listed patches were applied (mixins/cookies) and the bundling was done in the correct order. The store was also error free before applying the bundling.

Anyone have any ideas?

I am setting up another 2.3.1 store with a different module config, so when its complete I will try Magepack again and see if it throws any errors.

@krzksz
Copy link
Collaborator

krzksz commented Feb 20, 2021

Do you have any extensions installed? Without the live URL it will be hard to debug for us but maybe you can try disabling them and see if one of their scripts is causing the issue.

@JackWormUK
Copy link
Author

Live URL is https://en.challengept.com

Was wondering if it was anything to do with this commit that you started?
magento/magento2#25587

Has a number of different modules running which would take some time to go through, hence asking here first if anyone had seen a similar issue

@krzksz
Copy link
Collaborator

krzksz commented Feb 20, 2021

Hmm, the commit you are mentioning was actually the key ingredient to make mixins work with bundling enabled, previously they were ignored completely.

Regarding the URL, I would need a one with bundling enabled and error being thrown (maybe some test system?) to debug it.

@JackWormUK
Copy link
Author

From looking at it, I assumed that was the base work for fixing the mixins and was included in the patches listed on the main page.

Sadly I don't have a duplicate test system (even though really I need one). We only have the production system.

I also know you are very busy and debugging our system isn't really your problem! If you have not seen this before then I will try and work through it and see what I can find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants