Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up hardcoded parameters #17

Open
krzhu opened this issue Jul 30, 2020 · 1 comment
Open

Cleaning up hardcoded parameters #17

krzhu opened this issue Jul 30, 2020 · 1 comment
Assignees
@baloneymath @krzhu @jayl940712
Labels
enhancement New feature or request

Comments

@krzhu
Copy link
Collaborator

krzhu commented Jul 30, 2020

We should cleaning up the hardcoded parameters.

  • This would take some efforts. We should not try finishing it in a big update. But rather clean part by part.
  • Because changing the codes may causing bugs, we need to do testing on them. However, we haven't built a comprehensive regression test pool yet, this cleaning up might be more suitable after we have some regression test.
  • I assign this to all of the current team members. You can clean up your parts when convenient and mention this issue in the PR. But don't close this issue until it is generally resolved for the whole project.
@krzhu krzhu added the enhancement New feature or request label Jul 30, 2020
@krzhu krzhu mentioned this issue Jul 30, 2020
Closed
@krzhu
Copy link
Collaborator Author

krzhu commented Jul 30, 2020

Blocked by #18

@krzhu krzhu modified the milestone: Reproducible results Jul 30, 2020
@krzhu krzhu mentioned this issue Jul 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baloneymath baloneymath

@krzhu krzhu

@jayl940712 jayl940712

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baloneymath @krzhu @jayl940712