Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined flag on station location #3165

Closed
thecocohead opened this issue Jul 9, 2024 · 4 comments
Closed

undefined flag on station location #3165

thecocohead opened this issue Jul 9, 2024 · 4 comments

Comments

@thecocohead
Copy link
Contributor

Describe the bug
When the user enables the station plot on the map, the flag shows up as undefined.

To Reproduce
Steps to reproduce the behaviour:

  1. Ensure map view is enabled on logbook overview screen (Admin > Global Options > Appearance > Logbook Map > Enabled)
  2. Enable station view on Logbook (Edit user > Cloudlog Preferences > Station > Display)
  3. Go to logbook overview screen
  4. Click on station
  5. Pop-up will say undefined where the flag should be

Expected behaviour
undefined should either be removed (showing nothing at all), or replaced with the station's DXCC entities' flag.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Firefox
  • Version: 127.0.2

Smartphone (please complete the following information):

  • Samsung Galaxy S23
  • OS: Android 14
  • Browser: Firefox
  • Version: 127.0.2
Copy link

github-actions bot commented Jul 9, 2024

Uh oh! @thecocohead, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@emics
Copy link
Contributor

emics commented Jul 11, 2024

hi @thecocohead , do you have undefined in all stations popup, did you see some flag?
Have you try to enable flag on some table columns (Edit user > Cloudlog Preferences > Logbook fields > Choose column 1 -> Flags)?

@thecocohead
Copy link
Contributor Author

@emics , I was able to fix this issue in PR #3167 which is currently merged into the dev branch. It was only shown for the user's station pop-up, not QSO stations.
I'm going to close this issue as completed for now.

@magicbug
Copy link
Owner

Thanks for the PR it was indeed a bug spotted it myself a couple of times!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants