From 34823dfc2095a1f4064623b68b93f4ce48ce94bf Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Tue, 25 Jun 2024 21:20:20 -0600 Subject: [PATCH 1/9] Bump ruby version to 3.2.0 --- .ruby-version | 2 +- Gemfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.ruby-version b/.ruby-version index 860487c..944880f 100644 --- a/.ruby-version +++ b/.ruby-version @@ -1 +1 @@ -2.7.1 +3.2.0 diff --git a/Gemfile b/Gemfile index 45745b5..098f33e 100644 --- a/Gemfile +++ b/Gemfile @@ -2,7 +2,7 @@ source 'https://rubygems.org' -ruby '2.7.1' +ruby '3.2.0' gem 'rails', '~> 5.x' From 8ceaee98e944f092a061966200a02396830de778 Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Tue, 25 Jun 2024 22:45:53 -0600 Subject: [PATCH 2/9] Remove coffee rails dependency --- Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/Gemfile b/Gemfile index 098f33e..f386a52 100644 --- a/Gemfile +++ b/Gemfile @@ -8,7 +8,6 @@ gem 'rails', '~> 5.x' gem 'active_model_serializers' gem 'autoprefixer-rails' -gem 'coffee-rails', '~> 4.1.0' gem 'dynamic_form' gem 'haml-rails' gem 'httparty' From 984590e6e0f1619e0218641a85d959769f6ee2d9 Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Tue, 25 Jun 2024 22:47:13 -0600 Subject: [PATCH 3/9] Delete old callback behavior https://stackoverflow.com/questions/49744200/nomethoderror-undefined-method-halt-callback-chains-on-return-false-for-acti --- config/initializers/new_framework_defaults.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/config/initializers/new_framework_defaults.rb b/config/initializers/new_framework_defaults.rb index 0b66c7b..61448a3 100644 --- a/config/initializers/new_framework_defaults.rb +++ b/config/initializers/new_framework_defaults.rb @@ -20,6 +20,3 @@ # Require `belongs_to` associations by default. Previous versions had false. Rails.application.config.active_record.belongs_to_required_by_default = false - -# Do not halt callback chains when a callback returns false. Previous versions had true. -ActiveSupport.halt_callback_chains_on_return_false = true From 8db8a6bedd71b29671909ce3590e2ea4a7f58304 Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Tue, 25 Jun 2024 22:48:48 -0600 Subject: [PATCH 4/9] Bump rails version to 6 --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index f386a52..d88c707 100644 --- a/Gemfile +++ b/Gemfile @@ -4,7 +4,7 @@ source 'https://rubygems.org' ruby '3.2.0' -gem 'rails', '~> 5.x' +gem 'rails', '~> 6.1.7.8' gem 'active_model_serializers' gem 'autoprefixer-rails' From 01fe5005ed40bd014c1cf6abe6c89e75b48c0b97 Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Tue, 25 Jun 2024 22:49:35 -0600 Subject: [PATCH 5/9] Udpate gemfile lock --- Gemfile.lock | 707 ++++++++++++++++++++++++++++----------------------- 1 file changed, 392 insertions(+), 315 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 9b45198..762d78a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,437 +1,515 @@ GEM remote: https://rubygems.org/ specs: - actioncable (5.0.7.2) - actionpack (= 5.0.7.2) - nio4r (>= 1.2, < 3.0) - websocket-driver (~> 0.6.1) - actionmailer (5.0.7.2) - actionpack (= 5.0.7.2) - actionview (= 5.0.7.2) - activejob (= 5.0.7.2) + actioncable (6.1.7.8) + actionpack (= 6.1.7.8) + activesupport (= 6.1.7.8) + nio4r (~> 2.0) + websocket-driver (>= 0.6.1) + actionmailbox (6.1.7.8) + actionpack (= 6.1.7.8) + activejob (= 6.1.7.8) + activerecord (= 6.1.7.8) + activestorage (= 6.1.7.8) + activesupport (= 6.1.7.8) + mail (>= 2.7.1) + actionmailer (6.1.7.8) + actionpack (= 6.1.7.8) + actionview (= 6.1.7.8) + activejob (= 6.1.7.8) + activesupport (= 6.1.7.8) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (5.0.7.2) - actionview (= 5.0.7.2) - activesupport (= 5.0.7.2) - rack (~> 2.0) - rack-test (~> 0.6.3) + actionpack (6.1.7.8) + actionview (= 6.1.7.8) + activesupport (= 6.1.7.8) + rack (~> 2.0, >= 2.0.9) + rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) - rails-html-sanitizer (~> 1.0, >= 1.0.2) - actionview (5.0.7.2) - activesupport (= 5.0.7.2) + rails-html-sanitizer (~> 1.0, >= 1.2.0) + actiontext (6.1.7.8) + actionpack (= 6.1.7.8) + activerecord (= 6.1.7.8) + activestorage (= 6.1.7.8) + activesupport (= 6.1.7.8) + nokogiri (>= 1.8.5) + actionview (6.1.7.8) + activesupport (= 6.1.7.8) builder (~> 3.1) - erubis (~> 2.7.0) + erubi (~> 1.4) rails-dom-testing (~> 2.0) - rails-html-sanitizer (~> 1.0, >= 1.0.3) - active_model_serializers (0.10.12) - actionpack (>= 4.1, < 6.2) - activemodel (>= 4.1, < 6.2) + rails-html-sanitizer (~> 1.1, >= 1.2.0) + active_model_serializers (0.10.14) + actionpack (>= 4.1) + activemodel (>= 4.1) case_transform (>= 0.2) jsonapi-renderer (>= 0.1.1.beta1, < 0.3) - activejob (5.0.7.2) - activesupport (= 5.0.7.2) + activejob (6.1.7.8) + activesupport (= 6.1.7.8) globalid (>= 0.3.6) - activemodel (5.0.7.2) - activesupport (= 5.0.7.2) - activerecord (5.0.7.2) - activemodel (= 5.0.7.2) - activesupport (= 5.0.7.2) - arel (~> 7.0) - activesupport (5.0.7.2) + activemodel (6.1.7.8) + activesupport (= 6.1.7.8) + activerecord (6.1.7.8) + activemodel (= 6.1.7.8) + activesupport (= 6.1.7.8) + activestorage (6.1.7.8) + actionpack (= 6.1.7.8) + activejob (= 6.1.7.8) + activerecord (= 6.1.7.8) + activesupport (= 6.1.7.8) + marcel (~> 1.0) + mini_mime (>= 1.1.0) + activesupport (6.1.7.8) concurrent-ruby (~> 1.0, >= 1.0.2) - i18n (>= 0.7, < 2) - minitest (~> 5.1) - tzinfo (~> 1.1) - addressable (2.7.0) - public_suffix (>= 2.0.2, < 5.0) - arel (7.1.4) - ast (2.4.1) - autoprefixer-rails (10.2.0.0) - execjs - brakeman (4.10.1) - buftok (0.2.0) - builder (3.2.4) - bullet (6.1.2) + i18n (>= 1.6, < 2) + minitest (>= 5.1) + tzinfo (~> 2.0) + zeitwerk (~> 2.3) + addressable (2.8.7) + public_suffix (>= 2.0.2, < 7.0) + ast (2.4.2) + autoprefixer-rails (10.4.16.0) + execjs (~> 2) + base64 (0.2.0) + bigdecimal (3.1.8) + brakeman (6.1.2) + racc + buftok (0.3.0) + builder (3.3.0) + bullet (7.1.6) activesupport (>= 3.0.0) uniform_notifier (~> 1.11) byebug (11.1.3) - capybara (3.32.2) + capybara (3.40.0) addressable + matrix mini_mime (>= 0.1.3) - nokogiri (~> 1.8) + nokogiri (~> 1.11) rack (>= 1.6.0) rack-test (>= 0.6.3) - regexp_parser (~> 1.5) + regexp_parser (>= 1.5, < 3.0) xpath (~> 3.2) - capybara-webmock (0.5.5) + capybara-webmock (0.7.0) capybara (>= 2.4, < 4) rack (>= 1.4) rack-proxy (>= 0.6.0) - selenium-webdriver (~> 3.0) + rexml (>= 3.2) + selenium-webdriver (>= 4.0) + webrick (>= 1.7) case_transform (0.2) activesupport - childprocess (3.0.0) + childprocess (5.0.0) coderay (1.1.3) - coffee-rails (4.1.1) - coffee-script (>= 2.2.0) - railties (>= 4.0.0, < 5.1.x) - coffee-script (2.4.1) - coffee-script-source - execjs - coffee-script-source (1.12.2) - concurrent-ruby (1.1.8) - crack (0.4.5) + concurrent-ruby (1.3.3) + crack (1.0.0) + bigdecimal rexml crass (1.0.6) - cucumber (4.1.0) - builder (~> 3.2, >= 3.2.3) - cucumber-core (~> 7.1, >= 7.1.0) - cucumber-create-meta (~> 1.0.0, >= 1.0.0) - cucumber-cucumber-expressions (~> 10.1, >= 10.1.0) - cucumber-gherkin (~> 14.0, >= 14.0.1) - cucumber-html-formatter (~> 7.0, >= 7.0.0) - cucumber-messages (~> 12.2, >= 12.2.0) - cucumber-wire (~> 3.1, >= 3.1.0) - diff-lcs (~> 1.3, >= 1.3, < 1.4) - multi_test (~> 0.1, >= 0.1.2) - sys-uname (~> 1.0, >= 1.0.2) - cucumber-core (7.1.0) - cucumber-gherkin (~> 14.0, >= 14.0.1) - cucumber-messages (~> 12.2, >= 12.2.0) - cucumber-tag-expressions (~> 2.0, >= 2.0.4) - cucumber-create-meta (1.0.0) - cucumber-messages (~> 12.2, >= 12.2.0) - sys-uname (~> 1.2, >= 1.2.1) - cucumber-cucumber-expressions (10.3.0) - cucumber-gherkin (14.2.0) - cucumber-messages (~> 12.4, >= 12.4.0) - cucumber-html-formatter (7.2.0) - cucumber-messages (~> 12.4, >= 12.4.0) - cucumber-messages (12.4.0) - protobuf-cucumber (~> 3.10, >= 3.10.8) - cucumber-rails (2.1.0) - capybara (>= 2.12, < 4) - cucumber (>= 3.0.2, < 5) - mime-types (>= 2.0, < 4) - nokogiri (~> 1.8) - rails (>= 4.2, < 7) - cucumber-tag-expressions (2.0.4) - cucumber-wire (3.1.0) - cucumber-core (~> 7.1, >= 7.1.0) - cucumber-cucumber-expressions (~> 10.1, >= 10.1.0) - cucumber-messages (~> 12.2, >= 12.2.0) - database_cleaner (1.8.5) - diff-lcs (1.3) - domain_name (0.5.20190701) - unf (>= 0.0.5, < 1.0.0) - dynamic_form (1.1.4) + csv (3.3.0) + cucumber (9.2.0) + builder (~> 3.2) + cucumber-ci-environment (> 9, < 11) + cucumber-core (> 13, < 14) + cucumber-cucumber-expressions (~> 17.0) + cucumber-gherkin (> 24, < 28) + cucumber-html-formatter (> 20.3, < 22) + cucumber-messages (> 19, < 25) + diff-lcs (~> 1.5) + mini_mime (~> 1.1) + multi_test (~> 1.1) + sys-uname (~> 1.2) + cucumber-ci-environment (10.0.1) + cucumber-core (13.0.2) + cucumber-gherkin (>= 27, < 28) + cucumber-messages (>= 20, < 23) + cucumber-tag-expressions (> 5, < 7) + cucumber-cucumber-expressions (17.1.0) + bigdecimal + cucumber-gherkin (27.0.0) + cucumber-messages (>= 19.1.4, < 23) + cucumber-html-formatter (21.4.0) + cucumber-messages (> 19, < 25) + cucumber-messages (22.0.0) + cucumber-rails (3.0.0) + capybara (>= 3.11, < 4) + cucumber (>= 5, < 10) + railties (>= 5.2, < 8) + cucumber-tag-expressions (6.1.0) + database_cleaner (2.0.2) + database_cleaner-active_record (>= 2, < 3) + database_cleaner-active_record (2.1.0) + activerecord (>= 5.a) + database_cleaner-core (~> 2.0.0) + database_cleaner-core (2.0.1) + date (3.3.4) + diff-lcs (1.5.1) + domain_name (0.6.20240107) + dynamic_form (1.3.1) + actionview (> 5.2.0) + activemodel (> 5.2.0) equalizer (0.0.11) - erubis (2.7.0) - execjs (2.7.0) - factory_bot (5.2.0) - activesupport (>= 4.2.0) - factory_bot_rails (5.2.0) - factory_bot (~> 5.2.0) - railties (>= 4.2.0) - faker (2.12.0) - i18n (>= 1.6, < 2) - faraday (1.3.0) - faraday-net_http (~> 1.0) - multipart-post (>= 1.2, < 3) - ruby2_keywords - faraday-net_http (1.0.1) - ffaker (2.16.0) - ffi (1.14.2) - ffi-compiler (1.0.1) - ffi (>= 1.0.0) + erubi (1.13.0) + execjs (2.9.1) + factory_bot (6.4.6) + activesupport (>= 5.0.0) + factory_bot_rails (6.4.3) + factory_bot (~> 6.4) + railties (>= 5.0.0) + faker (3.4.1) + i18n (>= 1.8.11, < 2) + faraday (2.9.2) + faraday-net_http (>= 2.0, < 3.2) + faraday-net_http (3.1.0) + net-http + ffaker (2.23.0) + ffi (1.17.0-aarch64-linux-gnu) + ffi (1.17.0-aarch64-linux-musl) + ffi (1.17.0-arm-linux-gnu) + ffi (1.17.0-arm-linux-musl) + ffi (1.17.0-arm64-darwin) + ffi (1.17.0-x86-linux-gnu) + ffi (1.17.0-x86-linux-musl) + ffi (1.17.0-x86_64-darwin) + ffi (1.17.0-x86_64-linux-gnu) + ffi (1.17.0-x86_64-linux-musl) + ffi-compiler (1.3.2) + ffi (>= 1.15.5) rake figaro (1.2.0) thor (>= 0.14.0, < 2) - globalid (0.4.2) - activesupport (>= 4.2.0) - haml (5.2.1) - temple (>= 0.8.0) + globalid (1.2.1) + activesupport (>= 6.1) + haml (6.3.0) + temple (>= 0.8.2) + thor tilt - haml-rails (1.0.0) - actionpack (>= 4.0.1) - activesupport (>= 4.0.1) - haml (>= 4.0.6, < 6.0) - html2haml (>= 1.0.1) - railties (>= 4.0.1) - hashdiff (1.0.1) - hashie (4.1.0) - html2haml (2.2.0) - erubis (~> 2.7.0) - haml (>= 4.0, < 6) - nokogiri (>= 1.6.0) - ruby_parser (~> 3.5) - http (4.4.1) - addressable (~> 2.3) + haml-rails (2.1.0) + actionpack (>= 5.1) + activesupport (>= 5.1) + haml (>= 4.0.6) + railties (>= 5.1) + hashdiff (1.1.0) + hashie (5.0.0) + http (5.2.0) + addressable (~> 2.8) + base64 (~> 0.1) http-cookie (~> 1.0) http-form_data (~> 2.2) - http-parser (~> 1.2.0) - http-cookie (1.0.3) + llhttp-ffi (~> 0.5.0) + http-cookie (1.0.6) domain_name (~> 0.5) http-form_data (2.3.0) - http-parser (1.2.3) - ffi-compiler (>= 1.0, < 2.0) - http_parser.rb (0.6.0) - httparty (0.18.1) - mime-types (~> 3.0) + httparty (0.22.0) + csv + mini_mime (>= 1.0.0) multi_xml (>= 0.5.2) - i18n (1.8.8) + i18n (1.14.5) concurrent-ruby (~> 1.0) - jbuilder (2.10.1) + jbuilder (2.12.0) + actionview (>= 5.0.0) activesupport (>= 5.0.0) - jquery-rails (4.4.0) + jquery-rails (4.6.0) rails-dom-testing (>= 1, < 3) railties (>= 4.2.0) thor (>= 0.14, < 2.0) + json (2.7.2) jsonapi-renderer (0.2.2) - jwt (2.2.2) - kaminari (1.2.1) + jwt (2.8.2) + base64 + kaminari (1.2.2) activesupport (>= 4.1.0) - kaminari-actionview (= 1.2.1) - kaminari-activerecord (= 1.2.1) - kaminari-core (= 1.2.1) - kaminari-actionview (1.2.1) + kaminari-actionview (= 1.2.2) + kaminari-activerecord (= 1.2.2) + kaminari-core (= 1.2.2) + kaminari-actionview (1.2.2) actionview - kaminari-core (= 1.2.1) - kaminari-activerecord (1.2.1) + kaminari-core (= 1.2.2) + kaminari-activerecord (1.2.2) activerecord - kaminari-core (= 1.2.1) - kaminari-core (1.2.1) - launchy (2.5.0) - addressable (~> 2.7) - loofah (2.9.0) + kaminari-core (= 1.2.2) + kaminari-core (1.2.2) + language_server-protocol (3.17.0.3) + launchy (3.0.1) + addressable (~> 2.8) + childprocess (~> 5.0) + llhttp-ffi (0.5.0) + ffi-compiler (~> 1.0) + rake (~> 13.0) + logger (1.6.0) + loofah (2.22.0) crass (~> 1.0.2) - nokogiri (>= 1.5.9) - mail (2.7.1) + nokogiri (>= 1.12.0) + mail (2.8.1) mini_mime (>= 0.1.1) + net-imap + net-pop + net-smtp + marcel (1.0.4) + matrix (0.4.2) memoizable (0.4.2) thread_safe (~> 0.3, >= 0.3.1) - method_source (1.0.0) - middleware (0.1.0) - mime-types (3.3.1) - mime-types-data (~> 3.2015) - mime-types-data (3.2020.1104) - mini_mime (1.0.2) - mini_portile2 (2.8.7) - minitest (5.14.3) - multi_json (1.15.0) - multi_test (0.1.2) - multi_xml (0.6.0) - multipart-post (2.1.1) + method_source (1.1.0) + mini_mime (1.1.5) + minitest (5.24.0) + multi_test (1.1.0) + multi_xml (0.7.1) + bigdecimal (~> 3.1) + multipart-post (2.4.1) naught (1.1.0) - nio4r (2.5.4) - nokogiri (1.15.6) - mini_portile2 (~> 2.8.2) + net-http (0.4.1) + uri + net-imap (0.4.14) + date + net-protocol + net-pop (0.1.2) + net-protocol + net-protocol (0.2.2) + timeout + net-smtp (0.5.0) + net-protocol + nio4r (2.7.3) + nokogiri (1.16.6-aarch64-linux) racc (~> 1.4) - oauth2 (1.4.4) - faraday (>= 0.8, < 2.0) + nokogiri (1.16.6-arm-linux) + racc (~> 1.4) + nokogiri (1.16.6-arm64-darwin) + racc (~> 1.4) + nokogiri (1.16.6-x86-linux) + racc (~> 1.4) + nokogiri (1.16.6-x86_64-darwin) + racc (~> 1.4) + nokogiri (1.16.6-x86_64-linux) + racc (~> 1.4) + oauth2 (2.0.9) + faraday (>= 0.17.3, < 3.0) jwt (>= 1.0, < 3.0) - multi_json (~> 1.3) multi_xml (~> 0.5) - rack (>= 1.2, < 3) - omniauth (2.0.2) + rack (>= 1.2, < 4) + snaky_hash (~> 2.0) + version_gem (~> 1.1) + omniauth (2.1.2) hashie (>= 3.4.6) - rack (>= 1.6.2, < 3) + rack (>= 2.2.3) rack-protection - omniauth-google-oauth2 (0.8.1) + omniauth-google-oauth2 (1.1.2) jwt (>= 2.0) - oauth2 (~> 1.1) - omniauth (>= 1.1.1) - omniauth-oauth2 (>= 1.6) - omniauth-oauth2 (1.7.1) - oauth2 (~> 1.4) - omniauth (>= 1.9, < 3) - parallel (1.20.1) - parser (3.0.0.0) + oauth2 (~> 2.0) + omniauth (~> 2.0) + omniauth-oauth2 (~> 1.8) + omniauth-oauth2 (1.8.0) + oauth2 (>= 1.4, < 3) + omniauth (~> 2.0) + parallel (1.25.1) + parser (3.3.3.0) ast (~> 2.4.1) - pg (1.2.3) + racc + pg (1.5.6) phil (0.9.8) activesupport ffaker (~> 2.0) - protobuf-cucumber (3.10.8) - activesupport (>= 3.2) - middleware - thor - thread_safe - pry (0.13.1) + pry (0.14.2) coderay (~> 1.1) method_source (~> 1.0) - pry-byebug (3.9.0) + pry-byebug (3.10.1) byebug (~> 11.0) - pry (~> 0.13.0) - pry-rails (0.3.9) - pry (>= 0.10.4) - public_suffix (4.0.6) - puma (5.1.1) + pry (>= 0.13, < 0.15) + pry-rails (0.3.11) + pry (>= 0.13.0) + public_suffix (6.0.0) + puma (6.4.2) nio4r (~> 2.0) racc (1.8.0) - rack (2.2.3) - rack-cors (1.1.1) + rack (2.2.9) + rack-cors (2.0.2) rack (>= 2.0.0) - rack-protection (2.1.0) + rack-protection (3.2.0) + base64 (>= 0.1.0) + rack (~> 2.2, >= 2.2.4) + rack-proxy (0.7.7) rack - rack-proxy (0.6.5) - rack - rack-test (0.6.3) - rack (>= 1.0) - rails (5.0.7.2) - actioncable (= 5.0.7.2) - actionmailer (= 5.0.7.2) - actionpack (= 5.0.7.2) - actionview (= 5.0.7.2) - activejob (= 5.0.7.2) - activemodel (= 5.0.7.2) - activerecord (= 5.0.7.2) - activesupport (= 5.0.7.2) - bundler (>= 1.3.0) - railties (= 5.0.7.2) + rack-test (2.1.0) + rack (>= 1.3) + rails (6.1.7.8) + actioncable (= 6.1.7.8) + actionmailbox (= 6.1.7.8) + actionmailer (= 6.1.7.8) + actionpack (= 6.1.7.8) + actiontext (= 6.1.7.8) + actionview (= 6.1.7.8) + activejob (= 6.1.7.8) + activemodel (= 6.1.7.8) + activerecord (= 6.1.7.8) + activestorage (= 6.1.7.8) + activesupport (= 6.1.7.8) + bundler (>= 1.15.0) + railties (= 6.1.7.8) sprockets-rails (>= 2.0.0) rails-controller-testing (1.0.5) actionpack (>= 5.0.1.rc1) actionview (>= 5.0.1.rc1) activesupport (>= 5.0.1.rc1) - rails-dom-testing (2.0.3) - activesupport (>= 4.2.0) + rails-dom-testing (2.2.0) + activesupport (>= 5.0.0) + minitest nokogiri (>= 1.6) - rails-html-sanitizer (1.3.0) - loofah (~> 2.3) + rails-html-sanitizer (1.6.0) + loofah (~> 2.21) + nokogiri (~> 1.14) rails_12factor (0.0.3) rails_serve_static_assets rails_stdout_logging rails_serve_static_assets (0.0.5) rails_stdout_logging (0.0.5) - railties (5.0.7.2) - actionpack (= 5.0.7.2) - activesupport (= 5.0.7.2) + railties (6.1.7.8) + actionpack (= 6.1.7.8) + activesupport (= 6.1.7.8) method_source - rake (>= 0.8.7) - thor (>= 0.18.1, < 2.0) - rainbow (3.0.0) - rake (13.0.3) - rb-fsevent (0.10.4) - rb-inotify (0.10.1) + rake (>= 12.2) + thor (~> 1.0) + rainbow (3.1.1) + rake (13.2.1) + rb-fsevent (0.11.2) + rb-inotify (0.11.1) ffi (~> 1.0) - redcarpet (3.5.1) - regexp_parser (1.8.2) - rexml (3.2.4) - rouge (3.26.0) - rspec-core (3.10.1) - rspec-support (~> 3.10.0) - rspec-expectations (3.10.1) + redcarpet (3.6.0) + regexp_parser (2.9.2) + rexml (3.3.1) + strscan + rouge (4.3.0) + rspec-core (3.13.0) + rspec-support (~> 3.13.0) + rspec-expectations (3.13.1) diff-lcs (>= 1.2.0, < 2.0) - rspec-support (~> 3.10.0) - rspec-mocks (3.10.1) + rspec-support (~> 3.13.0) + rspec-mocks (3.13.1) diff-lcs (>= 1.2.0, < 2.0) - rspec-support (~> 3.10.0) - rspec-rails (4.0.2) - actionpack (>= 4.2) - activesupport (>= 4.2) - railties (>= 4.2) - rspec-core (~> 3.10) - rspec-expectations (~> 3.10) - rspec-mocks (~> 3.10) - rspec-support (~> 3.10) - rspec-support (3.10.1) - rspec_junit_formatter (0.4.1) + rspec-support (~> 3.13.0) + rspec-rails (6.1.3) + actionpack (>= 6.1) + activesupport (>= 6.1) + railties (>= 6.1) + rspec-core (~> 3.13) + rspec-expectations (~> 3.13) + rspec-mocks (~> 3.13) + rspec-support (~> 3.13) + rspec-support (3.13.1) + rspec_junit_formatter (0.6.0) rspec-core (>= 2, < 4, != 2.12.0) - rubocop (1.8.1) + rubocop (1.64.1) + json (~> 2.3) + language_server-protocol (>= 3.17.0) parallel (~> 1.10) - parser (>= 3.0.0.0) + parser (>= 3.3.0.2) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) - rexml - rubocop-ast (>= 1.2.0, < 2.0) + rexml (>= 3.2.5, < 4.0) + rubocop-ast (>= 1.31.1, < 2.0) ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.4.0) - parser (>= 2.7.1.5) - rubocop-performance (1.9.2) - rubocop (>= 0.90.0, < 2.0) - rubocop-ast (>= 0.4.0) - rubocop-rails (2.9.1) + unicode-display_width (>= 2.4.0, < 3.0) + rubocop-ast (1.31.3) + parser (>= 3.3.1.0) + rubocop-performance (1.21.1) + rubocop (>= 1.48.1, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) + rubocop-rails (2.25.0) activesupport (>= 4.2.0) rack (>= 1.1) - rubocop (>= 0.90.0, < 2.0) - rubocop-rspec (2.1.0) - rubocop (~> 1.0) - rubocop-ast (>= 1.1.0) - ruby-progressbar (1.11.0) - ruby2_keywords (0.0.4) - ruby_parser (3.15.1) - sexp_processor (~> 4.9) - rubyzip (2.3.0) + rubocop (>= 1.33.0, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) + rubocop-rspec (3.0.1) + rubocop (~> 1.61) + ruby-progressbar (1.13.0) + rubyzip (2.3.2) sass (3.7.4) sass-listen (~> 4.0.0) sass-listen (4.0.0) rb-fsevent (~> 0.9, >= 0.9.4) rb-inotify (~> 0.9, >= 0.9.7) - sass-rails (5.0.7) - railties (>= 4.0.0, < 6) + sass-rails (5.1.0) + railties (>= 5.2.0) sass (~> 3.1) sprockets (>= 2.8, < 4.0) sprockets-rails (>= 2.0, < 4.0) tilt (>= 1.1, < 3) - scenic (1.5.4) + scenic (1.8.0) activerecord (>= 4.0.0) railties (>= 4.0.0) - selenium-webdriver (3.142.7) - childprocess (>= 0.5, < 4.0) - rubyzip (>= 1.2.2) - sexp_processor (4.15.2) + selenium-webdriver (4.22.0) + base64 (~> 0.2) + logger (~> 1.4) + rexml (~> 3.2, >= 3.2.5) + rubyzip (>= 1.2.2, < 3.0) + websocket (~> 1.0) simple_oauth (0.3.1) - spring (2.1.1) - sprockets (3.7.2) + snaky_hash (2.0.1) + hashie + version_gem (~> 1.1, >= 1.1.1) + spring (4.2.1) + sprockets (3.7.3) + base64 concurrent-ruby (~> 1.0) rack (> 1, < 3) - sprockets-rails (3.2.2) - actionpack (>= 4.0) - activesupport (>= 4.0) + sprockets-rails (3.5.1) + actionpack (>= 6.1) + activesupport (>= 6.1) sprockets (>= 3.0.0) + strscan (3.1.0) sucker_punch (2.1.2) concurrent-ruby (~> 1.0) - sys-uname (1.2.2) + sys-uname (1.3.0) ffi (~> 1.1) - temple (0.8.2) - thor (1.1.0) + temple (0.10.3) + thor (1.3.1) thread_safe (0.3.6) - tilt (2.0.10) - twitter (7.0.0) - addressable (~> 2.3) - buftok (~> 0.2.0) + tilt (2.3.0) + timeout (0.4.1) + twitter (8.1.0) + addressable (~> 2.8) + buftok (~> 0.3.0) equalizer (~> 0.0.11) - http (~> 4.0) - http-form_data (~> 2.0) - http_parser.rb (~> 0.6.0) + http (~> 5.2) + http-form_data (~> 2.3) + llhttp-ffi (~> 0.5.0) memoizable (~> 0.4.0) - multipart-post (~> 2.0) - naught (~> 1.0) + multipart-post (~> 2.4) + naught (~> 1.1) simple_oauth (~> 0.3.0) - tzinfo (1.2.9) - thread_safe (~> 0.1) + tzinfo (2.0.6) + concurrent-ruby (~> 1.0) uglifier (4.2.0) execjs (>= 0.3.0, < 3) - unf (0.1.4) - unf_ext - unf_ext (0.0.7.7) - unicode-display_width (2.0.0) - uniform_notifier (1.13.2) - webmock (3.11.1) - addressable (>= 2.3.6) + unicode-display_width (2.5.0) + uniform_notifier (1.16.0) + uri (0.13.0) + version_gem (1.1.4) + webmock (3.23.1) + addressable (>= 2.8.0) crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) - websocket-driver (0.6.5) + webrick (1.8.1) + websocket (1.2.10) + websocket-driver (0.7.6) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) + zeitwerk (2.6.16) PLATFORMS - ruby + aarch64-linux + aarch64-linux-gnu + aarch64-linux-musl + arm-linux + arm-linux-gnu + arm-linux-musl + arm64-darwin + x86-linux + x86-linux-gnu + x86-linux-musl + x86_64-darwin + x86_64-linux + x86_64-linux-gnu + x86_64-linux-musl DEPENDENCIES active_model_serializers @@ -439,7 +517,6 @@ DEPENDENCIES brakeman bullet capybara-webmock - coffee-rails (~> 4.1.0) cucumber-rails database_cleaner dynamic_form @@ -459,7 +536,7 @@ DEPENDENCIES pry-rails puma rack-cors - rails (~> 5.x) + rails (~> 6.1.7.8) rails-controller-testing rails_12factor redcarpet @@ -480,7 +557,7 @@ DEPENDENCIES webmock RUBY VERSION - ruby 2.7.1 + ruby 3.2.0p0 BUNDLED WITH - 2.2.9 + 2.5.14 From 5672c1186ca79d0526c81743548b302bbd9abbab Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Wed, 26 Jun 2024 09:19:12 -0600 Subject: [PATCH 6/9] Fix broken spec number one --- spec/requests/sitemap_request_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/requests/sitemap_request_spec.rb b/spec/requests/sitemap_request_spec.rb index 25443ae..15bb525 100644 --- a/spec/requests/sitemap_request_spec.rb +++ b/spec/requests/sitemap_request_spec.rb @@ -5,7 +5,7 @@ context 'GET /sitemap' do it 'returns the xml with all the posts' do post = create(:post) - get sitemap_path, format: :xml + get sitemap_path, params: { format: :xml } expect(response.body).to include(post.slug) end end From 11caec7c362db330cd24ff9ad544da782c2a5b06 Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Wed, 26 Jun 2024 09:19:56 -0600 Subject: [PATCH 7/9] Fix broken test number two --- spec/controllers/posts_controller_spec.rb | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/spec/controllers/posts_controller_spec.rb b/spec/controllers/posts_controller_spec.rb index ba34ba8..3f7c479 100644 --- a/spec/controllers/posts_controller_spec.rb +++ b/spec/controllers/posts_controller_spec.rb @@ -57,12 +57,10 @@ it 'only allows me to update my own posts' do expect do - patch :update, { - params: { - titled_slug: not_my_post.to_param, - post: { title: 'HAXORD' } - } - } + patch :update, params: { + titled_slug: not_my_post.to_param, + post: { title: 'HAXORD' } + } end.not_to change { not_my_post.reload.title } end From bdee3aeb0f192d1d10627b37dbf9477c4ba36d50 Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Wed, 26 Jun 2024 12:18:44 -0600 Subject: [PATCH 8/9] Fix reamaining broken specs --- app/models/post.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/post.rb b/app/models/post.rb index 31f3df1..4ccd0da 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -79,7 +79,7 @@ def likes_threshold? end def publishing? - published_at? && published_at_changed? + published_at? && published_at_previously_changed? end def generate_slug From 438d1e32fca9f4b3c8f026b556a6645009467eb2 Mon Sep 17 00:00:00 2001 From: Ilyeo Date: Wed, 26 Jun 2024 12:19:35 -0600 Subject: [PATCH 9/9] Add spec to test when a published post is unpublished --- spec/models/post_spec.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/spec/models/post_spec.rb b/spec/models/post_spec.rb index 2269889..28a60b1 100644 --- a/spec/models/post_spec.rb +++ b/spec/models/post_spec.rb @@ -192,6 +192,16 @@ post.save end end + + describe 'a published post when' do + it 'has been changed to unpublished' do + post = FactoryBot.create(:post) + post.published_at = nil + + expect(post).not_to receive(:notify_slack) + post.save + end + end end describe '#increment_likes' do