Fixes and improvements to SpooledBytesIO & SpooledStringIO #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inherit from IOBase so instance & type checks are simpler - __eq__ and __ne__ no longer need to load both files completely into memory - __eq__ and __ne__ reset read-head in comparison errors - Some methods now raise a ValueError if the file is closed. This brings the implementations closer to StringIO and implementations from the io module
|
Hey, these updates look great! Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.IOBaseso instance & type checks are simpler__eq__and__ne__no longer need to load both files completely into memory__eq__and__ne__reset read-head in comparison errorsStringIOand implementations from theiomodule