Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Torii addon abandonned ? #2354

Open
BnitoBzh opened this issue Jan 3, 2022 · 10 comments
Open

Is Torii addon abandonned ? #2354

BnitoBzh opened this issue Jan 3, 2022 · 10 comments

Comments

@BnitoBzh
Copy link

BnitoBzh commented Jan 3, 2022

The Torii addon has 72 open issues and 38 pull requests.
It has not been updated for over 3 years.

At this time, Torii is required in order to use 3rd party authentications .. But with Ember 3.28 and more, the Torii addon starts to be deprecated in a lot of things

What will the deal be for the future? For now ember-simple-auth needs Torii. So users need to fork Torii to update it? Will the ember-simple-auth maintainers do something integrated?

@pichfl
Copy link
Contributor

pichfl commented Jan 3, 2022

The Torii authenticator was recently deprecated in #2352 and will be removed from ESA in a future breaking release. It is possible to built something that replicates what Torii in a custom authenticator inside ESA. There is no roadmap for this as of now.

@BnitoBzh
Copy link
Author

BnitoBzh commented Jan 6, 2022

Wow ! Ok .. ESA is the most used addon by the Ember community for authentication/authorization implementation and its next breaking release is to remove its social connection feature without a workaround in its roadmap ?
I think propose a full built-in solution, an abstract layer or a real example (without Torii) should be do.

@luxzeitlos
Copy link

IMHO this is the right decision. Torii is (and always was) unrelated to ESA, and the integration was never nice. Not it seems dead, so better don't hold ESA with it. It is actually pretty straightforward to just use ESA and a custom authenticator.

@davideferre
Copy link

davideferre commented Feb 28, 2022

The Torii authenticator was recently deprecated in #2352 and will be removed from ESA in a future breaking release. It is possible to built something that replicates what Torii in a custom authenticator inside ESA. There is no roadmap for this as of now.

@pichfl I've wrote down a custom Authenticator to replace Torii (and a service to manage the popup). Do you think is better opening a PR on this repo with that code or creating a separate ember addon for handling that type of authentication flow?

@LumenMicho
Copy link

The Torii authenticator was recently deprecated in #2352 and will be removed from ESA in a future breaking release. It is possible to built something that replicates what Torii in a custom authenticator inside ESA. There is no roadmap for this as of now.

@pichfl I've wrote down a custom Authenticator to replace Torii (and a service to manage the popup). Do you think is better opening a PR on this repo with that code or creating a separate ember addon for handling that type of authentication flow?

@davideferre I am looking to write the same thing and using yours as a reference would be a great help!

@pichfl
Copy link
Contributor

pichfl commented Jul 13, 2022

@pichfl I've wrote down a custom Authenticator to replace Torii (and a service to manage the popup). Do you think is better opening a PR on this repo with that code or creating a separate ember addon for handling that type of authentication flow?

@davideferre I did some work in #2367 but wasn't able to allocate the necessary time yet, maybe we can join efforts here. A PR is always welcome.

@davideferre
Copy link

I can share a PR later today, thanks!

@davideferre
Copy link

@pichfl @LumenMicho I'm not ready for a PR yet but here you can see a work-in-progress version of what I did some months ago to replace Torii in some of my private apps: https://github.com/davideferre/ember-simple-auth/blob/popup_authenticator/packages/ember-simple-auth/addon/authenticators/oauth2-popup.js
Note that at the moment it uses two additional services but probably is not a good thing to add 2 services to ESA just for this authenticator.

@Gaurav0
Copy link
Contributor

Gaurav0 commented Jan 30, 2023

Version 1.0.0-beta.1 of torii has been published.

Source code is located at https://github.com/adopted-ember-addons/torii

@khaled-s
Copy link

ESA is raising a deprecation for using torii, this should be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants