Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-simple-auth is using its own copies of peer-deps like RSVP #2731

Open
runspired opened this issue Feb 9, 2024 · 2 comments
Open

ember-simple-auth is using its own copies of peer-deps like RSVP #2731

runspired opened this issue Feb 9, 2024 · 2 comments

Comments

@runspired
Copy link
Contributor

runspired commented Feb 9, 2024

rsvp should be a peer-dep for ember-simple-auth but isn't. I'm not sure if that fix alone would cause ember-auto-import to stop bundling a unique rsvp version for use by it in its chunk but it may? There's probably something to work out with ember-auto-import here too.

Additionally: I am unsure what all embroider addon tooling is supposed to auto populate for externals, but either rsvp isn't in it and should be or ember-simple-auth needs to explicitly declare rsvp and similar as part of externals.

@runspired runspired changed the title ember-simple-auth is bundling its own copies of peer-deps like RSVP ember-simple-auth is using its own copies of peer-deps like RSVP Feb 9, 2024
@ef4
Copy link
Contributor

ef4 commented Feb 13, 2024

ember-auto-import should be treating rsvp like the rest of the magically-provided ember packages. So if it's getting bundled that's a bug in ember-auto-import (or @embroider/shared-internals).

Whereas if rsvp gets added to the package.json (as a peer or dependency), that would opt out of the magical backward compatible behavior and cause you to get a real copy, at least under embroider (would need to check under ember-auto-import).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants