-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adsense error when upgrading to 1.3.2.1 #218
Comments
Very strange. What version did you upgrade from? Do you have a live link and/or screenshot? |
I just bought and installed a test page a few hours before version 1.3.2.1 was released! So I think is version 1.3.1. Yes, you can visit "x.ocuaso.com" and see the post! Besides, I also installed a completely new site without any plugin, with version 1.3.1, everything works fine. Since I have changed everything on two sites for comparison, I think this is a topic related issue. (On firefox and IE still works fine) Hope you will check! Thanks very much! |
Hi, here is a screenshot: |
That looks like you are trying to load a banner width ad inside the content area? Shouldn’t you limit that ad size to around 800px or so? |
No, this is a responsive ad, and it still works well on IE, Firefox, as well as other genesis topics. I tried adding fixed width for ".content", like: .Content { Replacement for the default css: .Content { => The problem has been corrected. However, I'm not an expert to know how to fix this "right" or not. Being forced to use fixed ads on a responsive theme seems to be a downside. Hope you will check and fix! Thanks very much! |
Ah, thank you. I will look into it soon. |
My website got this problem, too. But i dont know code. Please fix this soon. Thank you very much! |
This is a really tricky one. I'm not seeing anything in the theme that would cause this. The ad code has Do either of you have adsense code that I can use for testing to try to recreate the issue on my local testing site(s)? |
You check with this adsense code, can see it works well on version 1.3.1.
Width 1100 is automatically generated by the width of the content, and for some reason Adsense understands that content width = .content + .sidebar-primary (On chrome). Until adding fixed width to the .content as commented above, this problem has been fixed. That is a temporary solution for my official website, is using Mai theme. |
Hey @ighosts22 do you need to verify my domain to use that code or something? Sorry, not familiar with adsense, and putting that code in the header gives a 403 forbidden trying to load it. |
I found this https://stackoverflow.com/questions/26864860/is-google-adsense-available-for-localhost but does look like the domain would still need to be verified. I'm not sure how to troubleshoot/test this issue so I can see about a fix. |
For reference, this seems to be the issue... and it's not great. It seems AdSense just isn't capable of working with flexbox yet.
|
Setting a min-width isn't really feasible in a theme since the widths are all different depending on the layout. This may be something that needs to get dealt with on a per-site basis, sadly. |
When the width is less than 993px, the sidebar will disappear, which is no longer a problem, since there is no sidebar for overlapping ads. Can you solve this problem on a computer screen, larger than 993px, with the flexibility of an expert? :( Sadly if it was only for a small matter that I had to give up this great topic! Is there any hope to wait in the near future? Strange that it was so long since the last update, only me and another person raised this issue! It looks like most of the people who use Mai theme, do not contain Adsense ads in the site! :D |
Hello,
After upgrading to version 1.3.2.1, Adsense's responsive ads in the article have overflowed and overlapped to the right sidebar, in the browser chrome.
Firefox and IE are still good!
Is this a bug in the new version? Thanks very much!
The text was updated successfully, but these errors were encountered: