Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Menu Error Between Mobile and Computer #244

Open
lionking1193 opened this issue Sep 29, 2018 · 7 comments
Open

Duplicate Menu Error Between Mobile and Computer #244

lionking1193 opened this issue Sep 29, 2018 · 7 comments

Comments

@lionking1193
Copy link

Hello,

(Start New an issue)
When I look through google cache with HTML. My website duplicates menus between mobile and computer. I think it affects SEO. Can fix you it with a menu?

screenshot_1

Thanks

@JiveDig
Copy link
Collaborator

JiveDig commented Sep 29, 2018

We’ve have not seen any data showing it affects SEO.

Mai Theme’s mobile menu is extremely powerful in that you can use a completely separate menu just for mobile, and/or use widgets to add extra content to the menu as well.

Can you explain how it could be possible to have a mobile menu without actually having any extra markup?

If the site only has one menu it may be possible, but anything more and it would require extra HTML for the menu somewhere.

I’m open to ideas to improve though 👍

@lionking1193
Copy link
Author

lionking1193 commented Sep 29, 2018

Hello again,

Yes, I know, but you can see some websites using Genesis Framework with a child theme. It only works with a menu.

You can have an overview by visiting these sites:
https://pillowforpi.com/ https://sleepsoftly.com/
Thanks

@JiveDig
Copy link
Collaborator

JiveDig commented Sep 29, 2018

Can you explain what “it only works with a menu” means?

@lionking1193
Copy link
Author

lionking1193 commented Sep 29, 2018

These sites just work with a menu, this menu is used for Computer and Mobile.

https://pillowforpi.com/ https://sleepsoftly.com/

@JiveDig
Copy link
Collaborator

JiveDig commented Sep 29, 2018

What happens if you have more than one menu on desktop?

I get what you are going for, but the trade-off of the power and flexibility of Mai Theme’s menu is that you have a separate menu that is hidden. We have sites working this way that are ranking in the top 5 spots organically for dozens (hundreds?) of keywords. I don’t think it’s something we’re overly concerned with (right now) since there has been no sign of negative affects of doing it this way.

@lionking1193
Copy link
Author

I just want to ask you how to implement it. I don't care about other sites, I just want to look at my problem and want to solve it in the best direction. Okay thanks for your precious time.

@JiveDig
Copy link
Collaborator

JiveDig commented Sep 29, 2018

The only way to implement it that way is to unhook the function that outputs the hidden menu, so it never runs, and to use your own script to “move” or reuse the existing menu(s) in the mobile menu at smaller screen sizes.

That would be a nice improvement in Mai Theme for the times when the mobile menu widget area is not used. It’s just a little tricky to handle that way.

I’m going to leave this open as a feature request so I can take a look at this later on.

@JiveDig JiveDig reopened this Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants