Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow validation to fail during development #12883

Closed
colinduwe opened this issue Dec 14, 2018 · 3 comments · May be fixed by makbarGroup/gutenberg#45, monzerfoda/gutenberg#5 or monzerfoda/gutenberg#12
Closed

Allow validation to fail during development #12883

colinduwe opened this issue Dec 14, 2018 · 3 comments · May be fixed by makbarGroup/gutenberg#45, monzerfoda/gutenberg#5 or monzerfoda/gutenberg#12
Labels
[Feature] Block API API that allows to express the block paradigm.

Comments

@colinduwe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
@colinduwe
Copy link
Contributor Author

Is your feature request related to a problem? Please describe.
It would speed custom block development if the block rendered even if it failed validation.

Describe the solution you'd like
If DEBUG_SCRIPT is true and the block being developed has isDev prop set true the block is rendered as returned by .save(), perhaps with a exclamation point or some other indicator that validation failed so data loss may have happened.

@swissspidy swissspidy added [Feature] Block API API that allows to express the block paradigm. [Type] Build Tooling Issues or PRs related to build tooling Needs Technical Feedback Needs testing from a developer perspective. and removed [Type] Build Tooling Issues or PRs related to build tooling labels Dec 14, 2018
@youknowriad
Copy link
Contributor

While I agree that it's frustrating while developing, I'd still be against disabling it because it may cause actual bugs to go unnoticed.

Thinking we should close this issue for now.

@youknowriad youknowriad removed the Needs Technical Feedback Needs testing from a developer perspective. label Feb 8, 2019
@aduth
Copy link
Member

aduth commented May 31, 2019

Let's at least consolidate this to #7604.

@aduth aduth closed this as completed May 31, 2019
This was referenced Sep 16, 2021
Open
Open
@monzerfoda monzerfoda mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Block API API that allows to express the block paradigm.
Projects
None yet
Milestone
No milestone
4 participants
@youknowriad @swissspidy @aduth @colinduwe