Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All variables and Gherkin tests. #121

Closed
11 tasks done
Tracked by #97
zie1ony opened this issue Dec 12, 2022 · 0 comments · Fixed by #117
Closed
11 tasks done
Tracked by #97

All variables and Gherkin tests. #121

zie1ony opened this issue Dec 12, 2022 · 0 comments · Fixed by #117

Comments

@zie1ony
Copy link
Collaborator

zie1ony commented Dec 12, 2022 •
edited by kpob
Loading

  • Change variables names
    • GovenanceVariable -> BidEscrowVariable
    • Variable -> Variable
  • In BidEscrow use BidEscrow* variables and in the rest of votings use standard.
  • Add is_bidescrow in VotingConfiguration.rs
  • InformalQuorumRatio
  • FormalQuorumRatio
  • InformalVotingTime
  • FormalVotingTime
  • Use DefaultReputationSlash and slash when finish_voting->Formal->Internal.
  • VotingStartAfterJobWorkerSubmisson - add blocktime check in BidEscrow::vote
@zie1ony zie1ony mentioned this issue Dec 12, 2022
Open
25 tasks
@kpob kpob linked a pull request Dec 12, 2022 that will close this issue
Governance variables in bid escrow #117
Merged
@kpob kpob closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Governance variables in bid escrow make-software/dao-contracts
2 participants
@zie1ony @kpob