Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bevy 0.14 #124

Closed
shanecelis opened this issue Aug 17, 2024 · 5 comments · Fixed by #127
Closed

Support for bevy 0.14 #124

shanecelis opened this issue Aug 17, 2024 · 5 comments · Fixed by #127

Comments

@shanecelis
Copy link
Sponsor Contributor

I tried doing this myself. At first it didn't seem like it would be much work. However, once I got to the autogenerated code, I got lost. Is there any documentation or guidance for how you go about updating your bevy version? I'd be happy to attempt a PR.

@makspll
Copy link
Owner

makspll commented Aug 26, 2024

Hi, I will be looking at doing more work on this repo soon :)

I haven't checked the extent of changes necessary for this update, but on the happy path migrating code-gen just entails running the code gen scripts. If the minimum supported rust version has changed this will be more complicated especially since we now hook into the compiler directly (and we might require looking through the changes to the compiler + reconciling them with the code gen).

The good news is soon bevy will be supporting function/method reflection, which is going to reduce the need for code gen (probably within a release or two)

@makspll
Copy link
Owner

makspll commented Aug 26, 2024

Really appreciate the sponsor btw!

@shanecelis
Copy link
Sponsor Contributor Author

That would be great! I've got a branch that contains some of the easy bevy-0.14 grunt work. The last commit there can probably be dropped.

You're very welcome. I think this crate is a huge asset to the bevy community so THANK YOU!

@makspll
Copy link
Owner

makspll commented Sep 7, 2024

Just bumped bevy-console and looking at the bevy migration notes, recursive reflect type registration might cause some issues, i.e. we might have to register all the primitive types, I will begin migrating off of your branch @shanecelis and see if there's anything problematic :)

@makspll
Copy link
Owner

makspll commented Sep 7, 2024

I've just gotten 0.14 working on the linked PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants