Repeated simulation pausing/stepping misbehaves fix #589 #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
approved these changes
Feb 18, 2019
BMarchi
force-pushed
the
bmarchi/repeated_pause_play_step
branch
from
ddc36f9
to
d3f7b6c
Compare
BMarchi
force-pushed
the
bmarchi/repeated_pause_play_step
branch
from
d3f7b6c
to
104e045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignition sends a message using a non blocking call when Play/Pause/Step buttons are pressed, if we press those buttons quickly, we can send the same pause/play/step button more than once, which ends up in aborting the simulation. I don't consider this an issue from ignition, since those messages are not relevant to wait for a response, it's better to handle this minor issue from delphyne rather than making a pr to ignition that could have some impact in performance for using a blocking call.