Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds scan build to Github Actions #723

Merged
merged 7 commits into from
Dec 1, 2020

Conversation

agalbachicar
Copy link
Collaborator

@agalbachicar agalbachicar commented Nov 17, 2020

@agalbachicar agalbachicar force-pushed the agalbachicar/#136_add_scan_build branch from 217c91d to 3aa1dab Compare November 25, 2020 20:29
@agalbachicar
Copy link
Collaborator Author

It's ready for review @francocipollone . Last build scan-build test was green and I've just triggered gcc because of the flaky ign-publisher test.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agalbachicar
Copy link
Collaborator Author

I'm going in with this PR even though ign-publisher-syste is not passing with gcc (only). I'll raise the priority of the issue tracking it to solve it asap because it just delays reviews.

@agalbachicar agalbachicar merged commit 7a44dac into master Dec 1, 2020
@agalbachicar agalbachicar deleted the agalbachicar/#136_add_scan_build branch December 1, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants