From c0cf397d412cc91a69a1cb6d3a457810e8e7933d Mon Sep 17 00:00:00 2001
From: Franco Cipollone <53065142+francocipollone@users.noreply.github.com>
Date: Wed, 4 Aug 2021 09:03:15 -0300
Subject: [PATCH] Deprecates ign_gui0-based visualizer. (#423)
---
.github/dependencies.repos | 4 -
delphyne_gui/CMakeLists.txt | 5 +-
delphyne_gui/package.xml | 2 -
delphyne_gui/tools/maliput_viewer0.sh | 36 -
delphyne_gui/visualizer/CMakeLists.txt | 175 +----
.../visualizer/display_plugins/CMakeLists.txt | 62 --
.../display_plugins/agent_info_display0.cc | 256 -------
.../display_plugins/agent_info_display0.hh | 69 --
.../display_plugins/origin_display0.cc | 79 --
.../display_plugins/origin_display0.hh | 34 -
delphyne_gui/visualizer/icons/pause.svg | 85 ---
delphyne_gui/visualizer/icons/play.svg | 76 --
delphyne_gui/visualizer/icons/rewind.svg | 88 ---
delphyne_gui/visualizer/icons/step.svg | 83 --
.../visualizer/layer_selection_widget.cc | 269 -------
.../visualizer/layer_selection_widget.hh | 149 ----
.../visualizer/layout_for_playback.config | 138 ----
.../visualizer/layout_maliput_viewer.config | 20 -
.../visualizer/layout_with_render_only.config | 27 -
.../visualizer/layout_with_teleop.config | 178 -----
.../visualizer/maliput_viewer_widget.cc | 332 --------
.../visualizer/maliput_viewer_widget.hh | 199 -----
delphyne_gui/visualizer/orbit_view_control.cc | 149 ----
delphyne_gui/visualizer/orbit_view_control.hh | 115 ---
delphyne_gui/visualizer/playback.qrc | 8 -
delphyne_gui/visualizer/playback_widget.cc | 247 ------
delphyne_gui/visualizer/playback_widget.hh | 153 ----
.../visualizer/render_maliput_widget.cc | 624 ---------------
.../visualizer/render_maliput_widget.hh | 272 -------
delphyne_gui/visualizer/render_widget.cc | 711 ------------------
delphyne_gui/visualizer/render_widget.hh | 254 -------
.../visualizer/rules_visualizer_widget.cc | 122 ---
.../visualizer/rules_visualizer_widget.hh | 86 ---
delphyne_gui/visualizer/teleop_widget.cc | 253 -------
delphyne_gui/visualizer/teleop_widget.hh | 117 ---
delphyne_gui/visualizer/visualizer0.cc | 169 -----
36 files changed, 2 insertions(+), 5644 deletions(-)
delete mode 100755 delphyne_gui/tools/maliput_viewer0.sh
delete mode 100644 delphyne_gui/visualizer/display_plugins/agent_info_display0.cc
delete mode 100644 delphyne_gui/visualizer/display_plugins/agent_info_display0.hh
delete mode 100644 delphyne_gui/visualizer/display_plugins/origin_display0.cc
delete mode 100644 delphyne_gui/visualizer/display_plugins/origin_display0.hh
delete mode 100644 delphyne_gui/visualizer/icons/pause.svg
delete mode 100644 delphyne_gui/visualizer/icons/play.svg
delete mode 100644 delphyne_gui/visualizer/icons/rewind.svg
delete mode 100644 delphyne_gui/visualizer/icons/step.svg
delete mode 100644 delphyne_gui/visualizer/layer_selection_widget.cc
delete mode 100644 delphyne_gui/visualizer/layer_selection_widget.hh
delete mode 100644 delphyne_gui/visualizer/layout_for_playback.config
delete mode 100644 delphyne_gui/visualizer/layout_maliput_viewer.config
delete mode 100644 delphyne_gui/visualizer/layout_with_render_only.config
delete mode 100644 delphyne_gui/visualizer/layout_with_teleop.config
delete mode 100644 delphyne_gui/visualizer/maliput_viewer_widget.cc
delete mode 100644 delphyne_gui/visualizer/maliput_viewer_widget.hh
delete mode 100644 delphyne_gui/visualizer/orbit_view_control.cc
delete mode 100644 delphyne_gui/visualizer/orbit_view_control.hh
delete mode 100644 delphyne_gui/visualizer/playback.qrc
delete mode 100644 delphyne_gui/visualizer/playback_widget.cc
delete mode 100644 delphyne_gui/visualizer/playback_widget.hh
delete mode 100644 delphyne_gui/visualizer/render_maliput_widget.cc
delete mode 100644 delphyne_gui/visualizer/render_maliput_widget.hh
delete mode 100644 delphyne_gui/visualizer/render_widget.cc
delete mode 100644 delphyne_gui/visualizer/render_widget.hh
delete mode 100644 delphyne_gui/visualizer/rules_visualizer_widget.cc
delete mode 100644 delphyne_gui/visualizer/rules_visualizer_widget.hh
delete mode 100644 delphyne_gui/visualizer/teleop_widget.cc
delete mode 100644 delphyne_gui/visualizer/teleop_widget.hh
delete mode 100644 delphyne_gui/visualizer/visualizer0.cc
diff --git a/.github/dependencies.repos b/.github/dependencies.repos
index 5f264e2b..632083d3 100644
--- a/.github/dependencies.repos
+++ b/.github/dependencies.repos
@@ -3,10 +3,6 @@ repositories:
type: git
url: https://github.com/ToyotaResearchInstitute/ament_cmake_doxygen
version: main
- ign-gui0:
- type: git
- url: https://github.com/scpeters/ign-gui
- version: gui0_citadel
pybind11:
type: git
url: https://github.com/RobotLocomotion/pybind11.git
diff --git a/delphyne_gui/CMakeLists.txt b/delphyne_gui/CMakeLists.txt
index 42e85d13..ad74e3af 100644
--- a/delphyne_gui/CMakeLists.txt
+++ b/delphyne_gui/CMakeLists.txt
@@ -51,7 +51,6 @@ find_package(ament_cmake REQUIRED)
find_package(ignition-common3 REQUIRED)
find_package(ignition-math6 REQUIRED)
find_package(ignition-msgs5 REQUIRED)
-find_package(ignition-gui0 0.1 REQUIRED)
find_package(ignition-gui3 REQUIRED)
find_package(ignition-rendering3 REQUIRED)
find_package(ignition-transport8 REQUIRED)
@@ -110,9 +109,7 @@ add_subdirectory(python)
ament_environment_hooks(setup.sh.in)
#################################################
-# Installs maliput_viewer0.sh and maliput_viewer2.sh as a shortcut to run both
-# visualizers.
-install (PROGRAMS tools/maliput_viewer0.sh DESTINATION bin)
+# Installs maliput_viewer2.sh as a shortcut to run the visualizer.
install (PROGRAMS tools/maliput_viewer2.sh DESTINATION bin)
ament_package()
diff --git a/delphyne_gui/package.xml b/delphyne_gui/package.xml
index 93a4b562..d897c588 100644
--- a/delphyne_gui/package.xml
+++ b/delphyne_gui/package.xml
@@ -17,7 +17,6 @@
ignition-msgs5
ignition-transport8
ignition-rendering3
- ignition-gui0
ignition-gui3
delphyne
@@ -28,7 +27,6 @@
ignition-msgs5
ignition-transport8
ignition-rendering3
- ignition-gui0
ignition-gui3
delphyne
diff --git a/delphyne_gui/tools/maliput_viewer0.sh b/delphyne_gui/tools/maliput_viewer0.sh
deleted file mode 100755
index eabc3d58..00000000
--- a/delphyne_gui/tools/maliput_viewer0.sh
+++ /dev/null
@@ -1,36 +0,0 @@
-#!/bin/bash
-
-# Copyright 2018 Open Source Robotics Foundation
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions are met:
-#
-# 1. Redistributions of source code must retain the above copyright notice,
-# this list of conditions and the following disclaimer.
-#
-# 2. Redistributions in binary form must reproduce the above copyright notice,
-# this list of conditions and the following disclaimer in the documentation
-# and/or other materials provided with the distribution.
-#
-# 3. Neither the name of the copyright holder nor the names of its contributors
-# may be used to endorse or promote products derived from this software
-# without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
-# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-# POSSIBILITY OF SUCH DAMAGE.
-
-# Shortcut to run `visualizer0` with the layout for the MaliputViewer.
-# CLI arguments will be forwarded to `visualizer`.
-# It is assumed that the environment is already configured.
-visualizer0 \
- --layout=${DELPHYNE_GUI_RESOURCE_ROOT}/layouts/layout_maliput_viewer.config \
- "$@"
diff --git a/delphyne_gui/visualizer/CMakeLists.txt b/delphyne_gui/visualizer/CMakeLists.txt
index fdad9f45..78a3b1a0 100644
--- a/delphyne_gui/visualizer/CMakeLists.txt
+++ b/delphyne_gui/visualizer/CMakeLists.txt
@@ -25,176 +25,7 @@ install(
ARCHIVE DESTINATION lib
)
-#-------------------------------------------------------------------------------
-# MaliputViewerWidget GUI plugin.
-QT5_WRAP_CPP(MaliputViewerWidget_MOC maliput_viewer_widget.hh)
-QT5_WRAP_CPP(LayerSelectionWidget_MOC layer_selection_widget.hh)
-QT5_WRAP_CPP(RenderMaliputWidget_MOC render_maliput_widget.hh)
-QT5_WRAP_CPP(RulesVisualizerWidget_MOC rules_visualizer_widget.hh)
-
-add_library(maliput_viewer_widget
- ${CMAKE_CURRENT_SOURCE_DIR}/layer_selection_widget.cc
- ${CMAKE_CURRENT_SOURCE_DIR}/maliput_viewer_widget.cc
- ${CMAKE_CURRENT_SOURCE_DIR}/render_maliput_widget.cc
- ${CMAKE_CURRENT_SOURCE_DIR}/rules_visualizer_widget.cc
- orbit_view_control.cc
- render_maliput_widget.cc
- ${MaliputViewerWidget_MOC}
- ${LayerSelectionWidget_MOC}
- ${RenderMaliputWidget_MOC}
- ${RulesVisualizerWidget_MOC}
-)
-add_library(delphyne_gui::maliput_viewer_widget ALIAS maliput_viewer_widget)
-set_target_properties(maliput_viewer_widget
- PROPERTIES
- OUTPUT_NAME delphyne_gui_maliput_viewer_widget
-)
-
-target_link_libraries(maliput_viewer_widget
- ${drake_LIBRARIES}
- delphyne_gui::arrow_mesh
- delphyne_gui::global_attributes
- delphyne_gui::maliput_viewer_model
- delphyne_gui::selector
- delphyne_gui::traffic_light_manager
- ignition-common3::ignition-common3
- ignition-gui0::ignition-gui0
- ignition-msgs5::ignition-msgs5
- ignition-rendering3::ignition-rendering3
- ${Qt5Core_LIBRARIES}
- ${Qt5Widgets_LIBRARIES}
-)
-
-install(
- TARGETS maliput_viewer_widget
- EXPORT ${PROJECT_NAME}-targets
- RUNTIME DESTINATION bin
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
-)
-
-# RenderWidget GUI plugin.
-QT5_WRAP_CPP(RenderWidget_MOC render_widget.hh)
-
-add_library(render_widget
- ${CMAKE_CURRENT_SOURCE_DIR}/render_widget.cc
- orbit_view_control.cc
- ${RenderWidget_MOC}
-)
-add_library(delphyne_gui::render_widget ALIAS render_widget)
-set_target_properties(render_widget
- PROPERTIES
- OUTPUT_NAME delphyne_gui_render_widget
-)
-
-target_link_libraries(render_widget
- ignition-common3::ignition-common3
- ignition-gui0::ignition-gui0
- ignition-msgs5::ignition-msgs5
- ignition-rendering3::ignition-rendering3
- ignition-transport8::ignition-transport8
- ${Qt5Core_LIBRARIES}
- ${Qt5Widgets_LIBRARIES}
- delphyne::protobuf_messages
- delphyne::utility
-)
-
-install(
- TARGETS render_widget
- EXPORT ${PROJECT_NAME}-targets
- RUNTIME DESTINATION bin
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
-)
-
-# TeleopWidget GUI plugin.
-QT5_WRAP_CPP(TeleopWidget_MOC teleop_widget.hh)
-
-add_library(teleop_widget
- ${CMAKE_CURRENT_SOURCE_DIR}/teleop_widget.cc
- ${TeleopWidget_MOC}
-)
-add_library(delphyne_gui::teleop_widget ALIAS teleop_widget)
-set_target_properties(teleop_widget
- PROPERTIES
- OUTPUT_NAME delphyne_gui_teleop_widget
-)
-
-target_link_libraries(teleop_widget
- ignition-common3::ignition-common3
- ignition-gui0::ignition-gui0
- ignition-msgs5::ignition-msgs5
- ignition-transport8::ignition-transport8
- ${Qt5Core_LIBRARIES}
- ${Qt5Widgets_LIBRARIES}
- delphyne::protobuf_messages
-)
-
-install(
- TARGETS teleop_widget
- EXPORT ${PROJECT_NAME}-targets
- RUNTIME DESTINATION bin
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
-)
-
-# PlaybackWidget GUI plugin.
-QT5_WRAP_CPP(PlaybackWidget_MOC playback_widget.hh)
-QT5_ADD_RESOURCES(PlaybackWidget_resources_RCC playback.qrc)
-
-add_library(playback_widget
- ${CMAKE_CURRENT_SOURCE_DIR}/playback_widget.cc
- ${PlaybackWidget_MOC}
- ${PlaybackWidget_resources_RCC}
-)
-add_library(delphyne_gui::playback_widget ALIAS playback_widget)
-set_target_properties(playback_widget
- PROPERTIES
- OUTPUT_NAME delphyne_gui_playback_widget
-)
-
-target_link_libraries(playback_widget
- ignition-common3::ignition-common3
- ignition-gui0::ignition-gui0
- ignition-msgs5::ignition-msgs5
- ignition-transport8::ignition-transport8
- ${Qt5Core_LIBRARIES}
- ${Qt5Widgets_LIBRARIES}
- delphyne::protobuf_messages
- delphyne::public_headers
-)
-
-install(
- TARGETS playback_widget
- EXPORT ${PROJECT_NAME}-targets
- RUNTIME DESTINATION bin
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
-)
-
-#-------------------------------------------------------------------------------
-
-# Visualizer with ign-gui0
-add_executable(visualizer0
- visualizer0.cc
-)
-
-target_link_libraries(visualizer0
- ignition-common3::ignition-common3
- ignition-gui0::ignition-gui0
- ${Qt5Core_LIBRARIES}
- ${Qt5Widgets_LIBRARIES}
- delphyne::utility
- global_attributes
-)
-
-install(
- TARGETS visualizer0
- EXPORT ${PROJECT_NAME}-targets
- DESTINATION bin
-)
-
-# Visualizer with ign-gui3
+# Visualizer
add_executable(visualizer
visualizer2.cc
)
@@ -217,10 +48,6 @@ install(
# Install .config files.
install(
FILES
- layout_with_render_only.config
- layout_with_teleop.config
- layout_maliput_viewer.config
- layout_for_playback.config
layout2_for_playback.config
layout2_maliput_viewer.config
layout2_with_teleop.config
diff --git a/delphyne_gui/visualizer/display_plugins/CMakeLists.txt b/delphyne_gui/visualizer/display_plugins/CMakeLists.txt
index cf0c8aa4..48a72abb 100644
--- a/delphyne_gui/visualizer/display_plugins/CMakeLists.txt
+++ b/delphyne_gui/visualizer/display_plugins/CMakeLists.txt
@@ -3,68 +3,6 @@ include_directories(
${CMAKE_SOURCE_DIR}
)
-# Origin display plugin.
-QT5_WRAP_CPP(OriginDisplay0_MOC origin_display0.hh)
-
-add_library(origin_display0
- ${CMAKE_CURRENT_SOURCE_DIR}/origin_display0.cc
- ${OriginDisplay0_MOC}
-)
-add_library(delphyne_gui::origin_display0 ALIAS origin_display0)
-set_target_properties(origin_display0
- PROPERTIES
- OUTPUT_NAME delphyne_gui_origin_display0
-)
-
-target_link_libraries(origin_display0
- ignition-common3::ignition-common3
- ignition-gui0::ignition-gui0
- ignition-msgs5::ignition-msgs5
- ignition-transport8::ignition-transport8
- ${Qt5Core_LIBRARIES}
- ${Qt5Widgets_LIBRARIES}
- delphyne::protobuf_messages
-)
-
-install(
- TARGETS origin_display0
- EXPORT ${PROJECT_NAME}-targets
- RUNTIME DESTINATION bin
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
-)
-
-# Agent Info display plugin.
-QT5_WRAP_CPP(AgentInfoDisplay0_MOC agent_info_display0.hh)
-
-add_library(agent_info_display0
- ${CMAKE_CURRENT_SOURCE_DIR}/agent_info_display0.cc
- ${AgentInfoDisplay0_MOC}
-)
-add_library(delphyne_gui::agent_info_display0 ALIAS agent_info_display0)
-set_target_properties(agent_info_display0
- PROPERTIES
- OUTPUT_NAME delphyne_gui_agent_info_display0
-)
-
-target_link_libraries(agent_info_display0
- ignition-common3::ignition-common3
- ignition-gui0::ignition-gui0
- ignition-msgs5::ignition-msgs5
- ignition-transport8::ignition-transport8
- ${Qt5Core_LIBRARIES}
- ${Qt5Widgets_LIBRARIES}
- delphyne::protobuf_messages
-)
-
-install(
- TARGETS agent_info_display0
- EXPORT ${PROJECT_NAME}-targets
- RUNTIME DESTINATION bin
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
-)
-
#-------------------------------------------------------------------------------
# AgentInfo display (ign-gui 3)
QT5_WRAP_CPP(AgentInfoDisplay_MOC agent_info_display.hh)
diff --git a/delphyne_gui/visualizer/display_plugins/agent_info_display0.cc b/delphyne_gui/visualizer/display_plugins/agent_info_display0.cc
deleted file mode 100644
index 5e077d9c..00000000
--- a/delphyne_gui/visualizer/display_plugins/agent_info_display0.cc
+++ /dev/null
@@ -1,256 +0,0 @@
-// Copyright 2018 Toyota Research Institute
-
-#include
-#include