Remove culling property #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a simplified form of /get_scene that avoids the need for a second service call.
The Scene3D plugin from ign-gui2 will make a service request to get information about a scene, with the service name configurable via xml. It expects different data types than delphyne though, so some more changes are needed.
ignition-rendering2 did not incoroporate the culling to materials and it is causing Scene3D plugin not to properly decode the URI and convert it into a file path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #332
Goes on top of #353
Removes the parsing of
?culling=parameter inRenderWidget. It is not used at the moment because igntion-rendering2 does not support it and it prevents Scene3D plugin to work properly. See #332 (comment) for a picture of the visuals.Should be reviewed from d632463 on.
Goes hand in hand with maliput/delphyne#753