Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Grid3D display plugin. #366

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Conversation

agalbachicar
Copy link
Collaborator

Part of #332

Removes the Grid3D plugin from the Display plugin (it does not exist in ign-gui3) and keeps the same configuration as before.

grid

Note: we can see the plugin listed to the side which is different from before.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: we can see the plugin listed to the side which is different from before.

Probably we could add something like:

    <property type="bool" key="showTitleBar">false</property>
    <property type="bool" key="showCollapseButton">false</property>
    <property type="bool" key="showDockButton">false</property>
    <property type="bool" key="showCloseButton">false</property>

to avoid seeing it in the right panel if needed

@agalbachicar
Copy link
Collaborator Author

Probably we could add something like:

    <property type="bool" key="showTitleBar">false</property>
    <property type="bool" key="showCollapseButton">false</property>
    <property type="bool" key="showDockButton">false</property>
    <property type="bool" key="showCloseButton">false</property>

to avoid seeing it in the right panel if needed


I checked the code before submitting this PR but it does not parse those properties. I also tried to make sure I was correct and indeed, it remained visible.

@francocipollone
Copy link
Collaborator

francocipollone commented Mar 26, 2021

Probably we could add something like:

    <property type="bool" key="showTitleBar">false</property>
    <property type="bool" key="showCollapseButton">false</property>
    <property type="bool" key="showDockButton">false</property>
    <property type="bool" key="showCloseButton">false</property>

to avoid seeing it in the right panel if needed

I checked the code before submitting this PR but it does not parse those properties. I also tried to make sure I was correct and indeed, it remained visible.

Here are other general properties you can add to "every widget".

Probably you missed the <ignition-gui> node:

<plugin filename="Grid3D">
  <ignition-gui>
    <property type="bool" key="showTitleBar">false</property>
    <property type="bool" key="showCollapseButton">false</property>
    <property type="bool" key="showDockButton">false</property>
    <property type="bool" key="showCloseButton">false</property>
  </ignition-gui>
  <engine>ogre</engine>
  <scene>scene</scene>
  <insert>
    <cell_count>250</cell_count>
    <vertical_cell_count>0</vertical_cell_count>
    <cell_length>1.000000</cell_length>
    <pose>0 0 0 0 0 0</pose>
    <color>0.7 0.7 0.7 0.3</color>
  </insert>
</plugin>

I tried it in your branch and it works, however, a white space is left so it isn't entirely useful because if you have a plugin below you see an empty space that you can not reduce in the middle.

image

So I would say go and merge it as it is.

@agalbachicar
Copy link
Collaborator Author

Oh I missed the ignition-gui -- thanks!

@agalbachicar agalbachicar merged commit 76077d6 into master Mar 26, 2021
@agalbachicar agalbachicar deleted the agalbachicar/#332_add_grid_plugin branch March 26, 2021 17:52
@agalbachicar
Copy link
Collaborator Author

@scpeters : @francocipollone noticed here that when hiding the plugin the pane is still there (I believe it is a QML Pane, please correct me if I'm wrong) as a vertical white space. Do you think it could be a bug or is it a configuration issue on our side?

@francocipollone
Copy link
Collaborator

francocipollone commented Mar 26, 2021

@scpeters : @francocipollone noticed here that when hiding the plugin the pane is still there (I believe it is a QML Pane, please correct me if I'm wrong) as a vertical white space. Do you think it could be a bug or is it a configuration issue on our side?

Technically we were hiding only the dock, close, etc buttons, and the title bar, so it makes sense that the panel itself isn't hidden. I would say that probably there may be another property to in fact hide the panel.(to reach at start the same status it has when you hit the close button )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants