MaliputViewer: Adds Traffic Lights. #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalbachicar
previously approved these changes
May 12, 2021
| @@ -356,7 +387,7 @@ add_library(delphyne_gui::TopicsStats ALIAS TopicsStats) | |||
| set_target_properties(TopicsStats | |||
| PROPERTIES | |||
| # TODO(#379): Use TopicsStats instead after removing ign-gui0 from workspace. | |||
There was a problem hiding this comment.
Given that you are using TopicStats, shouldn't you remove the TODO above?
There was a problem hiding this comment.
Yeah, my mistake, at first I didn't want to include this in this PR and then I forgot to remove the todo statement. :D
Done.
francocipollone
force-pushed
the
francocipollone/traffic_lights
branch
from
d3e1960
to
a8180cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 10 of #377 (comment)
It goes on top of #398
--> d3e1960 should be reviewed
traffic_light.mp4