Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds test_utilities no matter BUILD_TESTING flag. #612

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

francocipollone
Copy link
Collaborator

🦟 Bug fix

Summary

After making maliput::test_utilities agnostic of gtest there is no need to keep this guard
to avoid building this if not necessary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #612 (456f053) into main (5746a41) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   85.69%   85.70%           
=======================================
  Files         232      232           
  Lines       10690    10690           
=======================================
+ Hits         9161     9162    +1     
+ Misses       1529     1528    -1     

see 1 file with indirect coverage changes

@francocipollone francocipollone merged commit 5e8d907 into main Nov 3, 2023
6 checks passed
@francocipollone francocipollone deleted the francocipollone/build_test_utilities branch November 3, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant