Use maliput::test_utilities and try same branch name in actions #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements some behavior from our Jenkins CI that attemps to checkout a branch of the same name in all dependency packages. This requires setting `fetch-depth: 0` in the actions/checkout steps and installing git 2.18+ before those checkout steps. For 18.04, the git-core ppa is used; this will not be needed on 20.04.
agalbachicar
approved these changes
Nov 24, 2020
|
re-running the gcc job here to test the latest changes in maliput/maliput#368 |
it passes; I think we are clear to start merging once all the PR's are approved |
scpeters
deleted the
scpeters/shorten_maliput_test_utilities_target_name
branch
This was referenced Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to maliput/maliput#368 (use updated target name
maliput::test_utilities) and based on maliput/maliput_dragway#18. The workflow fails when compiled against themasterbranch ofmaliput, so I've also added support for checking out matching branch names of package dependencies in GitHub actions workflows, as discussed in maliput/maliput_infrastructure#136 (comment). The code linked in that comment is added to thetry_vcs_checkoutscript, and there are two additional changes needed:Set
fetch-depth: 0inactions/checkoutsteps for dependencies so that the fell git history is checked out (only needed for dependencies, not for checking out its own code since that is already on the proper branch).Ensure that git 2.18+ is installed on the system before the
actions/checkoutsteps are run. On 18.04, the standard version ofgitis 2.17, so we use thegit-coreppa to install a newer version (currently 2.29). In anticipation of 20.04, which has git 2.25, I've moved thesetup-rosstep to the beginning, so that it alone can be used to installgitwhen we switch to 20.04, and the ppa step can be removed.