add executable to the shell trait and implement it #224
Conversation
| @@ -244,9 +263,12 @@ impl Shell for PowerShell { | |||
| fn extension(&self) -> &str { | |||
| "ps1" | |||
| } | |||
| fn executable(&self) -> &str { | |||
| "powershell" | |||
There was a problem hiding this comment.
pwsh[.exe] is the executable file name of PowerShell [Core] (v6+), the cross-platform edition of PowerShell built on .NET Core / .NET 5+; by contrast, powershell.exe is the executable name of the legacy Windows PowerShell edition (v5.1-), built on the Windows-only .NET Framework (v4.8-)
There was a problem hiding this comment.
Should we use pwsh? cc @baszalmstra
| @@ -244,9 +263,12 @@ impl Shell for PowerShell { | |||
| fn extension(&self) -> &str { | |||
| "ps1" | |||
| } | |||
| fn executable(&self) -> &str { | |||
| "powershell" | |||
There was a problem hiding this comment.
Should we use pwsh? cc @baszalmstra
|
The other option would be that inside the |
|
https://github.com/harryfei/which-rs something like this |
|
what does micromamba do? |
|
i don't think we have soemthing like thsi for micromamba. We'd use whatever the user supplies (or parent process) for the shell. For initialization we iterate through |
Add
executableso it can be used to find the command that needs to be run.