Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date_and_time does not work with pre-epoch timestamps #1828

Open
vasil-pashov opened this issue Sep 11, 2024 · 0 comments · May be fixed by #1799
Open

date_and_time does not work with pre-epoch timestamps #1828

vasil-pashov opened this issue Sep 11, 2024 · 0 comments · May be fixed by #1799
Assignees
@vasil-pashov
Labels
bug Something isn't working

Comments

@vasil-pashov
Copy link
Collaborator

Describe the bug

date_and_time uses gmtime which does not work with pre-epoch dates in that case gmtime returns nullptr.

Steps/Code to Reproduce

N/A

Expected Results

Make it so that it works with pre-epoch dates or throw reasonable exception.

OS, Python Version and ArcticDB Version

Python: 3.10.11 (tags/v3.10.11:7d4cc5a, Apr 5 2023, 00:38:17) [MSC v.1929 64 bit (AMD64)]
OS: Windows-10-10.0.22631-SP0
ArcticDB: 4.5.0

Backend storage used

No response

Additional Context

No response
@vasil-pashov vasil-pashov added the bug Something isn't working label Sep 11, 2024
@vasil-pashov vasil-pashov self-assigned this Sep 11, 2024
@vasil-pashov vasil-pashov linked a pull request Sep 11, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vasil-pashov vasil-pashov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More sort and finalize fixes man-group/ArcticDB
1 participant
@vasil-pashov