Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RLPx Flow Control #408

Closed
germsvel opened this issue Sep 6, 2018 · 1 comment
Closed

Implement RLPx Flow Control #408

germsvel opened this issue Sep 6, 2018 · 1 comment
Labels
devp2p priority: low

Comments

@germsvel
Copy link
Contributor

germsvel commented Sep 6, 2018

RLPx specifies the implementation for flow control.

There is a note in there, however, that states the following:

Note: The initial version of RLPx will set a static window-size of 8KB; fair queueing and flow control (DeltaUpdate packet) will not be implemented.

So it is uncertain whether or not that needs to be implemented on first pass. A quick looking at parity, however, makes it seem that it does implement the flow control. See, for example, the mention of flow_params in net/status.rs.
@germsvel germsvel added the devp2p label Sep 6, 2018
This was referenced Sep 6, 2018
Open
Open
@hayesgm
Copy link
Contributor

hayesgm commented Dec 1, 2018

This has been removed from the RLPx specification.

@hayesgm hayesgm closed this as completed Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devp2p priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hayesgm @germsvel