Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep record of known peers #99

Open
germsvel opened this issue May 23, 2018 · 3 comments
Open

Keep record of known peers #99

germsvel opened this issue May 23, 2018 · 3 comments

Comments

@germsvel
Copy link
Contributor

germsvel commented May 23, 2018

When dealing with the Encrypted Handshake, our node can establish a connection with a known peer; that is, a node that we've connected to before. In order to be able to do that, we need to keep a session token.

From the Encrypted Handshake link above,

There are two kinds of connections which can be established. A node can connect to a known peer, or a node can connect to a new peer. A known peer is one which has previously been connected to and from which a corresponding session token is available for authenticating the requested connection.

@hayesgm
Copy link
Contributor

hayesgm commented Nov 3, 2018

I thought like I read somewhere that the other P2P clients (Geth/Parity) do not use this feature. Do we know the status of this session token usage in other implementations?

@germsvel
Copy link
Contributor Author

germsvel commented Nov 5, 2018

I do not know the status of that in other implementations. I just assumed they were using those tokens but haven't checked.

@InoMurko
Copy link
Member

InoMurko commented Dec 3, 2018

I think this is relevant to #639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants