Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding XP Gains to Battlegrounds (Warsong Gulch) #197

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

i-am-fyre
Copy link
Contributor

@i-am-fyre i-am-fyre commented Aug 27, 2024

This PR provides the server with the functionality to offer XP as a reward in battlegrounds and provides the framework for other battlegrounds to be included.
This PR focuses on Warsong Gulch only. Three ways to earn XP:

  1. Flag Capture (Pictured below as 1, 2, 3)
  2. Remaining Flags at the end of the match. (Pictured below as 4, 5, 6 -- in this example, it was a 3-0 win for Horde, so 3 remaining flags.)
  3. Win (Pictured below as 7)
    XP Gain Ingame

Values for XP are an approximation and NOT Blizzlike. Using era appropriate videos, we extracted XP gains at different levels. The formula utilized in this PR does not match the values exactly, but does scale very closely.
XP vs Level

Thank you to REGNURZA on Discord for identifying the lack of XP provided during battlegrounds and researching videos for XP gains!
Thank you to Neddings on Discord for also researching videos!
Thank you to Xenocide21 on Discord for help with upscaling videos/images!


This change is Reviewable

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@billy1arm billy1arm merged commit f89125c into mangostwo:master Aug 27, 2024
6 checks passed
@billy1arm
Copy link
Member

@i-am-fyre would this be valid for any other cores?

@i-am-fyre
Copy link
Contributor Author

@billy1arm XP gains from battlegrounds was implemented in 3.2.0 (https://wowpedia.fandom.com/wiki/Patch_3.2.0).

So it should be okay to port to M3+.
If we wanted to port the functionality to M0/M1 it should go behind a config.

@i-am-fyre i-am-fyre deleted the wsg-xp branch September 6, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants