Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Container Registry helper for docker credentials using hamilton #140

Closed
simongottschlag opened this issue Jan 23, 2022 · 1 comment
Labels
enhancement New feature or request package/auth

Comments

@simongottschlag
Copy link
Contributor

Hi!

I am currently trying to get cosign to work with Azure Container Registry: sigstore/cosign#1350

It is using the following project to get the token for ACR: https://github.com/chrismellard/docker-credential-acr-env

I would like to include a similar helper in hamilton that will be using hamilton instead of autorest.

@simongottschlag
Copy link
Contributor Author

As a reference I've started the discussion in go-containerregistry to move them to hamilton and they seem to like the idea: google/go-containerregistry#1263

I think I'll rewrite the PR to not be a helper based on the docker interface but instead be a plain Exchange() function that takes an authorizer.

@manicminer any thoughts or ideas? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/auth
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants