Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CutViewerView communicates with SliceViewer(Presenter) #38102

Open
robertapplin opened this issue Sep 30, 2024 · 0 comments
Open

CutViewerView communicates with SliceViewer(Presenter) #38102

robertapplin opened this issue Sep 30, 2024 · 0 comments
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Comments

@robertapplin
Copy link
Contributor

robertapplin commented Sep 30, 2024

Describe the outcome that is desired.
The CutViewerView class is passed a SliceViewer(Presenter) object in its constructor. This is a problem because the CutViewerView should only communicate with the CutViewerPresenter so that it is not dependent on a second presenter.

Ideally, the presenters are the medium through which the View and Model should communicate with other objects. So the CutViewerView should communicate with the CutViewerPresenter, and then the CutViewerPresenter is allowed to communicate with the SliceViewer(Presenter) object.

Describe any solutions you are considering
The CutViewerView should not communicate directly with the SliceViewer(Presenter) class. It should instead communicate with the CutViewerPresenter, and then the CutViewerPresenter can communicate with the SliceViewer(Presenter).

I would recommend creating a subscribe_presenter method on the CutViewerView so that the CutViewerPresenter can be notified when an event happens.

Another bug bear of mine is the name of the SliceViewer class. Its not clear if it is a Presenter from the name. Optional bonus to rename this class!

Acceptance Criteria

  • CutViewerView no longer communicates directly with the SliceViewer(Presenter)
  • Optionally SliceViewer class is renamed to SliceViewerPresenter
@robertapplin robertapplin added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Sep 30, 2024
@robertapplin robertapplin changed the title CutViewerView communicate with SliceViewer(Presenter) CutViewerView communicates with SliceViewer(Presenter) Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: No status
Development

No branches or pull requests

1 participant