Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Build Logs to a File for the Jenkins Warnings Plugin #38153

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cailafinn
Copy link
Contributor

@cailafinn cailafinn commented Oct 4, 2024

Description of work

Summary of work

Added a file output in the same style as the ctest log for the build log.

Once this is merged, the configurations for the 3 PR OSs need to be changed to check this log when the Warnings plugin is run.

Fixes #38148

Further detail of work

To test:

  1. Check the build artefacts, there should be a .log file associated with each OS containing the log from the build step.

This does not require release notes because it is not a user-facing change.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn added DevOps Issues and pull requests related to DevOps Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) DevOps Issues and pull requests related to DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds Are Marked as Unstable When Flaky Tests Fail Once Then Pass
1 participant