Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package builds on main have version 0.0.0 #1388

Closed
samtygier-stfc opened this issue Mar 31, 2022 · 3 comments · Fixed by #1389
Closed

Package builds on main have version 0.0.0 #1388

samtygier-stfc opened this issue Mar 31, 2022 · 3 comments · Fixed by #1389

Comments

@samtygier-stfc
Copy link
Collaborator

samtygier-stfc commented Mar 31, 2022

Summary

https://anaconda.org/mantid/mantidimaging/files is showing a linux-64/mantidimaging-0.0.0-py38_1.tar.bz2 package built on 2022-03-29 and no other recent unstable builds. So probably the version number is not being set correctly in the builds from main.

After this mornings merge, the previous 0.0.0 package is gone and there is a new one with the date today.

Steps To Reproduce

Expected Behaviour

Current Behaviour

Context

Failure Logs

From the Actions build log

Extracting conda package attributes for upload
Creating package "mantidimaging"
Creating release "0.0.0"
Uploading file "mantid/mantidimaging/0.0.0/linux-64/mantidimaging-0.0.0-py38_1.tar.bz2"
Warning:  Distribution "linux-64/mantidimaging-0.0.0-py38_1.tar.bz2" already exists. Removing.

Screenshot(s)

@samtygier-stfc
Copy link
Collaborator Author

In the older logs the version gets picked up from git describe here (for some reason the output shows before the commands)

2.4.0a1-58-g67d20792

On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

checkout: 'HEAD'
==> /usr/bin/git log -n1 <==

==> /usr/bin/git describe --tags --dirty <==

==> /usr/bin/git status <==

first bad build is:

 commit b4e79be6bee1f98eb699a41de2ba1af8c258ab7b
Author: rbauststfc <[email protected]>
Date:   Fri Mar 11 12:54:04 2022 +0000

    Merge pull request #1368 from mantidproject/1338-actions-docs
    
    Move doc building into its own workflow

On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

checkout: 'HEAD'
==> /usr/bin/git log -n1 <==

==> /usr/bin/git describe --tags --dirty <==

==> /usr/bin/git status <==

I suspect its removing fetch-depth: 0 in #1368 that has caused the issue. Before we checked out the entire git history, not just the HEAD.

@samtygier-stfc samtygier-stfc added this to the Sprint 2022-03-25 milestone Mar 31, 2022
@samtygier-stfc
Copy link
Collaborator Author

samtygier-stfc commented Mar 31, 2022

actions/checkout#204 fetch-refs might help

Seems that fetch-refs was never implemented.

actions/checkout#217 devs are sticking with the decision to only checkout HEAD by default. To get the tags we either need extra fetch commands, or to go back to a full checkout fetch-depth: 0

@samtygier-stfc
Copy link
Collaborator Author

That built and published mantidimaging-2.4.0a1_108-py38_1.tar.bz2, so it looks like it worked.
https://anaconda.org/mantid/mantidimaging/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant