-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Hub Rate Limits #393
Comments
We could consider falling back to WeasyPrint when the athenapdf Docker pull fails. Having a reliable way to pull the container would be the better solution though. athenapdf has their Dockerfile available if we need it. |
In the case of Athena, we could probably file a PR to also push to the github container registry at these lines and then pull from there: It would require the athena folks setup the access token to allow pushing: https://docs.github.com/en/free-pro-team@latest/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images#authenticating-with-the-container-registry I guess, alternatively, we could setup something in the manubot org to push docker containers that we depend on to our own GCR account, but that seems more brittle. |
Here is the error:
I think the issue is that other AppVeyor users ran jobs that from the same IP address, exceeding the docker pull rate limit:
There's a chance CI providers find a solution. GitHub Container Registry is not a great solution because it requires authentication even to pull (described here), so would be annoying to configure for desktop users and on AppVeyor. So might just be easier to give users the option to authenticate with Docker hub. Caching is a also possibility. Also switching away from athenapdf to pagedjs. |
I agree that it is because of the new Docker Hub limits. I think we might expect to see these becoming pervasive as manubot use increases. Are you sure that the GitHub Container Registry requires logging in to pull? That link seems to be referring to the GitHub Package Registry. The Container Registry docs say:
Also, the naming of this product from GitHub, given the prior one, is just terrible. |
pagedjs looks nice too! is there a ticket for that already? |
Ah I wasn't aware of the distinction between "GitHub Packages Docker registry" (scoped to a repo) and the GitHub Packages Docker registry (scoped to an account). That's great that GHCR will allow anonymous access. On the flip side, publishing images to GHCR from GitHub Actions will require custom credential configuration.
It comes up in #299, but we should have a dedicated issue. Opened #394. |
This excerpt from the GitHub page @dhimmel linked above is worth noting:
There's a chance that post-beta GitHub Container Registry could have the same limitations as Docker Hub. |
Near that it says:
I do agree there's no strong commitment to unlimited, free pulls, but I think that clause is referring to the changes around private ones. |
Good catch @cgreene. The (former) athenapdf maintainer recommended https://thecodingmachine.github.io/gotenberg/ as another alternative. It looks like it is also distributed as a Docker image. |
The new Docker Hub rate limits are causing some builds to fail. I especially notice this with appveyor. Here's an example https://ci.appveyor.com/project/cgreene/annorxiver-manuscript/builds/36473656
It might be nice to examine our dependencies and to see which ones are already on the GitHub Container Registry ( https://github.blog/2020-09-01-introducing-github-container-registry/ ).
The text was updated successfully, but these errors were encountered: