Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

ecs-conex check not appearing in github pull request checks #129

Open
perrygeo opened this issue May 24, 2018 · 1 comment · May be fixed by #131
Open

ecs-conex check not appearing in github pull request checks #129

perrygeo opened this issue May 24, 2018 · 1 comment · May be fixed by #131

Comments

@perrygeo
Copy link
Contributor

I've set up ecs-conex successfully: It shows up as an installed app in my repo's "Integration and Services" and docker images are getting built successfully on each commit.

The only issue is that the PR check is missing from the GitHub UI.

@arunasank noted that we should look at

ecs-conex/utils.sh

Lines 42 to 50 in 8014ea9

function github_status() {
local status=$1
local description=$2
curl -s \
--request POST \
--header "Content-Type: application/json" \
--data "{\"state\":\"${status}\",\"description\":\"${description}\",\"context\":\"ecs-conex\"}" \
${status_url} > /dev/null
}

cc @rclark @arunasank - not urgent unless this is impacting other users. Thanks!

@arunasank
Copy link
Contributor

arunasank commented May 24, 2018

@perrygeo yep, this is on my list, but I haven't found time to look at it yet. Thanks for flagging that this is happening on newer PRs too. 🙇‍♀️ I'll post back here soon as I have updates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants